Profile Images #355
Labels
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
No Milestone
No project
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#355
Loading…
Reference in New Issue
No description provided.
Delete Branch "custom_profile_images"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -66,6 +68,37 @@ class _AddEditProfileViewState extends State<AddEditProfileView> {
});
}
void _showFilePicker(BuildContext ctx) async {
instead of copying aroind the _filepicker function can we make it a reusable widget that takes a function to handle the payload?
@ -69,0 +86,4 @@
if (file.lengthSync() <= 10737418240) {
var profile = Provider.of<ProfileInfoState>(context, listen: false).onion;
// Share this image publically (conversation handle == -1)
Provider.of<FlwtchState>(context, listen: false).cwtch.ShareFile(profile, -1, file.path);
Is there anyway ShareFile can be made more generic and return the filehandle or what not and then a seperate call here can set the profile Attribute for picture. calling sharefile this way to set profile picture feels like a pretty hacky and hidden API "feature".
This may be out of scope but what happens if we pick a new profile pic, is the previous one still being shared as well?
Yup: https://git.openprivacy.ca/cwtch.im/libcwtch-go/src/branch/trunk/lib.go#L741
This falls into the question of how we want to manage file sharing going forward. Currently there is a lot of design space unexplored e.g. do we want to support arbitrary public files? How should we manage them? Do we want to expose specific apis for that v.s. conversation specific apis.
For now, because profile images are the only public files shared, the API does that work for simplicity. It is very likely if we want to go down the path of multiple public files (e.g. keys, stickers, audio) then we are going to need a radically different API (and it will likely not involve returning a filekey to the UI).
It will continue being shared until cwtch is restarted or until 30 days after it was last shared. At some point we will probably want to build an explicit "unshareFile" api.
ugh, i hate it, but its appropriatly commented at least and assumed to prolly be changed with in the year as we continue to develop this so fine, approved! lol
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/553
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/555