Fix Delete Profile Flow #560

Closed
opened 2 months ago by sarah · 1 comments
sarah commented 2 months ago
Owner

Seems like a fallout from the removal of appclient / API needs better error handling.

Ref: cwtch.im/cwtch#473

Seems like a fallout from the removal of appclient / API needs better error handling. Ref: https://git.openprivacy.ca/cwtch.im/cwtch/issues/473
sarah added the
bug
cwtch-beta-1.10
bugbash
labels 2 months ago
sarah added this to the Cwtch Beta (In Progress) project 2 months ago
Poster
Owner

This is actually 2 bugs:

  1. shutdown is called before delete on peer, and because shutdown purges peer maps it causes a NPE
  2. check password is incomplete in peer and needs to also include a check that the underlying database is valid cwtch storage (this only impacts delete peer, as change password was doing the right check) - need to consolidate this logic.

Will integrate these changes into my upcoming Cwtch PR

This is actually 2 bugs: 1. shutdown is called before delete on peer, and because shutdown purges peer maps it causes a NPE 2. check password is incomplete in peer and needs to also include a check that the underlying database is valid cwtch storage (this only impacts delete peer, as change password was doing the right check) - need to consolidate this logic. Will integrate these changes into my upcoming Cwtch PR
sarah self-assigned this 2 weeks ago
sarah added the
in-progress
label 2 weeks ago
sarah referenced this issue from a commit 1 week ago
dan closed this issue 1 week ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#560
Loading…
There is no content yet.