cwtch.im
/
cwtch-ui
10
11
Fork 17
Code Issues 90 Pull Requests 1 Projects 2 Releases 28 Wiki Activity

model contact uses authorization now; add tooltips to contact pics in chat; dual action: add or goto #105

Merged
sarah merged 2 commits from authTooltip into trunk 2021-07-12 21:52:45 +00:00
Conversation 5 Commits 2 Files Changed 15 +194 -98
dan commented 2021-07-09 22:19:22 +00:00
Owner
Copy Link
No description provided.
buildbot commented 2021-07-09 22:26:10 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/99

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/99
sarah requested changes 2021-07-10 00:07:49 +00:00
lib/l10n/intl_de.arb Outdated
@ -47,3 +3,1 @@
"reallyLeaveThisGroupPrompt": "Bist du sicher, dass du diese Unterhaltung beenden möchtest? Alle Nachrichten und Attribute werden gelöscht.",
"leaveGroup": "Unterhaltung beenden",
"inviteToGroup": "Du wurdest eingeladen einer Gruppe beizutreten:",
"@@last_modified": "2021-07-09T23:37:21+02:00",
sarah commented 2021-07-10 00:02:52 +00:00
Owner
Copy Link

Download these in last updated order so it is more obvious what has changed.

Download these in last updated order so it is more obvious what has changed.
dan marked this conversation as resolved
lib/models/message.dart Outdated
@ -123,3 +128,3 @@
}
MessageMetadata(this.profileOnion, this.contactHandle, this.messageIndex, this.timestamp, this.senderHandle, this.senderImage, this.signature, this._flags, this._ackd, this._error);
MessageMetadata(this.profileOnion, this.contactHandle, this.messageIndex, this.timestamp, this.senderHandle, this.senderAuthorization, this.senderImage, this.signature, this._flags, this._ackd, this._error);
sarah commented 2021-07-10 00:06:40 +00:00
Owner
Copy Link

SenderAuthorization can explicitly change outside of the context of this message , it doesn't belong here.

`SenderAuthorization` can explicitly change outside of the context of this message , it doesn't belong here.
dan marked this conversation as resolved
dan force-pushed authTooltip from a47453d596 to 069c4a03f2 2021-07-10 05:26:20 +00:00 Compare
buildbot commented 2021-07-10 05:33:17 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/100

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/100
dan force-pushed authTooltip from 069c4a03f2 to 4d189a5d14 2021-07-10 15:39:38 +00:00 Compare
buildbot commented 2021-07-10 15:46:32 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/101

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/101
sarah reviewed 2021-07-10 17:42:20 +00:00
lib/widgets/messagerow.dart Outdated
@ -107,0 +129,4 @@
onPressed: () {
final setPeerAttribute = {
"EventType": "AddContact",
"Data": {"ImportString": senderOnion},
sarah commented 2021-07-10 17:42:20 +00:00
Owner
Copy Link

Use cwtch.ImportBundle(profileOnion, senderOnion) instead of constructing the Event here, as it is more robust.

Use cwtch.ImportBundle(profileOnion, senderOnion) instead of constructing the Event here, as it is more robust.
dan force-pushed authTooltip from 4d189a5d14 to 3f020472fa 2021-07-12 19:01:25 +00:00 Compare
buildbot commented 2021-07-12 19:09:20 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/102

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/102
sarah added 1 commit 2021-07-12 21:44:08 +00:00
continuous-integration/drone/pr Build is passing Details
80f9ed6a6c Merge branch 'trunk' into authTooltip
buildbot commented 2021-07-12 21:50:16 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/104

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/104
sarah approved these changes 2021-07-12 21:52:41 +00:00
sarah merged commit 6ea793875f into trunk 2021-07-12 21:52:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sarah
Labels
Clear labels   
android

   
arch

   
backlog

   
blocked-on-external

This issue requires effort from an external organization to move forward

  
bug

Something is not working

  
bugbash

   
component/bindings

   
component/bine

   
component/connectivity

   
component/cwtch

   
component/tapir

   
component/ui

   
cwtch-1.14

   
cwtch-1.15

   
cwtch-beta-1.1

   
cwtch-beta-1.10

Changes Planned for Cwtch Beta 1.10

  
cwtch-beta-1.11

   
cwtch-beta-1.12

   
cwtch-beta-1.13

   
cwtch-beta-1.2

   
cwtch-beta-1.3

   
cwtch-beta-1.4

   
cwtch-beta-1.5

   
cwtch-beta-1.5.x

point release vug fixes for 1.5

  
cwtch-beta-1.6

   
cwtch-beta-1.7

   
cwtch-beta-1.8

   
cwtch-beta-1.9

   
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
flutter

   
funding-needed

   
help wanted

Need some help

  
hybrid-groups

   
in-nightly

   
in-progress

   
invalid

Something is wrong

  
ios

   
linux

   
mac

   
need-replication-or-investigation

   
ops

   
packaging

   
post-stable

These issues won't be considered until after Cwtch Stable ships.

  
question

More information is needed

  
questionable

there is an open question as to whether this is an issue at all / if we can even fix this

  
requires-more-effort-than-we-can-spare

The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project

  
rust

   
scheduled

   
stable-blocker

   
tails

   
testing-needed

   
tests

   
tor

   
waiting-on-fix-confirmation

   
waiting-on-new-flutter-feature

The cause of this issue is a bug in the underlying flutter framework.

  
whonix

   
windows

   
wontfix

This won't be fixed

No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#105
No description provided.
Delete Branch "authTooltip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?