Servers experiment and manager #214
No reviewers
Labels
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#214
Loading…
Reference in New Issue
No description provided.
Delete Branch "server"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
depends on cwtch.im/libcwtch-go#33
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/270
WIP: lib/cwtch new servers api coverage and Set[Profile/Contact]Attributeto WIP: Servers experiment and manager1a8763f285
toa55e5a4106
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/271
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/276
a55e5a4106
toed8292ece9
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/277
WIP: Servers experiment and managerto Servers experiment and managerTODO: lokalise all the strings
@ -1,5 +1,7 @@
import 'package:flutter/src/services/text_input.dart';
const DefaultPassword = "be gay do crime";
Comment with https://docs.openprivacy.ca/cwtch-security-handbook/profile_encryption_and_storage.html
@ -29,8 +39,27 @@ class ServerListState extends ChangeNotifier {
}
class ServerInfoState extends ChangeNotifier {
You've changed the semantics of this class and moved the actual use of this class into a different class. This is bad. It makes reviewing this PR much more difficult than it needed to be.
@ -301,3 +299,1 @@
final json = jsonEncode(event);
Provider.of<FlwtchState>(context, listen: false).cwtch.SendProfileEvent(Provider.of<ProfileInfoState>(context, listen: false).onion, json);
Provider.of<FlwtchState>(context, listen: false).cwtch.SetProfileAttribute(Provider.of<ProfileInfoState>(context, listen: false).onion, "public.name", ctrlrNick.value.text);
this should be attempting to set profile.name not public.name
@ -313,3 +304,1 @@
Provider.of<FlwtchState>(context, listen: false).cwtch.SendProfileEvent(Provider.of<ProfileInfoState>(context, listen: false).onion, updateNameEventJson);
Provider.of<FlwtchState>(context, listen: false).cwtch.SetProfileAttribute(Provider.of<ProfileInfoState>(context, listen: false).onion, "public.name", ctrlrNick.value.text);
see above
cool fixed
@ -0,0 +137,4 @@
} else {
Provider.of<FlwtchState>(context, listen: false).cwtch.StopServer(serverInfoState.onion);
}
// ?? serverInfoState.enabled = value; + notify?
delete
@ -0,0 +322,4 @@
if (_formKey.currentState!.validate()) {
// TODO change password
We should hide the ability to change passwords in the UI until this feature is a part of the UI.
hidden
@ -0,0 +144,4 @@
providers: [ChangeNotifierProvider<ServerInfoState>(
create: (_) => ServerInfoState(onion: "", serverBundle: "", description: "", autoStart: true, running: false, isEncrypted: true),
)],
//ChangeNotifierProvider.value(value: Provider.of<ServerInfoState>(context))],
delete
@ -0,0 +86,4 @@
providers: [ChangeNotifierProvider<ServerInfoState>(
create: (_) => server,
)],
//ChangeNotifierProvider.value(value: Provider.of<ServerInfoState>(context))],
delete
@ -109,0 +114,4 @@
}));
// TODO servers
?
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/280
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/281