Servers experiment and manager #214

Merged
dan merged 10 commits from server into trunk 2021-11-02 22:26:10 +00:00
Owner
depends on https://git.openprivacy.ca/cwtch.im/libcwtch-go/pulls/33
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/270
dan changed title from WIP: lib/cwtch new servers api coverage and Set[Profile/Contact]Attribute to WIP: Servers experiment and manager 2021-10-29 23:38:01 +00:00
dan force-pushed server from 1a8763f285 to a55e5a4106 2021-11-02 04:45:46 +00:00 Compare
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/271
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/276
dan force-pushed server from a55e5a4106 to ed8292ece9 2021-11-02 05:17:01 +00:00 Compare
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/277
dan changed title from WIP: Servers experiment and manager to Servers experiment and manager 2021-11-02 05:24:14 +00:00
Author
Owner

TODO: lokalise all the strings

TODO: lokalise all the strings
sarah requested changes 2021-11-02 18:50:08 +00:00
@ -1,5 +1,7 @@
import 'package:flutter/src/services/text_input.dart';
const DefaultPassword = "be gay do crime";
Owner
Comment with https://docs.openprivacy.ca/cwtch-security-handbook/profile_encryption_and_storage.html
dan marked this conversation as resolved
@ -29,8 +39,27 @@ class ServerListState extends ChangeNotifier {
}
class ServerInfoState extends ChangeNotifier {
Owner

You've changed the semantics of this class and moved the actual use of this class into a different class. This is bad. It makes reviewing this PR much more difficult than it needed to be.

You've changed the semantics of this class and moved the actual use of this class into a different class. This is bad. It makes reviewing this PR much more difficult than it needed to be.
dan marked this conversation as resolved
@ -301,3 +299,1 @@
final json = jsonEncode(event);
Provider.of<FlwtchState>(context, listen: false).cwtch.SendProfileEvent(Provider.of<ProfileInfoState>(context, listen: false).onion, json);
Provider.of<FlwtchState>(context, listen: false).cwtch.SetProfileAttribute(Provider.of<ProfileInfoState>(context, listen: false).onion, "public.name", ctrlrNick.value.text);
Owner

this should be attempting to set profile.name not public.name

this should be attempting to set profile.name not public.name
dan marked this conversation as resolved
@ -313,3 +304,1 @@
Provider.of<FlwtchState>(context, listen: false).cwtch.SendProfileEvent(Provider.of<ProfileInfoState>(context, listen: false).onion, updateNameEventJson);
Provider.of<FlwtchState>(context, listen: false).cwtch.SetProfileAttribute(Provider.of<ProfileInfoState>(context, listen: false).onion, "public.name", ctrlrNick.value.text);
Owner

see above

see above
Author
Owner

cool fixed

cool fixed
dan marked this conversation as resolved
@ -0,0 +137,4 @@
} else {
Provider.of<FlwtchState>(context, listen: false).cwtch.StopServer(serverInfoState.onion);
}
// ?? serverInfoState.enabled = value; + notify?
Owner

delete

delete
dan marked this conversation as resolved
@ -0,0 +322,4 @@
if (_formKey.currentState!.validate()) {
// TODO change password
Owner

We should hide the ability to change passwords in the UI until this feature is a part of the UI.

We should hide the ability to change passwords in the UI until this feature is a part of the UI.
Author
Owner

hidden

hidden
dan marked this conversation as resolved
@ -0,0 +144,4 @@
providers: [ChangeNotifierProvider<ServerInfoState>(
create: (_) => ServerInfoState(onion: "", serverBundle: "", description: "", autoStart: true, running: false, isEncrypted: true),
)],
//ChangeNotifierProvider.value(value: Provider.of<ServerInfoState>(context))],
Owner

delete

delete
dan marked this conversation as resolved
@ -0,0 +86,4 @@
providers: [ChangeNotifierProvider<ServerInfoState>(
create: (_) => server,
)],
//ChangeNotifierProvider.value(value: Provider.of<ServerInfoState>(context))],
Owner

delete

delete
dan marked this conversation as resolved
dan added 2 commits 2021-11-02 21:48:56 +00:00
continuous-integration/drone/pr Build is pending Details
e9407ae426
fixing as per PR
dan added 1 commit 2021-11-02 22:10:40 +00:00
continuous-integration/drone/pr Build is passing Details
3e75c4d106
last cleanup
sarah approved these changes 2021-11-02 22:13:05 +00:00
@ -109,0 +114,4 @@
}));
// TODO servers
Owner

?

?
dan added 1 commit 2021-11-02 22:13:17 +00:00
continuous-integration/drone/pr Build is passing Details
60a4775f4d
libcwtch bump
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/280
dan added 1 commit 2021-11-02 22:19:20 +00:00
continuous-integration/drone/pr Build is pending Details
82294eb6af
proper tooltips
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/281
dan merged commit a9bcf13c1f into trunk 2021-11-02 22:26:10 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#214
No description provided.