New Themes #260

Merged
sarah merged 10 commits from themes into trunk 2021-12-15 22:30:39 +00:00
Owner

ideally needs cwtch.im/libcwtch-go#50 so it can save

Massive theme engine refactor, including some semantic tweaks to theme color names, changing themes from having methods to dart get fields to make theme files much smaller.

themes:

  • neon1
  • witch
  • vampire
  • ghost
  • pumpkin
  • mermaid
  • midnight
  • pumpkin
  • neon2
ideally needs https://git.openprivacy.ca/cwtch.im/libcwtch-go/pulls/50 so it can save Massive theme engine refactor, including some semantic tweaks to theme color names, changing themes from having methods to dart `get` fields to make theme files much smaller. themes: - [x] neon1 - [x] witch - [x] vampire - [x] ghost - [x] pumpkin - [x] mermaid - [x] midnight - [x] pumpkin - [x] neon2
dan force-pushed themes from 6cc038e72b to d59a04c635 2021-12-10 04:23:38 +00:00 Compare
dan force-pushed themes from 1cf5b7bc5f to f68b31ee8b 2021-12-11 05:07:55 +00:00 Compare
dan changed title from WIP: new themes to New Themes 2021-12-11 05:08:13 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/376
dan force-pushed themes from f68b31ee8b to 87940dfefe 2021-12-14 16:47:52 +00:00 Compare
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/385
sarah reviewed 2021-12-14 20:34:36 +00:00
sarah left a comment
Owner

Recommend @erinn takes a look at this

Commented code needs to be deleted or justified

I'd like to see localizations done prior to merging.

Recommend @erinn takes a look at this Commented code needs to be deleted or justified I'd like to see localizations done prior to merging.
@ -0,0 +25,4 @@
final Color pink = Color(0xFFE85DA1); // not in new: active button color
final Color hotPink = Color(0xFFD20070); // Color(0xFFD01972);
final Color softGrey = Color(0xFFB3B6B3); // not in new theme: blocked
//static final Color softGreen = Color(0xFFA0FFB0);
Owner

delete

delete
dan marked this conversation as resolved
@ -0,0 +56,4 @@
get sendHintTextColor => mauvePurple;
get hilightElementColor => purple;
get defaultButtonColor => accent; //hotPink;
//get defaultButtonActiveColor => pink;
Owner

delete

delete
@ -0,0 +41,4 @@
get messageFromOtherBackgroundColor => peerBubble; //deepPurple;
get messageFromOtherTextColor => font; //whiteishPurple;
/*get backgroundHilightElementColor => deepPurple;
Owner

delete

delete
dan marked this conversation as resolved
@ -0,0 +90,4 @@
get messageFromOtherBackgroundColor => peerBubble; //purple;
get messageFromOtherTextColor => font; //darkPurple;
/*get backgroundHilightElementColor => softPurple;
Owner

delete

delete
@ -34,3 +34,4 @@
late bool usePassword;
//late bool deleted;
Owner

delete?

delete?
dan marked this conversation as resolved
@ -84,2 +85,2 @@
title: Text(AppLocalizations.of(context)!.settingUIColumnPortrait, style: TextStyle(color: settings.current().mainTextColor())),
leading: Icon(Icons.table_chart, color: settings.current().mainTextColor()),
title: Text("Colour Theme"),
//AppLocalizations.of(context)!.settingTheme)),
Owner

delete

delete
dan marked this conversation as resolved
erinn approved these changes 2021-12-15 01:22:02 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/384
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/386
dan force-pushed themes from a9282f5f95 to 124694447b 2021-12-15 20:24:16 +00:00 Compare
dan added 1 commit 2021-12-15 20:28:55 +00:00
continuous-integration/drone/pr Build is passing Details
b29bb1e4dc
clean up comments, delete old code, pr comments
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/390
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/391
dan added 1 commit 2021-12-15 22:29:52 +00:00
continuous-integration/drone/pr Build is pending Details
abf4d79e80
flutter format
sarah merged commit 0ef219bbb6 into trunk 2021-12-15 22:30:39 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#260
No description provided.