formatting_toolbar #475

Merged
sarah merged 4 commits from formatting_toolbar into trunk 2022-06-15 03:14:17 +00:00
Owner
No description provided.
sarah added 2 commits 2022-06-15 01:28:58 +00:00
continuous-integration/drone/pr Build was killed Details
3961692817
Nicer Quoted Messages
sarah force-pushed formatting_toolbar from 6a97679c4c to 04c335e7a4 2022-06-15 01:30:12 +00:00 Compare
dan reviewed 2022-06-15 01:38:41 +00:00
dan left a comment
Owner

looks pretty good? few small comments

looks pretty good? few small comments
@ -319,0 +324,4 @@
padding: EdgeInsets.all(8),
child: SelectableLinkify(
text: ctrlrCompose.text + '\n',
// TODO: onOpen breaks the "selectable" functionality. Maybe something to do with gesture handler?
Owner

TODO?

TODO?
@ -319,0 +328,4 @@
options: LinkifyOptions(messageFormatting: true, parseLinks: showClickableLinks, looseUrl: true, defaultToHttps: true),
linkifiers: [UrlLinkifier()],
onOpen: showClickableLinks ? null : null,
//key: Key(myKey),
Owner

uncomment?

uncomment?
@ -368,3 +364,1 @@
onPressed: isOffline ? null : _sendMessage,
))),
)))),
height: 164 + ((ctrlrCompose.text.split("\n").length - 1) * 16),
Owner

what this math? maybe a comment? dunno

what this math? maybe a comment? dunno
@ -160,3 +156,4 @@
if (DateTime.now().difference(date).inDays > 0) {
return DateFormat.yMd(Platform.localeName).format(date.toLocal());
}
// Otherwise just state the time.
Owner

this part actually doesnt appear to be working?

this part actually doesnt appear to be working?
sarah added 1 commit 2022-06-15 01:44:43 +00:00
continuous-integration/drone/pr Build is passing Details
7bae6485f7
Fixup Formatting PR (Dans Comments)
dan approved these changes 2022-06-15 01:46:49 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/778
sarah merged commit 644ae502e5 into trunk 2022-06-15 03:14:17 +00:00
Sign in to join this conversation.
No reviewers
dan
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#475
No description provided.