From 3d7ccf4be2adb12242b1a720553f3adfcd461817 Mon Sep 17 00:00:00 2001 From: Sarah Jamie Lewis Date: Tue, 2 Jan 2024 13:14:06 -0800 Subject: [PATCH] Improve quality.sh --- testing/quality.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/testing/quality.sh b/testing/quality.sh index 0961079..e8f071a 100755 --- a/testing/quality.sh +++ b/testing/quality.sh @@ -4,16 +4,17 @@ echo "Checking code quality (you want to see no output here)" echo "" echo "" -echo "Linting:" +echo "Running staticcheck..." staticcheck ./... -# In the future we should enable this by default. However, there are a few false positives that make this +# In the future we should remove include-pkgs. However, there are a few false positives in the overall go stdlib that make this # too noisy right now, specifically assigning nil to initialize slices (safe), and using go internal context channels assigned # nil (also safe). # We also have one file infinite_channel.go written in a way that static analysis cannot reason about easily. So it is explictly # ignored. -# nilaway -exclude-file-docstrings="nolint:nilaway" ./... +echo "Running nilaway..." +nilaway -include-pkgs="cwtch.im/cwtch,cwtch.im/tapir,git.openprivacy.ca/openprivacy/connectivity" -exclude-file-docstrings="nolint:nilaway" ./... echo "Time to format" gofmt -l -s -w .