From 861390b11d20b252f28059ff1dec400ca81b0815 Mon Sep 17 00:00:00 2001 From: Sarah Jamie Lewis Date: Wed, 25 Jan 2023 12:34:58 -0800 Subject: [PATCH] Rename API --- extensions/profile_value.go | 4 ++-- .../filesharing/filesharing_functionality.go | 4 ++-- peer/cwtch_peer.go | 2 +- peer/hooks.go | 12 ++++++------ 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/extensions/profile_value.go b/extensions/profile_value.go index 1a5327f..3855807 100644 --- a/extensions/profile_value.go +++ b/extensions/profile_value.go @@ -14,11 +14,11 @@ import ( type ProfileValueExtension struct { } -func (pne ProfileValueExtension) RegisterEvents() []event.Type { +func (pne ProfileValueExtension) EventsToRegister() []event.Type { return nil } -func (pne ProfileValueExtension) RegisterExperiments() []string { +func (pne ProfileValueExtension) ExperimentsToRegister() []string { return nil } diff --git a/functionality/filesharing/filesharing_functionality.go b/functionality/filesharing/filesharing_functionality.go index 1f6625a..87c87a4 100644 --- a/functionality/filesharing/filesharing_functionality.go +++ b/functionality/filesharing/filesharing_functionality.go @@ -30,11 +30,11 @@ import ( type Functionality struct { } -func (f Functionality) RegisterEvents() []event.Type { +func (f Functionality) EventsToRegister() []event.Type { return []event.Type{event.ManifestReceived, event.FileDownloaded} } -func (f Functionality) RegisterExperiments() []string { +func (f Functionality) ExperimentsToRegister() []string { return []string{constants.FileSharingExperiment} } diff --git a/peer/cwtch_peer.go b/peer/cwtch_peer.go index e62c2bd..88aef1a 100644 --- a/peer/cwtch_peer.go +++ b/peer/cwtch_peer.go @@ -101,7 +101,7 @@ func (cp *cwtchPeer) RegisterHook(extension ProfileHooks) { defer cp.extensionLock.Unlock() // Register Requested Events - for _, event := range extension.RegisterEvents() { + for _, event := range extension.EventsToRegister() { cp.eventBus.Subscribe(event, cp.queue) } diff --git a/peer/hooks.go b/peer/hooks.go index 1f4b545..33eec53 100644 --- a/peer/hooks.go +++ b/peer/hooks.go @@ -7,11 +7,11 @@ import ( ) type ProfileHooks interface { - // RegisterEvents returns a set of events that the extension is interested hooking - RegisterEvents() []event.Type + // EventsToRegister returns a set of events that the extension is interested hooking + EventsToRegister() []event.Type - // RegisterExperiments returns a set of experiments that the extension is interested in being notified about - RegisterExperiments() []string + // ExperimentsToRegister returns a set of experiments that the extension is interested in being notified about + ExperimentsToRegister() []string // OnEvent is called whenever an event Registered with RegisterEvents is called OnEvent(event event.Event, profile CwtchPeer) @@ -31,12 +31,12 @@ type ProfileHook struct { func ConstructHook(extension ProfileHooks) ProfileHook { events := make(map[event.Type]bool) - for _, event := range extension.RegisterEvents() { + for _, event := range extension.EventsToRegister() { events[event] = true } experiments := make(map[string]bool) - for _, experiment := range extension.RegisterExperiments() { + for _, experiment := range extension.ExperimentsToRegister() { experiments[experiment] = true }