.drone.yml

@@ -5,29 +5,27 @@ name: linux-test
 
 steps:
   - name: fetch
-    image: golang:1.21.5
+    image: golang:1.19.1
     volumes:
       - name: deps
         path: /go
     commands:
       - go install honnef.co/go/tools/cmd/staticcheck@latest
-      - go install go.uber.org/nilaway/cmd/nilaway@latest
-      - wget https://git.openprivacy.ca/openprivacy/buildfiles/raw/branch/master/tor/tor-0.4.8.9-linux-x86_64.tar.gz -O tor.tar.gz
-      - tar -xzf tor.tar.gz
-      - chmod a+x Tor/tor
-      - export PATH=$PWD/Tor/:$PATH
-      - export LD_LIBRARY_PATH=$PWD/Tor/
-      - tor --version
+      - wget https://git.openprivacy.ca/openprivacy/buildfiles/raw/master/tor/tor
+      - wget https://git.openprivacy.ca/openprivacy/buildfiles/raw/master/tor/torrc
+      - chmod a+x tor
+      - go get -u golang.org/x/lint/golint
       - export GO111MODULE=on
+      - go mod vendor
   - name: quality
-    image: golang:1.21.5
+    image: golang:1.19.1
     volumes:
       - name: deps
         path: /go
     commands:
-      - ./testing/quality.sh
+      - staticcheck ./...
   - name: units-tests
-    image: golang:1.21.5
+    image: golang:1.19.1
     volumes:
       - name: deps
         path: /go
@@ -35,33 +33,21 @@ steps:
       - export PATH=`pwd`:$PATH
       - sh testing/tests.sh
   - name: integ-test
-    image: golang:1.21.5
+    image: golang:1.19.1
     volumes:
       - name: deps
         path: /go
     commands:
-      - export PATH=$PWD/Tor/:$PATH
-      - export LD_LIBRARY_PATH=$PWD/Tor/
-      - tor --version
+      - export PATH=`pwd`:$PATH
       - go test -timeout=30m -race -v cwtch.im/cwtch/testing/
   - name: filesharing-integ-test
-    image: golang:1.21.5
+    image: golang:1.19.1
     volumes:
       - name: deps
         path: /go
     commands:
-      - export PATH=$PWD/Tor/:$PATH
-      - export LD_LIBRARY_PATH=$PWD/Tor/
+      - export PATH=`pwd`:$PATH
       - go test -timeout=20m -race -v cwtch.im/cwtch/testing/filesharing
-  - name: filesharing-autodownload-integ-test
-    image: golang:1.21.5
-    volumes:
-      - name: deps
-        path: /go
-    commands:
-      - export PATH=$PWD/Tor/:$PATH
-      - export LD_LIBRARY_PATH=$PWD/Tor/
-      - go test -timeout=20m -race -v cwtch.im/cwtch/testing/autodownload
   - name: notify-gogs
     image: openpriv/drone-gogs
     pull: if-not-exists

.gitignore

@@ -31,8 +31,4 @@ testing/encryptedstorage/tordir
 *.tar.gz
 data-dir-cwtchtool/
 tokens
-tordir/
-testing/autodownload/download_dir
-testing/autodownload/storage
-*.swp
-testing/managerstorage/*
+tordir/

app/app.go

@@ -3,15 +3,11 @@ package app
 import (
 	"cwtch.im/cwtch/app/plugins"
 	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/extensions"
-	"cwtch.im/cwtch/functionality/filesharing"
-	"cwtch.im/cwtch/functionality/servers"
 	"cwtch.im/cwtch/model"
 	"cwtch.im/cwtch/model/attr"
 	"cwtch.im/cwtch/model/constants"
 	"cwtch.im/cwtch/peer"
 	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
 	"cwtch.im/cwtch/storage"
 	"git.openprivacy.ca/openprivacy/connectivity"
 	"git.openprivacy.ca/openprivacy/log"
@@ -25,37 +21,24 @@ type application struct {
 	eventBuses map[string]event.Manager
 	directory  string
 
-	peers   map[string]peer.CwtchPeer
-	acn     connectivity.ACN
-	plugins sync.Map //map[string] []plugins.Plugin
+	peerLock sync.Mutex
+	peers    map[string]peer.CwtchPeer
+	acn      connectivity.ACN
+	plugins  sync.Map //map[string] []plugins.Plugin
 
-	engines     map[string]connections.Engine
-	appBus      event.Manager
-	eventQueue  event.Queue
-	appmutex    sync.Mutex
-	engineHooks connections.EngineHooks
-
-	settings *settings.GlobalSettingsFile
-}
-
-func (app *application) IsFeatureEnabled(experiment string) bool {
-	globalSettings := app.ReadSettings()
-	if globalSettings.ExperimentsEnabled {
-		if status, exists := globalSettings.Experiments[experiment]; exists {
-			return status
-		}
-	}
-	return false
+	engines  map[string]connections.Engine
+	appBus   event.Manager
+	appmutex sync.Mutex
 }
 
 // Application is a full cwtch peer application. It allows management, usage and storage of multiple peers
 type Application interface {
 	LoadProfiles(password string)
-	CreateProfile(name string, password string, autostart bool)
-	InstallEngineHooks(engineHooks connections.EngineHooks)
+	CreatePeer(name string, password string, attributes map[attr.ZonedPath]string)
+	// Deprecated in 1.10
+	CreateTaggedPeer(name string, password string, tag string)
 	ImportProfile(exportedCwtchFile string, password string) (peer.CwtchPeer, error)
-	EnhancedImportProfile(exportedCwtchFile string, password string) string
-	DeleteProfile(onion string, currentPassword string)
+	DeletePeer(onion string, currentPassword string)
 	AddPeerPlugin(onion string, pluginID plugins.PluginID)
 
 	GetPrimaryBus() event.Manager
@@ -63,14 +46,10 @@ type Application interface {
 	QueryACNStatus()
 	QueryACNVersion()
 
-	ConfigureConnections(onion string, doListn, doPeers, doServers bool)
-	ActivatePeerEngine(onion string)
+	ActivateEngines(doListn, doPeers, doServers bool)
+	ActivatePeerEngine(onion string, doListen, doPeers, doServers bool)
 	DeactivatePeerEngine(onion string)
 
-	ReadSettings() settings.GlobalSettings
-	UpdateSettings(settings settings.GlobalSettings)
-	IsFeatureEnabled(experiment string) bool
-
 	ShutdownPeer(string)
 	Shutdown()
 
@@ -81,26 +60,14 @@ type Application interface {
 // LoadProfileFn is the function signature for a function in an app that loads a profile
 type LoadProfileFn func(profile peer.CwtchPeer)
 
-func LoadAppSettings(appDirectory string) *settings.GlobalSettingsFile {
+// NewApp creates a new app with some environment awareness and initializes a Tor Manager
+func NewApp(acn connectivity.ACN, appDirectory string) Application {
 	log.Debugf("NewApp(%v)\n", appDirectory)
 	os.MkdirAll(path.Join(appDirectory, "profiles"), 0700)
 
-	// Note: we basically presume this doesn't fail. If the file doesn't exist we create it, and as such the
-	// only plausible error conditions are related to file create e.g. low disk space. If that is the case then
-	// many other parts of Cwtch are likely to fail also.
-	globalSettingsFile, err := settings.InitGlobalSettingsFile(appDirectory, DefactoPasswordForUnencryptedProfiles)
-	if err != nil {
-		log.Errorf("error initializing global globalSettingsFile file %s. Global globalSettingsFile might not be loaded or saved", err)
-	}
-	return globalSettingsFile
-}
-
-// NewApp creates a new app with some environment awareness and initializes a Tor Manager
-func NewApp(acn connectivity.ACN, appDirectory string, settings *settings.GlobalSettingsFile) Application {
-
-	app := &application{engines: make(map[string]connections.Engine), eventBuses: make(map[string]event.Manager), directory: appDirectory, appBus: event.NewEventManager(), settings: settings, eventQueue: event.NewQueue()}
+	app := &application{engines: make(map[string]connections.Engine), eventBuses: make(map[string]event.Manager), directory: appDirectory, appBus: event.NewEventManager()}
 	app.peers = make(map[string]peer.CwtchPeer)
-	app.engineHooks = connections.DefaultEngineHooks{}
+
 	app.acn = acn
 	statusHandler := app.getACNStatusHandler()
 	acn.SetStatusCallback(statusHandler)
@@ -108,51 +75,15 @@ func NewApp(acn connectivity.ACN, appDirectory string, settings *settings.Global
 	prog, status := acn.GetBootstrapStatus()
 	statusHandler(prog, status)
 
-	app.GetPrimaryBus().Subscribe(event.ACNStatus, app.eventQueue)
-	go app.eventHandler()
-
 	return app
 }
 
-func (app *application) InstallEngineHooks(engineHooks connections.EngineHooks) {
-	app.appmutex.Lock()
-	defer app.appmutex.Unlock()
-	app.engineHooks = engineHooks
-}
-
-func (app *application) ReadSettings() settings.GlobalSettings {
-	app.appmutex.Lock()
-	defer app.appmutex.Unlock()
-	return app.settings.ReadGlobalSettings()
-}
-
-func (app *application) UpdateSettings(settings settings.GlobalSettings) {
-	// don't allow any other application changes while settings update
-	app.appmutex.Lock()
-	defer app.appmutex.Unlock()
-	app.settings.WriteGlobalSettings(settings)
-
-	for _, profile := range app.peers {
-		profile.UpdateExperiments(settings.ExperimentsEnabled, settings.Experiments)
-
-		// Explicitly toggle blocking/unblocking of unknown connections for profiles
-		// that have been loaded.
-		if settings.BlockUnknownConnections {
-			profile.BlockUnknownConnections()
-		} else {
-			profile.AllowUnknownConnections()
-		}
-
-		profile.NotifySettingsUpdate(settings)
-	}
-}
-
 // ListProfiles returns a map of onions to their profile's Name
 func (app *application) ListProfiles() []string {
 	var keys []string
 
-	app.appmutex.Lock()
-	defer app.appmutex.Unlock()
+	app.peerLock.Lock()
+	defer app.peerLock.Unlock()
 	for handle := range app.peers {
 		keys = append(keys, handle)
 	}
@@ -161,20 +92,18 @@ func (app *application) ListProfiles() []string {
 
 // GetPeer returns a cwtchPeer for a given onion address
 func (app *application) GetPeer(onion string) peer.CwtchPeer {
-	app.appmutex.Lock()
-	defer app.appmutex.Unlock()
-	if profile, ok := app.peers[onion]; ok {
-		return profile
+	if peer, ok := app.peers[onion]; ok {
+		return peer
 	}
 	return nil
 }
 
-func (app *application) AddPlugin(peerid string, id plugins.PluginID, bus event.Manager, acn connectivity.ACN) {
-	if _, exists := app.plugins.Load(peerid); !exists {
-		app.plugins.Store(peerid, []plugins.Plugin{})
+func (ap *application) AddPlugin(peerid string, id plugins.PluginID, bus event.Manager, acn connectivity.ACN) {
+	if _, exists := ap.plugins.Load(peerid); !exists {
+		ap.plugins.Store(peerid, []plugins.Plugin{})
 	}
 
-	pluginsinf, _ := app.plugins.Load(peerid)
+	pluginsinf, _ := ap.plugins.Load(peerid)
 	peerPlugins := pluginsinf.([]plugins.Plugin)
 
 	for _, plugin := range peerPlugins {
@@ -189,45 +118,15 @@ func (app *application) AddPlugin(peerid string, id plugins.PluginID, bus event.
 		newp.Start()
 		peerPlugins = append(peerPlugins, newp)
 		log.Debugf("storing plugin for %v %v", peerid, peerPlugins)
-		app.plugins.Store(peerid, peerPlugins)
+		ap.plugins.Store(peerid, peerPlugins)
 	} else {
 		log.Errorf("error adding plugin: %v", err)
 	}
 }
 
-func (app *application) CreateProfile(name string, password string, autostart bool) {
-	autostartVal := constants.True
-	if !autostart {
-		autostartVal = constants.False
-	}
-	tagVal := constants.ProfileTypeV1Password
-	if password == DefactoPasswordForUnencryptedProfiles {
-		tagVal = constants.ProfileTypeV1DefaultPassword
-	}
-
-	app.CreatePeer(name, password, map[attr.ZonedPath]string{
-		attr.ProfileZone.ConstructZonedPath(constants.Tag):           tagVal,
-		attr.ProfileZone.ConstructZonedPath(constants.PeerAutostart): autostartVal,
-	})
-}
-
-func (app *application) setupPeer(profile peer.CwtchPeer) {
-	eventBus := event.NewEventManager()
-	app.eventBuses[profile.GetOnion()] = eventBus
-
-	// Initialize the Peer with the Given Event Bus
-	app.peers[profile.GetOnion()] = profile
-	profile.Init(eventBus)
-
-	// Update the Peer with the Most Recent Experiment State...
-	globalSettings := app.settings.ReadGlobalSettings()
-	profile.UpdateExperiments(globalSettings.ExperimentsEnabled, globalSettings.Experiments)
-	app.registerHooks(profile)
-
-	// Register the Peer With Application Plugins..
-	app.AddPeerPlugin(profile.GetOnion(), plugins.CONNECTIONRETRY) // Now Mandatory
-	app.AddPeerPlugin(profile.GetOnion(), plugins.HEARTBEAT)       // Now Mandatory
-
+// Deprecated in 1.10
+func (app *application) CreateTaggedPeer(name string, password string, tag string) {
+	app.CreatePeer(name, password, map[attr.ZonedPath]string{attr.ProfileZone.ConstructZonedPath(constants.Tag): tag})
 }
 
 func (app *application) CreatePeer(name string, password string, attributes map[attr.ZonedPath]string) {
@@ -243,38 +142,30 @@ func (app *application) CreatePeer(name string, password string, attributes map[
 		return
 	}
 
-	app.setupPeer(profile)
+	eventBus := event.NewEventManager()
+	app.eventBuses[profile.GetOnion()] = eventBus
+	profile.Init(app.eventBuses[profile.GetOnion()])
+	app.peers[profile.GetOnion()] = profile
 
 	for zp, val := range attributes {
 		zone, key := attr.ParseZone(zp.ToString())
 		profile.SetScopedZonedAttribute(attr.LocalScope, zone, key, val)
 	}
 
+	app.AddPeerPlugin(profile.GetOnion(), plugins.CONNECTIONRETRY) // Now Mandatory
 	app.appBus.Publish(event.NewEvent(event.NewPeer, map[event.Field]string{event.Identity: profile.GetOnion(), event.Created: event.True}))
 }
 
-func (app *application) DeleteProfile(onion string, password string) {
-	log.Debugf("DeleteProfile called on %v\n", onion)
+func (app *application) DeletePeer(onion string, password string) {
+	log.Infof("DeletePeer called on %v\n", onion)
 	app.appmutex.Lock()
 	defer app.appmutex.Unlock()
 
-	// short circuit to prevent nil-pointer panic if this function is called twice (or incorrectly)
-	peer := app.peers[onion]
-	if peer == nil {
-		log.Errorf("shutdownPeer called with invalid onion %v", onion)
-		return
-	}
-
-	// allow a blank password to delete "unencrypted" accounts...
-	if password == "" {
-		password = DefactoPasswordForUnencryptedProfiles
-	}
-
-	if peer.CheckPassword(password) {
+	if app.peers[onion].CheckPassword(password) {
 		// soft-shutdown
-		peer.Shutdown()
+		app.peers[onion].Shutdown()
 		// delete the underlying storage
-		peer.Delete()
+		app.peers[onion].Delete()
 		// hard shutdown / remove from app
 		app.shutdownPeer(onion)
 
@@ -299,14 +190,6 @@ func (app *application) ImportProfile(exportedCwtchFile string, password string)
 	return profile, err
 }
 
-func (app *application) EnhancedImportProfile(exportedCwtchFile string, password string) string {
-	_, err := app.ImportProfile(exportedCwtchFile, password)
-	if err == nil {
-		return ""
-	}
-	return err.Error()
-}
-
 // LoadProfiles takes a password and attempts to load any profiles it can from storage with it and create Peers for them
 func (app *application) LoadProfiles(password string) {
 	count := 0
@@ -342,7 +225,6 @@ func (app *application) LoadProfiles(password string) {
 			cps, err := peer.CreateEncryptedStore(profileDirectory, password)
 			if err != nil {
 				log.Errorf("error creating encrypted store: %v", err)
-				continue
 			}
 			profile := peer.ImportLegacyProfile(legacyProfile, cps)
 			loaded = app.installProfile(profile)
@@ -360,17 +242,6 @@ func (app *application) LoadProfiles(password string) {
 	}
 }
 
-func (app *application) registerHooks(profile peer.CwtchPeer) {
-	// Register Hooks
-	profile.RegisterHook(extensions.ProfileValueExtension{})
-	profile.RegisterHook(extensions.SendWhenOnlineExtension{})
-	profile.RegisterHook(new(filesharing.Functionality))
-	profile.RegisterHook(new(filesharing.ImagePreviewsFunctionality))
-	profile.RegisterHook(new(servers.Functionality))
-	// Ensure that Profiles have the Most Up to Date Settings...
-	profile.NotifySettingsUpdate(app.settings.ReadGlobalSettings())
-}
-
 // installProfile takes a profile and if it isn't loaded in the app, installs it and returns true
 func (app *application) installProfile(profile peer.CwtchPeer) bool {
 	app.appmutex.Lock()
@@ -378,8 +249,11 @@ func (app *application) installProfile(profile peer.CwtchPeer) bool {
 
 	// Only attempt to finalize the profile if we don't have one loaded...
 	if app.peers[profile.GetOnion()] == nil {
-		app.setupPeer(profile)
-		// Finalize the Creation of Peer / Notify any Interfaces..
+		eventBus := event.NewEventManager()
+		app.eventBuses[profile.GetOnion()] = eventBus
+		profile.Init(app.eventBuses[profile.GetOnion()])
+		app.peers[profile.GetOnion()] = profile
+		app.AddPeerPlugin(profile.GetOnion(), plugins.CONNECTIONRETRY) // Now Mandatory
 		app.appBus.Publish(event.NewEvent(event.NewPeer, map[event.Field]string{event.Identity: profile.GetOnion(), event.Created: event.False}))
 		return true
 	}
@@ -388,57 +262,45 @@ func (app *application) installProfile(profile peer.CwtchPeer) bool {
 	return false
 }
 
-// ActivatePeerEngine creates a peer engine for use with an ACN, should be called once the underlying ACN is online
-func (app *application) ActivatePeerEngine(onion string) {
-	profile := app.GetPeer(onion)
-	if profile != nil {
-		if _, exists := app.engines[onion]; !exists {
-			eventBus, exists := app.eventBuses[profile.GetOnion()]
+// ActivateEngines launches all peer engines
+func (app *application) ActivateEngines(doListen, doPeers, doServers bool) {
+	log.Debugf("ActivateEngines")
 
-			if !exists {
-				// todo handle this case?
-				log.Errorf("cannot activate peer engine without an event bus")
-				return
-			}
+	for _, profile := range app.peers {
+		app.engines[profile.GetOnion()], _ = profile.GenerateProtocolEngine(app.acn, app.eventBuses[profile.GetOnion()])
+		app.eventBuses[profile.GetOnion()].Publish(event.NewEventList(event.ProtocolEngineCreated))
+	}
+	app.QueryACNStatus()
 
-			engine, err := profile.GenerateProtocolEngine(app.acn, eventBus, app.engineHooks)
-			if err == nil {
-				log.Debugf("restartFlow: Creating a New Protocol Engine...")
-				app.engines[profile.GetOnion()] = engine
-				eventBus.Publish(event.NewEventList(event.ProtocolEngineCreated))
-				app.QueryACNStatus()
-			} else {
-				log.Errorf("corrupted profile detected for %v", onion)
-			}
+	if doListen {
+		for _, profile := range app.peers {
+			log.Debugf("  Listen for %v", profile.GetOnion())
+			profile.Listen()
+		}
+	}
+
+	if doPeers || doServers {
+		for _, profile := range app.peers {
+			log.Debugf("  Start Connections for %v doPeers:%v doServers:%v", profile.GetOnion(), doPeers, doServers)
+			profile.StartConnections(doPeers, doServers)
 		}
 	}
 }
 
-// ConfigureConnections autostarts the given kinds of connections.
-func (app *application) ConfigureConnections(onion string, listen bool, peers bool, servers bool) {
+// ActivePeerEngine creates a peer engine for use with an ACN, should be called once the underlying ACN is online
+func (app *application) ActivatePeerEngine(onion string, doListen, doPeers, doServers bool) {
 	profile := app.GetPeer(onion)
 	if profile != nil {
+		if _, exists := app.engines[onion]; !exists {
+			app.engines[profile.GetOnion()], _ = profile.GenerateProtocolEngine(app.acn, app.eventBuses[profile.GetOnion()])
 
-		profileBus, exists := app.eventBuses[profile.GetOnion()]
-		if exists {
-			// if we are making a decision to ignore
-			if !peers || !servers {
-				profileBus.Publish(event.NewEventList(event.PurgeRetries))
-			}
-
-			// enable the engine if it doesn't exist...
-			// note: this function is idempotent
-			app.ActivatePeerEngine(onion)
-			if listen {
+			app.eventBuses[profile.GetOnion()].Publish(event.NewEventList(event.ProtocolEngineCreated))
+			app.QueryACNStatus()
+			if doListen {
 				profile.Listen()
 			}
-
-			profileBus.Publish(event.NewEventList(event.ResumeRetries))
-			// do this in the background, for large contact lists it can take a long time...
-			go profile.StartConnections(peers, servers)
+			profile.StartConnections(doPeers, doServers)
 		}
-	} else {
-		log.Errorf("profile does not exist %v", onion)
 	}
 }
 
@@ -493,56 +355,6 @@ func (app *application) QueryACNVersion() {
 	app.appBus.Publish(event.NewEventList(event.ACNVersion, event.Data, version))
 }
 
-func (app *application) eventHandler() {
-	acnStatus := -1
-	for {
-		e := app.eventQueue.Next()
-		switch e.EventType {
-		case event.ACNStatus:
-			newAcnStatus, err := strconv.Atoi(e.Data[event.Progress])
-			if err != nil {
-				break
-			}
-			if newAcnStatus == 100 {
-				if acnStatus != 100 {
-					for _, onion := range app.ListProfiles() {
-						profile := app.GetPeer(onion)
-						if profile != nil {
-							autostart, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.PeerAutostart)
-							appearOffline, appearOfflineExists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.PeerAppearOffline)
-							if !exists || autostart == "true" {
-								if appearOfflineExists && appearOffline == "true" {
-									// don't configure any connections...
-									log.Infof("peer appearing offline, not launching listen threads or connecting jobs")
-									app.ConfigureConnections(onion, false, false, false)
-								} else {
-									app.ConfigureConnections(onion, true, true, true)
-								}
-							}
-
-						}
-					}
-				}
-			} else {
-				if acnStatus == 100 {
-					// just fell offline
-					for _, onion := range app.ListProfiles() {
-						app.DeactivatePeerEngine(onion)
-					}
-				}
-			}
-			acnStatus = newAcnStatus
-
-		default:
-			// invalid event, signifies shutdown
-			if e.EventType == "" {
-				return
-			}
-
-		}
-	}
-}
-
 // ShutdownPeer shuts down a peer and removes it from the app's management
 func (app *application) ShutdownPeer(onion string) {
 	app.appmutex.Lock()
@@ -551,33 +363,21 @@ func (app *application) ShutdownPeer(onion string) {
 }
 
 // shutdownPeer mutex unlocked helper shutdown peer
-//
-//nolint:nilaway
 func (app *application) shutdownPeer(onion string) {
-
-	// short circuit to prevent nil-pointer panic if this function is called twice (or incorrectly)
-	onionEventBus := app.eventBuses[onion]
-	onionPeer := app.peers[onion]
-	if onionEventBus == nil || onionPeer == nil {
-		log.Errorf("shutdownPeer called with invalid onion %v", onion)
-		return
-	}
-	// we are an internal locked method, app.eventBuses[onion] cannot fail...
-	onionEventBus.Publish(event.NewEventList(event.ShutdownPeer, event.Identity, onion))
-	onionEventBus.Shutdown()
-
+	app.eventBuses[onion].Publish(event.NewEventList(event.ShutdownPeer, event.Identity, onion))
+	app.eventBuses[onion].Shutdown()
 	delete(app.eventBuses, onion)
-	onionPeer.Shutdown()
+	app.peers[onion].Shutdown()
 	delete(app.peers, onion)
-	if onionEngine, ok := app.engines[onion]; ok {
-		onionEngine.Shutdown()
+	if _, ok := app.engines[onion]; ok {
+		app.engines[onion].Shutdown()
 		delete(app.engines, onion)
 	}
 	log.Debugf("shutting down plugins for %v", onion)
 	pluginsI, ok := app.plugins.Load(onion)
 	if ok {
-		appPlugins := pluginsI.([]plugins.Plugin)
-		for _, plugin := range appPlugins {
+		plugins := pluginsI.([]plugins.Plugin)
+		for _, plugin := range plugins {
 			plugin.Shutdown()
 		}
 	}
@@ -593,7 +393,6 @@ func (app *application) Shutdown() {
 		app.shutdownPeer(id)
 	}
 	log.Debugf("Shutting Down App")
-	app.eventQueue.Shutdown()
 	app.appBus.Shutdown()
 	log.Debugf("Shut Down Complete")
 }

app/app_constants.go

@@ -1,6 +0,0 @@
-package app
-
-// DefactoPasswordForUnencryptedProfiles is used to offer "un-passworded" profiles. Our storage encrypts everything with a password. We need an agreed upon
-// password to use in that case, that the app case use behind the scenes to password and unlock with
-// https://docs.openprivacy.ca/cwtch-security-handbook/profile_encryption_and_storage.html
-const DefactoPasswordForUnencryptedProfiles = "be gay do crime"

app/plugins/antispam.go

@@ -18,16 +18,16 @@ func (a *antispam) Start() {
 	go a.run()
 }
 
-func (a *antispam) Id() PluginID {
+func (cr *antispam) Id() PluginID {
 	return ANTISPAM
 }
 
-func (a *antispam) Shutdown() {
+func (a antispam) Shutdown() {
 	a.breakChan <- true
 }
 
 func (a *antispam) run() {
-	log.Debugf("running antispam trigger plugin")
+	log.Infof("running antispam trigger plugin")
 	for {
 		select {
 		case <-time.After(antispamTickTime):

app/plugins/contactRetry.go

@@ -3,10 +3,8 @@ package plugins
 import (
 	"cwtch.im/cwtch/event"
 	"cwtch.im/cwtch/protocol/connections"
-	"git.openprivacy.ca/openprivacy/connectivity/tor"
 	"git.openprivacy.ca/openprivacy/log"
 	"math"
-	"strconv"
 	"sync"
 	"time"
 )
@@ -17,7 +15,7 @@ import (
 const tickTimeSec = 30
 const tickTime = tickTimeSec * time.Second
 
-const circuitTimeoutSecs int = 120
+const circutTimeoutSecs int = 120
 
 const MaxBaseTimeoutSec = 5 * 60 // a max base time out of 5 min
 const maxFailedBackoff = 6       // 2^6 = 64 -> 64 * [2m to 5m] = 2h8m to 5h20m
@@ -105,10 +103,6 @@ func (cq *connectionQueue) dequeue() *contact {
 	return c
 }
 
-func (cq *connectionQueue) len() int {
-	return len(cq.queue)
-}
-
 type contactRetry struct {
 	bus            event.Manager
 	queue          event.Queue
@@ -119,18 +113,16 @@ type contactRetry struct {
 	breakChan      chan bool
 	onion          string
 	lastCheck      time.Time
-	acnProgress    int
 
-	connections     sync.Map //[string]*contact
-	pendingQueue    *connectionQueue
-	priorityQueue   *connectionQueue
-	authorizedPeers sync.Map
-	stallRetries    bool
+	connections   sync.Map //[string]*contact
+	connCount     int
+	pendingQueue  *connectionQueue
+	priorityQueue *connectionQueue
 }
 
 // NewConnectionRetry returns a Plugin that when started will retry connecting to contacts with a failedCount timing
 func NewConnectionRetry(bus event.Manager, onion string) Plugin {
-	cr := &contactRetry{bus: bus, queue: event.NewQueue(), breakChan: make(chan bool, 1), authorizedPeers: sync.Map{}, connections: sync.Map{}, stallRetries: true, ACNUp: false, ACNUpTime: time.Now(), protocolEngine: false, onion: onion, pendingQueue: newConnectionQueue(), priorityQueue: newConnectionQueue()}
+	cr := &contactRetry{bus: bus, queue: event.NewQueue(), breakChan: make(chan bool, 1), connections: sync.Map{}, connCount: 0, ACNUp: false, ACNUpTime: time.Now(), protocolEngine: false, onion: onion, pendingQueue: newConnectionQueue(), priorityQueue: newConnectionQueue()}
 	return cr
 }
 
@@ -176,23 +168,17 @@ func (cr *contactRetry) run() {
 	cr.bus.Subscribe(event.PeerStateChange, cr.queue)
 	cr.bus.Subscribe(event.ACNStatus, cr.queue)
 	cr.bus.Subscribe(event.ServerStateChange, cr.queue)
+	cr.bus.Subscribe(event.PeerRequest, cr.queue)
 	cr.bus.Subscribe(event.QueuePeerRequest, cr.queue)
 	cr.bus.Subscribe(event.QueueJoinServer, cr.queue)
-	cr.bus.Subscribe(event.DisconnectPeerRequest, cr.queue)
-	cr.bus.Subscribe(event.DisconnectServerRequest, cr.queue)
 	cr.bus.Subscribe(event.ProtocolEngineShutdown, cr.queue)
 	cr.bus.Subscribe(event.ProtocolEngineCreated, cr.queue)
-	cr.bus.Subscribe(event.DeleteContact, cr.queue)
-	cr.bus.Subscribe(event.UpdateConversationAuthorization, cr.queue)
-	cr.bus.Subscribe(event.PurgeRetries, cr.queue)
-	cr.bus.Subscribe(event.ResumeRetries, cr.queue)
+
 	for {
-		// Only attempt connection if both the ACN and the Protocol Engines are Online...
-		log.Debugf("restartFlow checking state")
-		if cr.ACNUp && cr.protocolEngine && !cr.stallRetries {
-			log.Debugf("restartFlow time to queue!!")
+		if cr.ACNUp {
 			cr.requeueReady()
 			connectingCount := cr.connectingCount()
+			log.Debugf("checking queues (priority len: %v) (pending len: %v) of total conns watched: %v, with current connecingCount: %v", len(cr.priorityQueue.queue), len(cr.pendingQueue.queue), cr.connCount, connectingCount)
 
 			// do priority connections first...
 			for connectingCount < cr.maxTorCircuitsPending() && len(cr.priorityQueue.queue) > 0 {
@@ -220,67 +206,20 @@ func (cr *contactRetry) run() {
 			}
 			cr.lastCheck = time.Now()
 		}
-		// regardless of if we're up, run manual force deconnectiong of timed out connections
-		cr.connections.Range(func(k, v interface{}) bool {
-			p := v.(*contact)
-			if p.state == connections.CONNECTING && time.Since(p.lastAttempt) > time.Duration(circuitTimeoutSecs)*time.Second*2 {
-				// we have been "connecting" for twice the circuttimeout so it's failed, we just didn't learn about it, manually disconnect
-				cr.handleEvent(p.id, connections.DISCONNECTED, p.ctype)
-				log.Errorf("had to manually set peer %v of profile %v to DISCONNECTED due to assumed circuit timeout (%v) seconds", p.id, cr.onion, circuitTimeoutSecs*2)
-			}
-			return true
-		})
 
 		select {
 		case e := <-cr.queue.OutChan():
 			switch e.EventType {
-			case event.PurgeRetries:
-				// Purge All Authorized Peers
-				cr.authorizedPeers.Range(func(key interface{}, value interface{}) bool {
-					cr.authorizedPeers.Delete(key)
-					return true
-				})
-				// Purge All Connection States
-				cr.connections.Range(func(key interface{}, value interface{}) bool {
-					cr.connections.Delete(key)
-					return true
-				})
-			case event.ResumeRetries:
-				log.Infof("resuming retries...")
-				cr.stallRetries = false
-			case event.DisconnectPeerRequest:
-				peer := e.Data[event.RemotePeer]
-				cr.authorizedPeers.Delete(peer)
-			case event.DisconnectServerRequest:
-				peer := e.Data[event.GroupServer]
-				cr.authorizedPeers.Delete(peer)
-			case event.DeleteContact:
-				// this case covers both servers and peers (servers are peers, and go through the
-				// same delete conversation flow)
-				peer := e.Data[event.RemotePeer]
-				cr.authorizedPeers.Delete(peer)
-			case event.UpdateConversationAuthorization:
-				// if we update the conversation authorization then we need to check if
-				// we need to remove blocked conversations from the regular flow.
-				peer := e.Data[event.RemotePeer]
-				blocked := e.Data[event.Blocked]
-				if blocked == "true" {
-					cr.authorizedPeers.Delete(peer)
-				}
 			case event.PeerStateChange:
 				state := connections.ConnectionStateToType()[e.Data[event.ConnectionState]]
 				peer := e.Data[event.RemotePeer]
-				// only handle state change events from pre-authorized peers;
-				if _, exists := cr.authorizedPeers.Load(peer); exists {
-					cr.handleEvent(peer, state, peerConn)
-				}
+				cr.handleEvent(peer, state, peerConn)
+
 			case event.ServerStateChange:
 				state := connections.ConnectionStateToType()[e.Data[event.ConnectionState]]
 				server := e.Data[event.GroupServer]
-				// only handle state change events from pre-authorized servers;
-				if _, exists := cr.authorizedPeers.Load(server); exists {
-					cr.handleEvent(server, state, serverConn)
-				}
+				cr.handleEvent(server, state, serverConn)
+
 			case event.QueueJoinServer:
 				fallthrough
 			case event.QueuePeerRequest:
@@ -297,12 +236,11 @@ func (cr *contactRetry) run() {
 					id = server
 					cr.addConnection(server, connections.DISCONNECTED, serverConn, lastSeen)
 				}
-				// this was an authorized event, and so we store this peer.
-				log.Debugf("authorizing id: %v", id)
-				cr.authorizedPeers.Store(id, true)
+
 				if c, ok := cr.connections.Load(id); ok {
 					contact := c.(*contact)
-					if contact.state == connections.DISCONNECTED {
+					if contact.state == connections.DISCONNECTED && !contact.queued {
+
 						// prioritize connections made in the last week
 						if time.Since(contact.lastSeen).Hours() < PriorityQueueTimeSinceQualifierHours {
 							cr.priorityQueue.insert(contact)
@@ -311,11 +249,13 @@ func (cr *contactRetry) run() {
 						}
 					}
 				}
+			case event.ProtocolEngineCreated:
+				cr.protocolEngine = true
 
 			case event.ProtocolEngineShutdown:
 				cr.ACNUp = false
 				cr.protocolEngine = false
-				cr.stallRetries = true
+
 				cr.connections.Range(func(k, v interface{}) bool {
 					p := v.(*contact)
 					if p.state == connections.AUTHENTICATED || p.state == connections.SYNCED {
@@ -325,15 +265,22 @@ func (cr *contactRetry) run() {
 					p.failedCount = 0
 					return true
 				})
-			case event.ProtocolEngineCreated:
-				cr.protocolEngine = true
-				cr.processStatus()
 
 			case event.ACNStatus:
-				progData := e.Data[event.Progress]
-				if prog, err := strconv.Atoi(progData); err == nil {
-					cr.acnProgress = prog
-					cr.processStatus()
+				prog := e.Data[event.Progress]
+				if !cr.protocolEngine {
+					continue
+				}
+				if prog == "100" && !cr.ACNUp {
+					cr.ACNUp = true
+					cr.ACNUpTime = time.Now()
+					cr.connections.Range(func(k, v interface{}) bool {
+						p := v.(*contact)
+						p.failedCount = 0
+						return true
+					})
+				} else if prog != "100" {
+					cr.ACNUp = false
 				}
 			}
 
@@ -347,83 +294,27 @@ func (cr *contactRetry) run() {
 	}
 }
 
-func (cr *contactRetry) processStatus() {
-	if !cr.protocolEngine {
-		cr.ACNUp = false
-		return
-	}
-	if cr.acnProgress == 100 && !cr.ACNUp {
-		// ACN is up...at this point we need to completely reset our state
-		// as there is no guarantee that the tor daemon shares our state anymore...
-		cr.ACNUp = true
-		cr.ACNUpTime = time.Now()
-
-		// reset all of the queues...
-		cr.priorityQueue = newConnectionQueue()
-		cr.pendingQueue = newConnectionQueue()
-
-		// Loop through connections. Reset state, and requeue...
-		cr.connections.Range(func(k, v interface{}) bool {
-			p := v.(*contact)
-
-			// only reload connections if they are on the authorized peers list
-			if _, exists := cr.authorizedPeers.Load(p.id); exists {
-				p.queued = true
-				// prioritize connections made recently...
-				log.Debugf("adding %v to queue", p.id)
-				if time.Since(p.lastSeen).Hours() < PriorityQueueTimeSinceQualifierHours {
-					cr.priorityQueue.insert(p)
-				} else {
-					cr.pendingQueue.insert(p)
-				}
-			}
-
-			return true
-		})
-
-	} else if cr.acnProgress != 100 {
-		cr.ACNUp = false
-		cr.connections.Range(func(k, v interface{}) bool {
-			p := v.(*contact)
-			p.failedCount = 0
-			p.queued = false
-			p.state = connections.DISCONNECTED
-			return true
-		})
-	}
-}
-
 func (cr *contactRetry) requeueReady() {
 	if !cr.ACNUp {
 		return
 	}
 
-	var retryable []*contact
+	retryable := []*contact{}
 
-	throughPutPerMin := int((float64(cr.maxTorCircuitsPending()) / float64(circuitTimeoutSecs)) * 60.0)
-	queueCount := cr.priorityQueue.len() + cr.pendingQueue.len()
-	// adjustedBaseTimeout = basetimeoust * (queuedItemsCount / throughPutPerMin)
-	//   when less items are queued than through put it'll lower adjustedBaseTimeOut, but that'll be reset in the next block
-	//   when more items are queued it will increase the timeout, to a max of MaxBaseTimeoutSec (enforced in the next block)
-	adjustedBaseTimeout := circuitTimeoutSecs * (queueCount / throughPutPerMin)
-
-	// circuitTimeoutSecs (120s) < adjustedBaseTimeout < MaxBaseTimeoutSec (300s)
-	if adjustedBaseTimeout < circuitTimeoutSecs {
-		adjustedBaseTimeout = circuitTimeoutSecs
+	throughPutPerMin := cr.maxTorCircuitsPending() / (circutTimeoutSecs / 60)
+	adjustedBaseTimeout := cr.connCount / throughPutPerMin * 60
+	if adjustedBaseTimeout < circutTimeoutSecs {
+		adjustedBaseTimeout = circutTimeoutSecs
 	} else if adjustedBaseTimeout > MaxBaseTimeoutSec {
 		adjustedBaseTimeout = MaxBaseTimeoutSec
 	}
 
 	cr.connections.Range(func(k, v interface{}) bool {
 		p := v.(*contact)
-
-		// Don't retry anyone who isn't on the authorized peers list
-		if _, exists := cr.authorizedPeers.Load(p.id); exists {
-			if p.state == connections.DISCONNECTED && !p.queued {
-				timeout := time.Duration((math.Pow(2, float64(p.failedCount)))*float64(adjustedBaseTimeout /*baseTimeoutSec*/)) * time.Second
-				if time.Since(p.lastAttempt) > timeout {
-					retryable = append(retryable, p)
-				}
+		if p.state == connections.DISCONNECTED && !p.queued {
+			timeout := time.Duration((math.Pow(2, float64(p.failedCount)))*float64(adjustedBaseTimeout /*baseTimeoutSec*/)) * time.Second
+			if time.Since(p.lastAttempt) > timeout {
+				retryable = append(retryable, p)
 			}
 		}
 		return true
@@ -438,9 +329,8 @@ func (cr *contactRetry) requeueReady() {
 }
 
 func (cr *contactRetry) publishConnectionRequest(contact *contact) {
-	log.Debugf("RestartFlow Publish Connection Request listener %v", contact)
 	if contact.ctype == peerConn {
-		cr.bus.Publish(event.NewEvent(event.PeerRequest, map[event.Field]string{event.RemotePeer: contact.id}))
+		cr.bus.Publish(event.NewEvent(event.RetryPeerRequest, map[event.Field]string{event.RemotePeer: contact.id}))
 	}
 	if contact.ctype == serverConn {
 		cr.bus.Publish(event.NewEvent(event.RetryServerRequest, map[event.Field]string{event.GroupServer: contact.id}))
@@ -458,13 +348,8 @@ func (cr *contactRetry) addConnection(id string, state connections.ConnectionSta
 	if _, exists := cr.connections.Load(id); !exists {
 		p := &contact{id: id, state: state, failedCount: 0, lastAttempt: event.CwtchEpoch, ctype: ctype, lastSeen: lastSeen, queued: false}
 		cr.connections.Store(id, p)
+		cr.connCount += 1
 		return
-	} else {
-		// we have rerequested this connnection, probably via an explicit ask, update it's state
-		if c, ok := cr.connections.Load(id); ok {
-			contact := c.(*contact)
-			contact.state = state
-		}
 	}
 }
 
@@ -476,17 +361,8 @@ func (cr *contactRetry) handleEvent(id string, state connections.ConnectionState
 		return
 	}
 
-	// reject events that contain invalid hostnames...we cannot connect to them
-	// and they could result in spurious connection attempts...
-	if !tor.IsValidHostname(id) {
-		return
-	}
-
 	if _, exists := cr.connections.Load(id); !exists {
-		// We have an event for something we don't know about...
-		// The only reason this should happen is if a *new* Peer/Server connection has changed.
-		// Let's set the timeout to Now() to indicate that this is a fresh connection, and so should likely be prioritized.
-		cr.addConnection(id, state, ctype, time.Now())
+		cr.addConnection(id, state, ctype, event.CwtchEpoch)
 		return
 	}
 

app/plugins/contactRetry_test.go

@@ -1,128 +0,0 @@
-package plugins
-
-import (
-	"testing"
-	"time"
-
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/protocol/connections"
-	"git.openprivacy.ca/openprivacy/log"
-)
-
-// TestContactRetryQueue simulates some basic connection queueing
-// NOTE: This whole test is a race condition, and does flag go's detector
-// We are invasively checking the internal state of the retry plugin and accessing pointers from another
-// thread.
-// We could build an entire thread safe monitoring functonality, but that would dramatically expand the scope of this test.
-
-func TestContactRetryQueue(t *testing.T) {
-	log.SetLevel(log.LevelDebug)
-	bus := event.NewEventManager()
-	cr := NewConnectionRetry(bus, "").(*contactRetry)
-	cr.ACNUp = true          // fake an ACN connection...
-	cr.protocolEngine = true // fake protocol engine
-	cr.stallRetries = false  // fake not being in offline mode...
-	go cr.run()
-
-	testOnion := "2wgvbza2mbuc72a4u6r6k4hc2blcvrmk4q26bfvlwbqxv2yq5k52fcqd"
-
-	t.Logf("contact plugin up and running..sending peer connection...")
-	// Assert that there is a peer connection identified as "test"
-	bus.Publish(event.NewEvent(event.QueuePeerRequest, map[event.Field]string{event.RemotePeer: testOnion, event.LastSeen: "test"}))
-
-	// Wait until the test actually exists, and is queued
-	// This is the worst part of this test setup. Ideally we would sleep, or some other yielding, but
-	// go test scheduling doesn't like that and even sleeping long periods won't cause the event thread to make
-	// progress...
-	setup := false
-	for !setup {
-		if _, exists := cr.connections.Load(testOnion); exists {
-			if _, exists := cr.authorizedPeers.Load(testOnion); exists {
-				t.Logf("authorized")
-				setup = true
-			}
-		}
-	}
-
-	// We should very quickly become connecting...
-	time.Sleep(time.Second)
-	pinf, _ := cr.connections.Load(testOnion)
-	if pinf.(*contact).state != 1 {
-		t.Fatalf("test connection should be in connecting after update, actually: %v", pinf.(*contact).state)
-	}
-
-	// Asset that "test" is authenticated
-	cr.handleEvent(testOnion, connections.AUTHENTICATED, peerConn)
-
-	// Assert that "test has a valid state"
-	pinf, _ = cr.connections.Load(testOnion)
-	if pinf.(*contact).state != 3 {
-		t.Fatalf("test connection should be in authenticated after update, actually: %v", pinf.(*contact).state)
-	}
-
-	// Publish an unrelated event to trigger the Plugin to go through a queuing cycle
-	// If we didn't do this we would have to wait 30 seconds for a check-in
-	bus.Publish(event.NewEvent(event.PeerStateChange, map[event.Field]string{event.RemotePeer: "test2", event.ConnectionState: "Disconnected"}))
-	bus.Publish(event.NewEvent(event.QueuePeerRequest, map[event.Field]string{event.RemotePeer: testOnion, event.LastSeen: time.Now().Format(time.RFC3339Nano)}))
-
-	time.Sleep(time.Second)
-	pinf, _ = cr.connections.Load(testOnion)
-	if pinf.(*contact).state != 1 {
-		t.Fatalf("test connection should be in connecting after update, actually: %v", pinf.(*contact).state)
-	}
-
-	cr.Shutdown()
-}
-
-// Takes around 4 min unless you adjust the consts for tickTimeSec and circuitTimeoutSecs
-/*
-func TestRetryEmission(t *testing.T) {
-	log.SetLevel(log.LevelDebug)
-	log.Infof("*** Starting TestRetryEmission! ***")
-	bus := event.NewEventManager()
-
-	testQueue := event.NewQueue()
-	bus.Subscribe(event.PeerRequest, testQueue)
-
-	cr := NewConnectionRetry(bus, "").(*contactRetry)
-	cr.Start()
-	time.Sleep(100 * time.Millisecond)
-
-	bus.Publish(event.NewEventList(event.ACNStatus, event.Progress, "100"))
-	bus.Publish(event.NewEventList(event.ProtocolEngineCreated))
-
-	pub, _, _ := ed25519.GenerateKey(rand.Reader)
-	peerAddr := tor.GetTorV3Hostname(pub)
-
-	bus.Publish(event.NewEventList(event.QueuePeerRequest, event.RemotePeer, peerAddr, event.LastSeen, time.Now().Format(time.RFC3339Nano)))
-
-	log.Infof("Fetching 1st event")
-	ev := testQueue.Next()
-	if ev.EventType != event.PeerRequest {
-		t.Errorf("1st event emitted was %v, expected %v", ev.EventType, event.PeerRequest)
-	}
-	log.Infof("1st event: %v", ev)
-
-	bus.Publish(event.NewEventList(event.PeerStateChange, event.RemotePeer, peerAddr, event.ConnectionState, connections.ConnectionStateName[connections.DISCONNECTED]))
-
-	log.Infof("fetching 2nd event")
-	ev = testQueue.Next()
-	log.Infof("2nd event: %v", ev)
-	if ev.EventType != event.PeerRequest {
-		t.Errorf("2nd event emitted was %v, expected %v", ev.EventType, event.PeerRequest)
-	}
-
-	bus.Publish(event.NewEventList(event.PeerStateChange, event.RemotePeer, peerAddr, event.ConnectionState, connections.ConnectionStateName[connections.CONNECTED]))
-	time.Sleep(100 * time.Millisecond)
-	bus.Publish(event.NewEventList(event.PeerStateChange, event.RemotePeer, peerAddr, event.ConnectionState, connections.ConnectionStateName[connections.DISCONNECTED]))
-
-	log.Infof("fetching 3rd event")
-	ev = testQueue.Next()
-	log.Infof("3nd event: %v", ev)
-	if ev.EventType != event.PeerRequest {
-		t.Errorf("3nd event emitted was %v, expected %v", ev.EventType, event.PeerRequest)
-	}
-
-	cr.Shutdown()
-}
-*/

app/plugins/heartbeat.go

@@ -1,49 +0,0 @@
-package plugins
-
-import (
-	"cwtch.im/cwtch/event"
-	"git.openprivacy.ca/openprivacy/log"
-	"time"
-)
-
-const heartbeatTickTime = 60 * time.Second
-
-type heartbeat struct {
-	bus       event.Manager
-	queue     event.Queue
-	breakChan chan bool
-}
-
-func (hb *heartbeat) Start() {
-	go hb.run()
-}
-
-func (hb *heartbeat) Id() PluginID {
-	return HEARTBEAT
-}
-
-func (hb *heartbeat) Shutdown() {
-	hb.breakChan <- true
-	hb.queue.Shutdown()
-}
-
-func (hb *heartbeat) run() {
-	log.Debugf("running heartbeat trigger plugin")
-	for {
-		select {
-		case <-time.After(heartbeatTickTime):
-			// no fuss, just trigger the beat.
-			hb.bus.Publish(event.NewEvent(event.Heartbeat, map[event.Field]string{}))
-			continue
-		case <-hb.breakChan:
-			log.Debugf("shutting down heartbeat plugin")
-			return
-		}
-	}
-}
-
-// NewHeartbeat returns a Plugin that when started will trigger heartbeat checks on a regular interval
-func NewHeartbeat(bus event.Manager) Plugin {
-	cr := &heartbeat{bus: bus, queue: event.NewQueue(), breakChan: make(chan bool, 1)}
-	return cr
-}

app/plugins/networkCheck.go

@@ -40,7 +40,7 @@ func (nc *networkCheck) Start() {
 	go nc.run()
 }
 
-func (nc *networkCheck) Id() PluginID {
+func (cr *networkCheck) Id() PluginID {
 	return NETWORKCHECK
 }
 
@@ -126,8 +126,8 @@ func (nc *networkCheck) selfTest() {
 }
 
 func (nc *networkCheck) checkConnection(onion string) {
-	progress, _ := nc.acn.GetBootstrapStatus()
-	if progress != 100 {
+	prog, _ := nc.acn.GetBootstrapStatus()
+	if prog != 100 {
 		return
 	}
 
@@ -137,7 +137,7 @@ func (nc *networkCheck) checkConnection(onion string) {
 	err := ClientTimeout.ExecuteAction(func() error {
 		conn, _, err := nc.acn.Open(onion)
 		if err == nil {
-			_ = conn.Close()
+			conn.Close()
 		}
 		return err
 	})

app/plugins/plugin.go

@@ -14,7 +14,6 @@ const (
 	CONNECTIONRETRY PluginID = iota
 	NETWORKCHECK
 	ANTISPAM
-	HEARTBEAT
 )
 
 // Plugin is the interface for a plugin
@@ -33,8 +32,6 @@ func Get(id PluginID, bus event.Manager, acn connectivity.ACN, onion string) (Pl
 		return NewNetworkCheck(onion, bus, acn), nil
 	case ANTISPAM:
 		return NewAntiSpam(bus), nil
-	case HEARTBEAT:
-		return NewHeartbeat(bus), nil
 	}
 
 	return nil, fmt.Errorf("plugin not defined %v", id)

app/utils.go

@@ -15,9 +15,6 @@ func WaitGetPeer(app Application, name string) peer.CwtchPeer {
 	for {
 		for _, handle := range app.ListProfiles() {
 			peer := app.GetPeer(handle)
-			if peer == nil {
-				continue
-			}
 			localName, _ := peer.GetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name)
 			if localName == name {
 				return peer

event/common.go

@@ -25,14 +25,11 @@ const (
 	//		GroupServer
 	QueuePeerRequest = Type("QueuePeerRequest")
 
-	// Disconnect*Request
-	// Close active connections and prevent new connections
-	DisconnectPeerRequest   = Type("DisconnectPeerRequest")
-	DisconnectServerRequest = Type("DisconnectServerRequest")
-
-	// Events to Manage Retry Contacts
-	PurgeRetries  = Type("PurgeRetries")
-	ResumeRetries = Type("ResumeRetries")
+	// RetryPeerRequest
+	// Identical to PeerRequest, but allows Engine to make decisions regarding blocked peers
+	// attributes:
+	// RemotePeer: [eg "chpr7qm6op5vfcg2pi4vllco3h6aa7exexc4rqwnlupqhoogx2zgd6qd"
+	RetryPeerRequest = Type("RetryPeerRequest")
 
 	// RetryServerRequest
 	// Asks CwtchPeer to retry a server connection...
@@ -215,21 +212,13 @@ const (
 
 	// Profile Attribute Event
 	UpdatedProfileAttribute = Type("UpdatedProfileAttribute")
-	// Conversation Attribute Update...
-	UpdatedConversationAttribute = Type("UpdatedConversationAttribute")
-	StartingStorageMiragtion     = Type("StartingStorageMigration")
-	DoneStorageMigration         = Type("DoneStorageMigration")
+
+	StartingStorageMiragtion = Type("StartingStorageMigration")
+	DoneStorageMigration     = Type("DoneStorageMigration")
 
 	TokenManagerInfo     = Type("TokenManagerInfo")
 	TriggerAntispamCheck = Type("TriggerAntispamCheck")
 	MakeAntispamPayment  = Type("MakeAntispamPayment")
-
-	// Heartbeat is used to trigger actions that need to happen every so often...
-	Heartbeat = Type("Heartbeat")
-
-	// Conversation Search
-	SearchResult    = Type("SearchResult")
-	SearchCancelled = Type("SearchCancelled")
 )
 
 // Field defines common event attributes
@@ -239,8 +228,7 @@ type Field string
 const (
 
 	// A peers local onion address
-	Onion        = Field("Onion")
-	ProfileOnion = Field("ProfileOnion")
+	Onion = Field("Onion")
 
 	RemotePeer        = Field("RemotePeer")
 	LastSeen          = Field("LastSeen")
@@ -285,7 +273,6 @@ const (
 	EventID      = Field("EventID")
 	EventContext = Field("EventContext")
 	Index        = Field("Index")
-	RowIndex     = Field("RowIndex")
 	ContentHash  = Field("ContentHash")
 
 	// Handle denotes a contact handle of any type.
@@ -312,8 +299,6 @@ const (
 	FilePath             = Field("FilePath")
 	FileDownloadFinished = Field("FileDownloadFinished")
 	NameSuggestion       = Field("NameSuggestion")
-
-	SearchID = Field("SearchID")
 )
 
 // Defining Common errors
@@ -336,25 +321,19 @@ const (
 	ContextSendFile        = "im.cwtch.file.send.chunk"
 )
 
-// Define Attribute Keys related to history preservation
+// Define Default Attribute Keys
 const (
-	PreserveHistoryDefaultSettingKey = "SaveHistoryDefault" // profile level default
-	SaveHistoryKey                   = "SavePeerHistory"    // peer level setting
+	SaveHistoryKey = "SavePeerHistory"
 )
 
 // Define Default Attribute Values
 const (
-	// Save History has 3 distinct states. By default we refer to the profile level
-	//  attribute PreserveHistoryDefaultSettingKey ( default: false i.e. DefaultDeleteHistory),
-	// For each contact, if the profile owner confirms deletion we change to DeleteHistoryConfirmed,
-	// if the profile owner confirms they want to save history then this becomes SaveHistoryConfirmed
-	// These settings are set at the UI level using Get/SetScopeZoneAttribute with scoped zone: local.profile.*
+	// Save History has 3 distinct states. By default we don't save history (DefaultDeleteHistory), if the peer confirms this
+	// we change to DeleteHistoryConfirmed, if they confirm they want to save then this becomes SaveHistoryConfirmed
+	// We use this distinction between default and confirmed to drive UI
+	DeleteHistoryDefault   = "DefaultDeleteHistory"
 	SaveHistoryConfirmed   = "SaveHistory"
 	DeleteHistoryConfirmed = "DeleteHistoryConfirmed"
-
-	// NOTE: While this says "[DeleteHistory]Default", The actual behaviour will now depend on the
-	// global app/profile value of PreserveHistoryDefaultSettingKey
-	DeleteHistoryDefault = "DefaultDeleteHistory"
 )
 
 // Bool strings

event/eventQueue.go

@@ -35,7 +35,7 @@ func (iq *queue) OutChan() <-chan Event {
 	return iq.infChan.Out()
 }
 
-// Next returns the next available event from the front of the queue
+// Out returns the next available event from the front of the queue
 func (iq *queue) Next() Event {
 	event := <-iq.infChan.Out()
 	return event

event/eventmanager.go

@@ -22,7 +22,7 @@ type Event struct {
 }
 
 // GetRandNumber is a helper function which returns a random integer, this is
-// currently mostly used to generate message IDs
+// currently mostly used to generate messageids
 func GetRandNumber() *big.Int {
 	num, err := rand.Int(rand.Reader, big.NewInt(math.MaxUint32))
 	// If we can't generate random numbers then panicking is probably
@@ -46,8 +46,6 @@ func NewEventList(eventType Type, args ...interface{}) Event {
 		val, vok := args[i+1].(string)
 		if kok && vok {
 			data[key] = val
-		} else {
-			log.Errorf("attempted to send a field that could not be parsed to a string: %v %v", args[i], args[i+1])
 		}
 	}
 	return Event{EventType: eventType, EventID: GetRandNumber().String(), Data: data}
@@ -95,11 +93,6 @@ func (em *manager) initialize() {
 func (em *manager) Subscribe(eventType Type, queue Queue) {
 	em.mapMutex.Lock()
 	defer em.mapMutex.Unlock()
-	for _, sub := range em.subscribers[eventType] {
-		if sub == queue {
-			return // don't add the same queue for the same event twice...
-		}
-	}
 	em.subscribers[eventType] = append(em.subscribers[eventType], queue)
 }
 
@@ -136,7 +129,7 @@ func (em *manager) eventBus() {
 	for {
 		eventJSON := <-em.events
 
-		// In the case on an empty event. Tear down the Queue
+		// In the case on an empty event. Teardown the Queue
 		if len(eventJSON) == 0 {
 			log.Errorf("Received zero length event")
 			break
@@ -158,10 +151,7 @@ func (em *manager) eventBus() {
 		for _, subscriber := range subscribers {
 			// Deep Copy for Each Subscriber
 			var eventCopy Event
-			err = json.Unmarshal(eventJSON, &eventCopy)
-			if err != nil {
-				log.Errorf("error unmarshalling event: %v ", err)
-			}
+			json.Unmarshal(eventJSON, &eventCopy)
 			subscriber.Publish(eventCopy)
 		}
 	}

event/eventmanager_test.go

@@ -43,7 +43,7 @@ func TestEventManagerMultiple(t *testing.T) {
 	eventManager.Publish(Event{EventType: "GroupEvent", Data: map[Field]string{"Value": "Hello World Group"}})
 	eventManager.Publish(Event{EventType: "PeerEvent", Data: map[Field]string{"Value": "Hello World Peer"}})
 	eventManager.Publish(Event{EventType: "ErrorEvent", Data: map[Field]string{"Value": "Hello World Error"}})
-	eventManager.Publish(Event{EventType: "NobodyIsSubscribedToThisEvent", Data: map[Field]string{"Value": "No one should see this!"}})
+	eventManager.Publish(Event{EventType: "NobodyIsSubscribedToThisEvent", Data: map[Field]string{"Value": "Noone should see this!"}})
 
 	assertLength := func(len int, expected int, label string) {
 		if len != expected {

event/infinitechannel.go

@@ -1,4 +1,3 @@
-// nolint:nilaway - the infiniteBuffer function causes issues with static analysis because it is very unidomatic.
 package event
 
 /*
@@ -20,7 +19,7 @@ func newInfiniteChannel() *infiniteChannel {
 		input:  make(chan Event),
 		output: make(chan Event),
 		length: make(chan int),
-		buffer: newInfiniteQueue(),
+		buffer: newInfinitQueue(),
 	}
 	go ch.infiniteBuffer()
 	return ch

event/infinitequeue.go

@@ -24,7 +24,7 @@ type infiniteQueue struct {
 }
 
 // New constructs and returns a new Queue.
-func newInfiniteQueue() *infiniteQueue {
+func newInfinitQueue() *infiniteQueue {
 	return &infiniteQueue{
 		buf: make([]Event, minQueueLen),
 	}

extensions/profile_value.go

@@ -1,128 +0,0 @@
-package extensions
-
-import (
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/peer"
-	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
-	"git.openprivacy.ca/openprivacy/log"
-	"strconv"
-)
-
-// ProfileValueExtension implements custom Profile Names over Cwtch
-type ProfileValueExtension struct {
-}
-
-func (pne ProfileValueExtension) NotifySettingsUpdate(_ settings.GlobalSettings) {
-}
-
-func (pne ProfileValueExtension) EventsToRegister() []event.Type {
-	return []event.Type{event.PeerStateChange, event.Heartbeat}
-}
-
-func (pne ProfileValueExtension) ExperimentsToRegister() []string {
-	return nil
-}
-
-func (pne ProfileValueExtension) requestProfileInfo(profile peer.CwtchPeer, ci *model.Conversation) {
-	profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.Name)
-	profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.ProfileStatus)
-	profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.ProfileAttribute1)
-	profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.ProfileAttribute2)
-	profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.ProfileAttribute3)
-}
-
-func (pne ProfileValueExtension) OnEvent(ev event.Event, profile peer.CwtchPeer) {
-	switch ev.EventType {
-	case event.Heartbeat:
-		// once every heartbeat, loop through conversations and, if they are online, request an update to any long info..
-		conversations, err := profile.FetchConversations()
-		if err == nil {
-			for _, ci := range conversations {
-				if profile.GetPeerState(ci.Handle) == connections.AUTHENTICATED {
-					pne.requestProfileInfo(profile, ci)
-				}
-			}
-		}
-	case event.PeerStateChange:
-		ci, err := profile.FetchConversationInfo(ev.Data["RemotePeer"])
-		if err == nil {
-			// if we have re-authenticated with thie peer then request their profile image...
-			if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
-				// Request some profile information...
-				pne.requestProfileInfo(profile, ci)
-			}
-		}
-	}
-}
-
-// OnContactReceiveValue for ProfileValueExtension handles saving specific Public Profile Values like Profile Name
-func (pne ProfileValueExtension) OnContactReceiveValue(profile peer.CwtchPeer, conversation model.Conversation, szp attr.ScopedZonedPath, value string, exists bool) {
-	// Allow public profile parameters to be added as contact specific attributes...
-	scope, zone, _ := szp.GetScopeZonePath()
-	if exists && scope.IsPublic() && zone == attr.ProfileZone {
-
-		// Check the current value of the attribute
-		currentValue, err := profile.GetConversationAttribute(conversation.ID, szp)
-		if err == nil && currentValue == value {
-			// Value exists and the value is the same, short-circuit
-			return
-		}
-
-		// Save the new Attribute
-		err = profile.SetConversationAttribute(conversation.ID, szp, value)
-		if err != nil {
-			// Something else wen't wrong.. short-circuit
-			log.Errorf("error setting conversation attribute %v", err)
-			return
-		}
-
-		// Finally publish an update for listeners to react to.
-		scope, zone, zpath := szp.GetScopeZonePath()
-		profile.PublishEvent(event.NewEvent(event.UpdatedConversationAttribute, map[event.Field]string{
-			event.Scope:          string(scope),
-			event.Path:           string(zone.ConstructZonedPath(zpath)),
-			event.Data:           value,
-			event.RemotePeer:     conversation.Handle,
-			event.ConversationID: strconv.Itoa(conversation.ID),
-		}))
-	}
-}
-
-// OnContactRequestValue for ProfileValueExtension handles returning Public Profile Values
-func (pne ProfileValueExtension) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, szp attr.ScopedZonedPath) {
-	scope, zone, zpath := szp.GetScopeZonePath()
-	log.Debugf("Looking up public | conversation scope/zone %v", szp.ToString())
-	if scope.IsPublic() || scope.IsConversation() {
-		val, exists := profile.GetScopedZonedAttribute(scope, zone, zpath)
-
-		// NOTE: Temporary Override because UI currently wipes names if it can't find them...
-		if !exists && zone == attr.UnknownZone && zpath == constants.Name {
-			val, exists = profile.GetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name)
-		}
-
-		// NOTE: Cwtch 1.15+ requires that profiles be able to restrict file downloading to specific contacts. As such we need an ACL check here
-		// on the fileshareing zone.
-		// TODO: Split this functionality into FilesharingFunctionality, and restrict this function to only considering Profile zoned attributes?
-		if zone == attr.FilesharingZone {
-			if !conversation.GetPeerAC().ShareFiles {
-				return
-			}
-		}
-
-		// Construct a Response
-		resp := event.NewEvent(event.SendRetValMessageToPeer, map[event.Field]string{event.ConversationID: strconv.Itoa(conversation.ID), event.RemotePeer: conversation.Handle, event.Exists: strconv.FormatBool(exists)})
-		resp.EventID = eventID
-		if exists {
-			resp.Data[event.Data] = val
-		} else {
-			resp.Data[event.Data] = ""
-		}
-
-		log.Debugf("Responding with SendRetValMessageToPeer exists:%v data: %v\n", exists, val)
-		profile.PublishEvent(resp)
-	}
-}

extensions/send_when_online.go

@@ -1,66 +0,0 @@
-package extensions
-
-import (
-	"strconv"
-
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/peer"
-	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
-	"git.openprivacy.ca/openprivacy/log"
-)
-
-// SendWhenOnlineExtension implements automatic sending
-// Some Considerations:
-//   - There are race conditions inherant in this approach e.g. a peer could go offline just after recieving a message and never sending an ack
-//   - In that case the next time we connect we will send a duplicate message.
-//   - Currently we do not include metadata like sent time in raw peer protocols (however Overlay does now have support for that information)
-type SendWhenOnlineExtension struct {
-}
-
-func (soe SendWhenOnlineExtension) NotifySettingsUpdate(_ settings.GlobalSettings) {
-}
-
-func (soe SendWhenOnlineExtension) EventsToRegister() []event.Type {
-	return []event.Type{event.PeerStateChange}
-}
-
-func (soe SendWhenOnlineExtension) ExperimentsToRegister() []string {
-	return nil
-}
-
-func (soe SendWhenOnlineExtension) OnEvent(ev event.Event, profile peer.CwtchPeer) {
-	switch ev.EventType {
-	case event.PeerStateChange:
-		ci, err := profile.FetchConversationInfo(ev.Data["RemotePeer"])
-		if err == nil {
-			// if we have re-authenticated with thie peer then request their profile image...
-			if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
-				// Check the last 100 messages, if any of them are pending, then send them now...
-				messsages, _ := profile.GetMostRecentMessages(ci.ID, 0, 0, uint(100))
-				for _, message := range messsages {
-					if message.Attr[constants.AttrAck] == constants.False {
-						body := message.Body
-						ev := event.NewEvent(event.SendMessageToPeer, map[event.Field]string{event.ConversationID: strconv.Itoa(ci.ID), event.RemotePeer: ci.Handle, event.Data: body})
-						ev.EventID = message.Signature // we need this ensure that we correctly ack this in the db when it comes back
-						// TODO: The EventBus is becoming very noisy...we may want to consider a one-way shortcut to Engine i.e. profile.Engine.SendMessageToPeer
-						log.Debugf("resending message that was sent when peer was offline")
-						profile.PublishEvent(ev)
-					}
-				}
-			}
-		}
-	}
-}
-
-// OnContactReceiveValue is nop for SendWhenOnnlineExtension
-func (soe SendWhenOnlineExtension) OnContactReceiveValue(profile peer.CwtchPeer, conversation model.Conversation, szp attr.ScopedZonedPath, value string, exists bool) {
-}
-
-// OnContactRequestValue is nop for SendWhenOnnlineExtension
-func (soe SendWhenOnlineExtension) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, szp attr.ScopedZonedPath) {
-
-}

functionality/filesharing/filesharing_functionality.go

@@ -2,8 +2,6 @@ package filesharing
 
 import (
 	"crypto/rand"
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/settings"
 	"encoding/hex"
 	"encoding/json"
 	"errors"
@@ -30,121 +28,13 @@ import (
 type Functionality struct {
 }
 
-func (f *Functionality) NotifySettingsUpdate(settings settings.GlobalSettings) {
-}
-
-func (f *Functionality) EventsToRegister() []event.Type {
-	return []event.Type{event.ProtocolEngineCreated, event.ManifestReceived, event.FileDownloaded}
-}
-
-func (f *Functionality) ExperimentsToRegister() []string {
-	return []string{constants.FileSharingExperiment}
-}
-
-// OnEvent handles File Sharing Hooks like Manifest Received and FileDownloaded
-func (f *Functionality) OnEvent(ev event.Event, profile peer.CwtchPeer) {
-	if profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		switch ev.EventType {
-		case event.ProtocolEngineCreated:
-			f.ReShareFiles(profile)
-		case event.ManifestReceived:
-			log.Debugf("Manifest Received Event!: %v", ev)
-			handle := ev.Data[event.Handle]
-			fileKey := ev.Data[event.FileKey]
-			serializedManifest := ev.Data[event.SerializedManifest]
-
-			manifestFilePath, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%v.manifest", fileKey))
-			if exists {
-				downloadFilePath, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%v.path", fileKey))
-				if exists {
-					log.Debugf("downloading manifest to %v, file to %v", manifestFilePath, downloadFilePath)
-					var manifest files.Manifest
-					err := json.Unmarshal([]byte(serializedManifest), &manifest)
-
-					if err == nil {
-						// We only need to check the file size here, as manifest is sent to engine and the file created
-						// will be bound to the size advertised in manifest.
-						fileSizeLimitValue, fileSizeLimitExists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%v.limit", fileKey))
-						if fileSizeLimitExists {
-							fileSizeLimit, err := strconv.ParseUint(fileSizeLimitValue, 10, 64)
-							if err == nil {
-								if manifest.FileSizeInBytes >= fileSizeLimit {
-									log.Debugf("could not download file, size %v greater than limit %v", manifest.FileSizeInBytes, fileSizeLimitValue)
-								} else {
-									manifest.Title = manifest.FileName
-									manifest.FileName = downloadFilePath
-									log.Debugf("saving manifest")
-									err = manifest.Save(manifestFilePath)
-									if err != nil {
-										log.Errorf("could not save manifest: %v", err)
-									} else {
-										tempFile := ""
-										if runtime.GOOS == "android" {
-											tempFile = manifestFilePath[0 : len(manifestFilePath)-len(".manifest")]
-											log.Debugf("derived android temp path: %v", tempFile)
-										}
-										profile.PublishEvent(event.NewEvent(event.ManifestSaved, map[event.Field]string{
-											event.FileKey:            fileKey,
-											event.Handle:             handle,
-											event.SerializedManifest: string(manifest.Serialize()),
-											event.TempFile:           tempFile,
-											event.NameSuggestion:     manifest.Title,
-										}))
-									}
-								}
-							} else {
-								log.Errorf("error saving manifest: file size limit is incorrect: %v", err)
-							}
-						} else {
-							log.Errorf("error saving manifest: could not find file size limit info")
-						}
-					} else {
-						log.Errorf("error saving manifest: %v", err)
-					}
-				} else {
-					log.Errorf("found manifest path but not download path for %v", fileKey)
-				}
-			} else {
-				log.Errorf("no download path found for manifest: %v", fileKey)
-			}
-		case event.FileDownloaded:
-			fileKey := ev.Data[event.FileKey]
-			profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.complete", fileKey), "true")
-		}
-	} else {
-		log.Errorf("profile called filesharing experiment OnContactReceiveValue even though file sharing was not enabled. This is likely a programming error.")
+// FunctionalityGate returns filesharing if enabled in the given experiment map
+// Note: Experiment maps are currently in libcwtch-go
+func FunctionalityGate(experimentMap map[string]bool) (*Functionality, error) {
+	if experimentMap[constants.FileSharingExperiment] {
+		return new(Functionality), nil
 	}
-}
-
-func (f *Functionality) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, path attr.ScopedZonedPath) {
-	// nop
-}
-
-func (f *Functionality) OnContactReceiveValue(profile peer.CwtchPeer, conversation model.Conversation, path attr.ScopedZonedPath, value string, exists bool) {
-	// Profile should not call us if FileSharing is disabled
-	if profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		scope, zone, zpath := path.GetScopeZonePath()
-		log.Debugf("file sharing contact receive value")
-		if exists && scope.IsConversation() && zone == attr.FilesharingZone && strings.HasSuffix(zpath, ".manifest.size") {
-			fileKey := strings.Replace(zpath, ".manifest.size", "", 1)
-			size, err := strconv.Atoi(value)
-			// if size is valid and below the maximum size for a manifest
-			// this is to prevent malicious sharers from using large amounts of memory when distributing
-			// a manifest as we reconstruct this in-memory
-			if err == nil && size < files.MaxManifestSize {
-				profile.PublishEvent(event.NewEvent(event.ManifestSizeReceived, map[event.Field]string{event.FileKey: fileKey, event.ManifestSize: value, event.Handle: conversation.Handle}))
-			} else {
-				profile.PublishEvent(event.NewEvent(event.ManifestError, map[event.Field]string{event.FileKey: fileKey, event.Handle: conversation.Handle}))
-			}
-		}
-	} else {
-		log.Errorf("profile called filesharing experiment OnContactReceiveValue even though file sharing was not enabled. This is likely a programming error.")
-	}
-}
-
-// FunctionalityGate returns filesharing functionality - gates now happen on function calls.
-func FunctionalityGate() *Functionality {
-	return new(Functionality)
+	return nil, errors.New("filesharing is not enabled")
 }
 
 // PreviewFunctionalityGate returns filesharing if image previews are enabled
@@ -183,101 +73,18 @@ func (om *OverlayMessage) ShouldAutoDL() bool {
 	return false
 }
 
-func (f *Functionality) VerifyOrResumeDownloadDefaultLimit(profile peer.CwtchPeer, conversation int, fileKey string) error {
-	return f.VerifyOrResumeDownload(profile, conversation, fileKey, files.MaxManifestSize*files.DefaultChunkSize)
-}
-
-func (f *Functionality) VerifyOrResumeDownload(profile peer.CwtchPeer, conversation int, fileKey string, size uint64) error {
-	if manifestFilePath, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest", fileKey)); exists {
-		if downloadfilepath, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.path", fileKey)); exists {
-			manifest, err := files.LoadManifest(manifestFilePath)
-			if err == nil {
-				// Assert the filename...this is technically not necessary, but is here for completeness
-				manifest.FileName = downloadfilepath
-				if manifest.VerifyFile() == nil {
-					// Send a FileDownloaded Event. Usually when VerifyOrResumeDownload is triggered it's because some UI is awaiting the results of a
-					// Download.
-					profile.PublishEvent(event.NewEvent(event.FileDownloaded, map[event.Field]string{event.FileKey: fileKey, event.FilePath: downloadfilepath, event.TempFile: downloadfilepath}))
-					// File is verified and there is nothing else to do...
-					return nil
-				} else {
-					// Kick off another Download...
-					return f.DownloadFile(profile, conversation, downloadfilepath, manifestFilePath, fileKey, size)
-				}
-			}
-		}
-	}
-	return errors.New("file download metadata does not exist, or is corrupted")
-}
-
-func (f *Functionality) CheckDownloadStatus(profile peer.CwtchPeer, fileKey string) error {
-	path, _ := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.path", fileKey))
-	if value, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.complete", fileKey)); exists && value == event.True {
-		profile.PublishEvent(event.NewEvent(event.FileDownloaded, map[event.Field]string{
-			event.ProfileOnion: profile.GetOnion(),
-			event.FileKey:      fileKey,
-			event.FilePath:     path,
-			event.TempFile:     "",
-		}))
-	} else {
-		log.Debugf("CheckDownloadStatus found .path but not .complete")
-		profile.PublishEvent(event.NewEvent(event.FileDownloadProgressUpdate, map[event.Field]string{
-			event.ProfileOnion:     profile.GetOnion(),
-			event.FileKey:          fileKey,
-			event.Progress:         "-1",
-			event.FileSizeInChunks: "-1",
-			event.FilePath:         path,
-		}))
-	}
-	return nil // cannot fail
-}
-
-func (f *Functionality) EnhancedShareFile(profile peer.CwtchPeer, conversationID int, sharefilepath string) string {
-	fileKey, overlay, err := f.ShareFile(sharefilepath, profile)
-	if err != nil {
-		log.Errorf("error sharing file: %v", err)
-	} else if conversationID == -1 {
-		// FIXME: At some point we might want to allow arbitrary public files, but for now this API will assume
-		// there is only one, and it is the custom profile image...
-		profile.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey, fileKey)
-	} else {
-		// Set a new attribute so we can associate this download with this conversation...
-		profile.SetConversationAttribute(conversationID, attr.ConversationScope.ConstructScopedZonedPath(attr.FilesharingZone.ConstructZonedPath(fileKey)), "")
-		id, err := profile.SendMessage(conversationID, overlay)
-		if err == nil {
-			return profile.EnhancedGetMessageById(conversationID, id)
-		}
-	}
-	return ""
-}
-
-// DownloadFileDefaultLimit given a profile, a conversation handle and a file sharing key, start off a download process
-// to downloadFilePath with a default filesize limit
-func (f *Functionality) DownloadFileDefaultLimit(profile peer.CwtchPeer, conversationID int, downloadFilePath string, manifestFilePath string, key string) error {
-	return f.DownloadFile(profile, conversationID, downloadFilePath, manifestFilePath, key, files.MaxManifestSize*files.DefaultChunkSize)
-}
-
 // DownloadFile given a profile, a conversation handle and a file sharing key, start off a download process
 // to downloadFilePath
 func (f *Functionality) DownloadFile(profile peer.CwtchPeer, conversationID int, downloadFilePath string, manifestFilePath string, key string, limit uint64) error {
 
-	// assert that we are allowed to download the file
-	if !profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		return errors.New("filesharing functionality is not enabled")
-	}
-
 	// Don't download files if the download or manifest path is not set
 	if downloadFilePath == "" || manifestFilePath == "" {
 		return errors.New("download path or manifest path is empty")
 	}
 
-	// Don't download files if the download file directory does not exist
-	// Unless we are on Android where the kernel wishes to keep us ignorant of the
-	// actual path and/or existence of the file. We handle this case further down
-	// the line when the manifest is received and protocol engine and the Android layer
-	// negotiate a temporary local file -> final file copy. We don't want to worry
-	// about that here...
+	// We write to a temp file for Android...
 	if runtime.GOOS != "android" {
+		// Don't download files if the download file directory does not exist
 		if _, err := os.Stat(path.Dir(downloadFilePath)); os.IsNotExist(err) {
 			return errors.New("download directory does not exist")
 		}
@@ -302,48 +109,14 @@ func (f *Functionality) DownloadFile(profile peer.CwtchPeer, conversationID int,
 	return nil
 }
 
-// startFileShare is a private method used to finalize a file share and publish it to the protocol engine for processing.
-// if force is set to true, this function will ignore timestamp checks...
-func (f *Functionality) startFileShare(profile peer.CwtchPeer, filekey string, manifest string, force bool) error {
-	tsStr, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.ts", filekey))
-	if exists && !force {
-		ts, err := strconv.ParseInt(tsStr, 10, 64)
-		if err != nil || ts < time.Now().Unix()-2592000 {
-			log.Errorf("ignoring request to download a file offered more than 30 days ago")
-			return err
-		}
-	}
-
-	// set the filekey status to active
-	profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.active", filekey), constants.True)
-	// reset the timestamp...
-	profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.ts", filekey), strconv.FormatInt(time.Now().Unix(), 10))
-	// share the manifest
-	profile.PublishEvent(event.NewEvent(event.ShareManifest, map[event.Field]string{event.FileKey: filekey, event.SerializedManifest: manifest}))
-	return nil
-}
-
 // RestartFileShare takes in an existing filekey and, assuming the manifest exists, restarts sharing of the manifest
-// by default this function always forces a file share, even if the file has timed out.
 func (f *Functionality) RestartFileShare(profile peer.CwtchPeer, filekey string) error {
-	return f.restartFileShareAdvanced(profile, filekey, true)
-}
-
-// RestartFileShareAdvanced takes in an existing filekey and, assuming the manifest exists, restarts sharing of the manifest in addition
-// to a set of parameters
-func (f *Functionality) restartFileShareAdvanced(profile peer.CwtchPeer, filekey string, force bool) error {
-
-	// assert that we are allowed to restart filesharing
-	if !profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		return errors.New("filesharing functionality is not enabled")
-	}
-
 	// check that a manifest exists
 	manifest, manifestExists := profile.GetScopedZonedAttribute(attr.ConversationScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest", filekey))
 	if manifestExists {
 		// everything is in order, so reshare this file with the engine
-		log.Debugf("restarting file share: %v", filekey)
-		return f.startFileShare(profile, filekey, manifest, force)
+		profile.ShareFile(filekey, manifest)
+		return nil
 	}
 	return fmt.Errorf("manifest does not exist for filekey: %v", filekey)
 }
@@ -351,12 +124,6 @@ func (f *Functionality) restartFileShareAdvanced(profile peer.CwtchPeer, filekey
 // ReShareFiles given a profile we iterate through all existing fileshares and re-share them
 // if the time limit has not expired
 func (f *Functionality) ReShareFiles(profile peer.CwtchPeer) error {
-
-	// assert that we are allowed to restart filesharing
-	if !profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		return errors.New("filesharing functionality is not enabled")
-	}
-
 	keys, err := profile.GetScopedZonedAttributeKeys(attr.LocalScope, attr.FilesharingZone)
 	if err != nil {
 		return err
@@ -365,7 +132,6 @@ func (f *Functionality) ReShareFiles(profile peer.CwtchPeer) error {
 	for _, key := range keys {
 		// only look at timestamp keys
 		// this is an arbitrary choice
-
 		if strings.HasSuffix(key, ".ts") {
 			_, zonedpath := attr.ParseScope(key)
 			_, keypath := attr.ParseZone(zonedpath)
@@ -377,15 +143,12 @@ func (f *Functionality) ReShareFiles(profile peer.CwtchPeer) error {
 				filekey := strings.Join(keyparts[:2], ".")
 				sharedFile, err := f.GetFileShareInfo(profile, filekey)
 
-				// If we haven't explicitly stopped sharing the file then attempt a reshare
+				// If we haven't explicitly stopped sharing the file AND
+				// If fewer than 30 days have passed since we originally shared this file,
+				// Then attempt to share this file again...
+				// TODO: In the future this would be the point to change the timestamp and reshare the file...
 				if err == nil && sharedFile.Active {
-					// this reshare can fail because we don't force sharing of files older than 30 days...
-					err := f.restartFileShareAdvanced(profile, filekey, false)
-					if err != nil {
-						log.Debugf("could not reshare file: %v", err)
-					}
-				} else {
-					log.Debugf("could not get fileshare info %v", err)
+					f.RestartFileShare(profile, filekey)
 				}
 			}
 		}
@@ -421,12 +184,6 @@ func (f *Functionality) GetFileShareInfo(profile peer.CwtchPeer, filekey string)
 // ShareFile given a profile and a conversation handle, sets up a file sharing process to share the file
 // at filepath
 func (f *Functionality) ShareFile(filepath string, profile peer.CwtchPeer) (string, string, error) {
-
-	// assert that we are allowed to share files
-	if !profile.IsFeatureEnabled(constants.FileSharingExperiment) {
-		return "", "", errors.New("filesharing functionality is not enabled")
-	}
-
 	manifest, err := files.CreateManifest(filepath)
 	if err != nil {
 		return "", "", err
@@ -474,7 +231,7 @@ func (f *Functionality) ShareFile(filepath string, profile peer.CwtchPeer) (stri
 	profile.SetScopedZonedAttribute(attr.ConversationScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest", key), string(serializedManifest))
 	profile.SetScopedZonedAttribute(attr.ConversationScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest.size", key), strconv.Itoa(int(math.Ceil(float64(len(serializedManifest)-lenDiff)/float64(files.DefaultChunkSize)))))
 
-	err = f.startFileShare(profile, key, string(serializedManifest), false)
+	profile.ShareFile(key, string(serializedManifest))
 
 	return key, string(wrapperJSON), err
 }
@@ -501,17 +258,9 @@ type SharedFile struct {
 	Expired bool
 }
 
-func (f *Functionality) EnhancedGetSharedFiles(profile peer.CwtchPeer, conversationID int) string {
-	data, err := json.Marshal(f.GetSharedFiles(profile, conversationID))
-	if err == nil {
-		return string(data)
-	}
-	return ""
-}
-
 // GetSharedFiles returns all file shares associated with a given conversation
 func (f *Functionality) GetSharedFiles(profile peer.CwtchPeer, conversationID int) []SharedFile {
-	var sharedFiles []SharedFile
+	sharedFiles := []SharedFile{}
 	ci, err := profile.GetConversationInfo(conversationID)
 	if err == nil {
 		for k := range ci.Attributes {
@@ -574,18 +323,3 @@ func GenerateDownloadPath(basePath, fileName string, overwrite bool) (filePath,
 	}
 	return
 }
-
-// StopFileShare sends a message to the ProtocolEngine to cease sharing a particular file
-func (f *Functionality) StopFileShare(profile peer.CwtchPeer, fileKey string) error {
-	// Note we do not do a permissions check here, as we are *always* permitted to stop sharing files.
-	// set the filekey status to inactive
-	profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.active", fileKey), constants.False)
-	profile.PublishEvent(event.NewEvent(event.StopFileShare, map[event.Field]string{event.FileKey: fileKey}))
-	return nil // cannot fail
-}
-
-// StopAllFileShares sends a message to the ProtocolEngine to cease sharing all files
-func (f *Functionality) StopAllFileShares(profile peer.CwtchPeer) {
-	// Note we do not do a permissions check here, as we are *always* permitted to stop sharing files.
-	profile.PublishEvent(event.NewEvent(event.StopAllFileShares, map[event.Field]string{}))
-}

functionality/filesharing/image_previews.go

@@ -1,181 +0,0 @@
-package filesharing
-
-import (
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/peer"
-	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
-	"encoding/json"
-	"fmt"
-	"git.openprivacy.ca/openprivacy/log"
-	"os"
-	"strconv"
-	"time"
-)
-
-type ImagePreviewsFunctionality struct {
-	downloadFolder string
-}
-
-func (i *ImagePreviewsFunctionality) NotifySettingsUpdate(settings settings.GlobalSettings) {
-	i.downloadFolder = settings.DownloadPath
-}
-
-func (i *ImagePreviewsFunctionality) EventsToRegister() []event.Type {
-	return []event.Type{event.ProtocolEngineCreated, event.NewMessageFromPeer, event.NewMessageFromGroup, event.PeerStateChange, event.Heartbeat}
-}
-
-func (i *ImagePreviewsFunctionality) ExperimentsToRegister() []string {
-	return []string{constants.FileSharingExperiment, constants.ImagePreviewsExperiment}
-}
-
-func (i *ImagePreviewsFunctionality) OnEvent(ev event.Event, profile peer.CwtchPeer) {
-	if profile.IsFeatureEnabled(constants.FileSharingExperiment) && profile.IsFeatureEnabled(constants.ImagePreviewsExperiment) {
-		switch ev.EventType {
-		case event.NewMessageFromPeer:
-			ci, err := profile.FetchConversationInfo(ev.Data["RemotePeer"])
-			if err == nil {
-				if ci.GetPeerAC().RenderImages {
-					i.handleImagePreviews(profile, &ev, ci.ID, ci.ID)
-				}
-			}
-		case event.NewMessageFromGroup:
-			ci, err := profile.FetchConversationInfo(ev.Data["RemotePeer"])
-			if err == nil {
-				if ci.GetPeerAC().RenderImages {
-					i.handleImagePreviews(profile, &ev, ci.ID, ci.ID)
-				}
-			}
-		case event.PeerStateChange:
-			ci, err := profile.FetchConversationInfo(ev.Data["RemotePeer"])
-			if err == nil {
-				// if we have re-authenticated with this peer then request their profile image...
-				if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
-					profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey)
-				}
-			}
-		case event.Heartbeat:
-			conversations, err := profile.FetchConversations()
-			if err == nil {
-				for _, ci := range conversations {
-					if profile.GetPeerState(ci.Handle) == connections.AUTHENTICATED {
-						// if we have enabled file shares for this contact, then send them our profile image
-						// NOTE: In the past, Cwtch treated "profile image" as a public file share. As such, anyone with the file key and who is able
-						// to authenticate with the profile (i.e. non-blocked peers) can download the file (if the global profile images experiment is enabled)
-						// To better allow for fine-grained permissions (and to support hybrid group permissions), we want to enable per-conversation file
-						// sharing permissions. As such, profile images are now only shared with contacts with that permission enabled.
-						// (i.e. all previous accepted contacts, new accepted contacts, and contacts who have this toggle set explictly)
-						if ci.GetPeerAC().ShareFiles {
-							profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey)
-						}
-					}
-				}
-			}
-		case event.ProtocolEngineCreated:
-			// Now that the Peer Engine is Activated, Reshare Profile Images
-			key, exists := profile.GetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey)
-			if exists {
-				serializedManifest, _ := profile.GetScopedZonedAttribute(attr.ConversationScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest", key))
-				// reset the share timestamp, currently file shares are hardcoded to expire after 30 days...
-				// we reset the profile image here so that it is always available.
-				profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.ts", key), strconv.FormatInt(time.Now().Unix(), 10))
-				log.Debugf("Custom Profile Image: %v %s", key, serializedManifest)
-				f := Functionality{}
-				f.RestartFileShare(profile, key)
-			}
-		}
-	}
-}
-
-func (i *ImagePreviewsFunctionality) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, path attr.ScopedZonedPath) {
-}
-
-func (i *ImagePreviewsFunctionality) OnContactReceiveValue(profile peer.CwtchPeer, conversation model.Conversation, path attr.ScopedZonedPath, value string, exists bool) {
-	if profile.IsFeatureEnabled(constants.FileSharingExperiment) && profile.IsFeatureEnabled(constants.ImagePreviewsExperiment) {
-		_, zone, path := path.GetScopeZonePath()
-		if exists && zone == attr.ProfileZone && path == constants.CustomProfileImageKey {
-			// We only download from accepted conversations
-			if conversation.GetPeerAC().RenderImages {
-				fileKey := value
-				basepath := i.downloadFolder
-				fsf := FunctionalityGate()
-				// We always overwrite profile image files...
-				fp, mp := GenerateDownloadPath(basepath, fileKey, true)
-
-				// If we have marked this file as complete...
-				if value, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.complete", fileKey)); exists && value == event.True {
-					if _, err := os.Stat(fp); err == nil {
-						// file is marked as completed downloaded and exists...
-						// Note: this will also resend the FileDownloaded event if successful...
-						if fsf.VerifyOrResumeDownload(profile, conversation.ID, fileKey, constants.ImagePreviewMaxSizeInBytes) == nil {
-							return
-						}
-						// Otherwise we fall through...
-					}
-					// Something went wrong...the file is marked as complete but either doesn't exist, or is corrupted such that we can't continue...
-					// So mark complete as false...
-					profile.SetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.complete", fileKey), event.False)
-				}
-
-				// If we have reached this point then we need to download the file again...
-				log.Debugf("Downloading Profile Image %v %v %v", fp, mp, fileKey)
-				fsf.DownloadFile(profile, conversation.ID, fp, mp, fileKey, constants.ImagePreviewMaxSizeInBytes)
-			}
-		}
-	}
-}
-
-// handleImagePreviews checks settings and, if appropriate, auto-downloads any images
-func (i *ImagePreviewsFunctionality) handleImagePreviews(profile peer.CwtchPeer, ev *event.Event, conversationID, senderID int) {
-	if profile.IsFeatureEnabled(constants.FileSharingExperiment) && profile.IsFeatureEnabled(constants.ImagePreviewsExperiment) {
-		ci, err := profile.GetConversationInfo(senderID)
-		if err != nil {
-			log.Errorf("attempted to call handleImagePreviews with unknown conversation: %v", senderID)
-			return
-		}
-
-		if !ci.GetPeerAC().ShareFiles || !ci.GetPeerAC().RenderImages {
-			log.Infof("refusing to autodownload files from sender: %v. conversation AC does not permit image rendering", senderID)
-			return
-		}
-
-		// Short-circuit failures
-		// Don't auto-download images if the download path does not exist.
-		if i.downloadFolder == "" {
-			log.Errorf("download folder %v is not set", i.downloadFolder)
-			return
-		}
-
-		// Don't auto-download images if the download path does not exist.
-		if _, err := os.Stat(i.downloadFolder); os.IsNotExist(err) {
-			log.Errorf("download folder %v does not exist", i.downloadFolder)
-			return
-		}
-
-		// If file sharing is enabled then reshare all active files...
-		fsf := FunctionalityGate()
-
-		// Now look at the image preview experiment
-		var cm model.MessageWrapper
-		err = json.Unmarshal([]byte(ev.Data[event.Data]), &cm)
-		if err == nil && cm.Overlay == model.OverlayFileSharing {
-			log.Debugf("Received File Sharing Message")
-			var fm OverlayMessage
-			err = json.Unmarshal([]byte(cm.Data), &fm)
-			if err == nil {
-				if fm.ShouldAutoDL() {
-					basepath := i.downloadFolder
-					fp, mp := GenerateDownloadPath(basepath, fm.Name, false)
-					log.Debugf("autodownloading file! %v %v %v", basepath, fp, i.downloadFolder)
-					ev.Data["Auto"] = constants.True
-					mID, _ := strconv.Atoi(ev.Data["Index"])
-					profile.UpdateMessageAttribute(conversationID, 0, mID, constants.AttrDownloaded, constants.True)
-					fsf.DownloadFile(profile, senderID, fp, mp, fm.FileKey(), constants.ImagePreviewMaxSizeInBytes)
-				}
-			}
-		}
-	}
-}

functionality/servers/servers_functionality.go

@@ -1,150 +0,0 @@
-package servers
-
-import (
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/peer"
-	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
-	"encoding/json"
-	"errors"
-	"git.openprivacy.ca/openprivacy/log"
-)
-
-const (
-	// ServerList is a json encoded list of servers
-	ServerList = event.Field("ServerList")
-)
-
-const (
-	// UpdateServerInfo is an event containing a ProfileOnion and a ServerList
-	UpdateServerInfo = event.Type("UpdateServerInfo")
-)
-
-// Functionality groups some common UI triggered functions for contacts...
-type Functionality struct {
-}
-
-func (f *Functionality) NotifySettingsUpdate(settings settings.GlobalSettings) {
-
-}
-
-func (f *Functionality) EventsToRegister() []event.Type {
-	return []event.Type{event.QueueJoinServer}
-}
-
-func (f *Functionality) ExperimentsToRegister() []string {
-	return []string{constants.GroupsExperiment}
-}
-
-// OnEvent handles File Sharing Hooks like Manifest Received and FileDownloaded
-func (f *Functionality) OnEvent(ev event.Event, profile peer.CwtchPeer) {
-	if profile.IsFeatureEnabled(constants.GroupsExperiment) {
-		switch ev.EventType {
-		// keep the UI in sync with the current backend server updates...
-		// queue join server gets triggered on load and on new servers so it's a nice
-		// low-noise event to hook into...
-		case event.QueueJoinServer:
-			f.PublishServerUpdate(profile)
-		}
-	}
-}
-
-func (f *Functionality) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, path attr.ScopedZonedPath) {
-	// nop
-}
-
-func (f *Functionality) OnContactReceiveValue(profile peer.CwtchPeer, conversation model.Conversation, path attr.ScopedZonedPath, value string, exists bool) {
-	// nopt
-}
-
-// FunctionalityGate returns filesharing functionality - gates now happen on function calls.
-func FunctionalityGate() *Functionality {
-	return new(Functionality)
-}
-
-// ServerKey packages up key information...
-// TODO: Can this be merged with KeyBundle?
-type ServerKey struct {
-	Type string `json:"type"`
-	Key  string `json:"key"`
-}
-
-// SyncStatus packages up server sync information...
-type SyncStatus struct {
-	StartTime       string `json:"startTime"`
-	LastMessageTime string `json:"lastMessageTime"`
-}
-
-// Server encapsulates the information needed to represent a server...
-type Server struct {
-	Onion        string      `json:"onion"`
-	Identifier   int         `json:"identifier"`
-	Status       string      `json:"status"`
-	Description  string      `json:"description"`
-	Keys         []ServerKey `json:"keys"`
-	SyncProgress SyncStatus  `json:"syncProgress"`
-}
-
-// PublishServerUpdate serializes the current list of group servers and publishes an event with this information
-func (f *Functionality) PublishServerUpdate(profile peer.CwtchPeer) error {
-	serverListForOnion := f.GetServerInfoList(profile)
-	serversListBytes, err := json.Marshal(serverListForOnion)
-	profile.PublishEvent(event.NewEvent(UpdateServerInfo, map[event.Field]string{"ProfileOnion": profile.GetOnion(), ServerList: string(serversListBytes)}))
-	return err
-}
-
-// GetServerInfoList compiles all the information the UI might need regarding all servers..
-func (f *Functionality) GetServerInfoList(profile peer.CwtchPeer) []Server {
-	var servers []Server
-	for _, server := range profile.GetServers() {
-		server, err := f.GetServerInfo(profile, server)
-		if err != nil {
-			log.Errorf("profile server list is corrupted: %v", err)
-			continue
-		}
-		servers = append(servers, server)
-	}
-	return servers
-}
-
-// DeleteServer purges a server and all related keys from a profile
-func (f *Functionality) DeleteServerInfo(profile peer.CwtchPeer, serverOnion string) error {
-	// Servers are stores as special conversations
-	ci, err := profile.FetchConversationInfo(serverOnion)
-	if err != nil {
-		return err
-	}
-	// Purge keys...
-	// NOTE: This will leave some groups in the state of being unable to connect to a particular
-	// server.
-	profile.DeleteConversation(ci.ID)
-	f.PublishServerUpdate(profile)
-	return nil
-}
-
-// GetServerInfo compiles all the information the UI might need regarding a particular server including any verified
-// cryptographic keys
-func (f *Functionality) GetServerInfo(profile peer.CwtchPeer, serverOnion string) (Server, error) {
-	serverInfo, err := profile.FetchConversationInfo(serverOnion)
-	if err != nil {
-		return Server{}, errors.New("server not found")
-	}
-	keyTypes := []model.KeyType{model.KeyTypeServerOnion, model.KeyTypeTokenOnion, model.KeyTypePrivacyPass}
-	var serverKeys []ServerKey
-
-	for _, keyType := range keyTypes {
-		if key, has := serverInfo.GetAttribute(attr.PublicScope, attr.ServerKeyZone, string(keyType)); has {
-			serverKeys = append(serverKeys, ServerKey{Type: string(keyType), Key: key})
-		}
-	}
-
-	description, _ := serverInfo.GetAttribute(attr.LocalScope, attr.ServerZone, constants.Description)
-	startTimeStr := serverInfo.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.LegacyGroupZone.ConstructZonedPath(constants.SyncPreLastMessageTime)).ToString()]
-	recentTimeStr := serverInfo.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.LegacyGroupZone.ConstructZonedPath(constants.SyncMostRecentMessageTime)).ToString()]
-	syncStatus := SyncStatus{startTimeStr, recentTimeStr}
-
-	return Server{Onion: serverOnion, Identifier: serverInfo.ID, Status: connections.ConnectionStateName[profile.GetPeerState(serverInfo.Handle)], Keys: serverKeys, Description: description, SyncProgress: syncStatus}, nil
-}

go.mod

@@ -1,10 +1,10 @@
 module cwtch.im/cwtch
 
-go 1.20
+go 1.17
 
 require (
 	git.openprivacy.ca/cwtch.im/tapir v0.6.0
-	git.openprivacy.ca/openprivacy/connectivity v1.11.0
+	git.openprivacy.ca/openprivacy/connectivity v1.8.6
 	git.openprivacy.ca/openprivacy/log v1.0.3
 	github.com/gtank/ristretto255 v0.1.3-0.20210930101514-6bb39798585c
 	github.com/mutecomm/go-sqlcipher/v4 v4.4.2
@@ -15,7 +15,7 @@ require (
 
 require (
 	filippo.io/edwards25519 v1.0.0 // indirect
-	git.openprivacy.ca/openprivacy/bine v0.0.5 // indirect
+	git.openprivacy.ca/openprivacy/bine v0.0.4 // indirect
 	github.com/google/go-cmp v0.5.8 // indirect
 	github.com/gtank/merlin v0.1.1 // indirect
 	github.com/mimoo/StrobeGo v0.0.0-20220103164710-9a04d6ca976b // indirect

go.sum

@@ -1,23 +1,46 @@
+filippo.io/edwards25519 v1.0.0-rc.1/go.mod h1:N1IkdkCkiLB6tki+MYJoSx2JTY9NUlxZE7eHn5EwJns=
 filippo.io/edwards25519 v1.0.0 h1:0wAIcmJUqRdI8IJ/3eGi5/HwXZWPujYXXlkrQogz0Ek=
 filippo.io/edwards25519 v1.0.0/go.mod h1:N1IkdkCkiLB6tki+MYJoSx2JTY9NUlxZE7eHn5EwJns=
 git.openprivacy.ca/cwtch.im/tapir v0.6.0 h1:TtnKjxitkIDMM7Qn0n/u+mOHRLJzuQUYjYRu5n0/QFY=
 git.openprivacy.ca/cwtch.im/tapir v0.6.0/go.mod h1:iQIq4y7N+DuP3CxyG66WNEC/d6vzh+wXvvOmelB+KoY=
-git.openprivacy.ca/openprivacy/bine v0.0.5 h1:DJs5gqw3SkvLSgRDvroqJxZ7F+YsbxbBRg5t0rU5gYE=
-git.openprivacy.ca/openprivacy/bine v0.0.5/go.mod h1:fwdeq6RO08WDkV0k7HfArsjRvurVULoUQmT//iaABZM=
-git.openprivacy.ca/openprivacy/connectivity v1.11.0 h1:roASjaFtQLu+HdH5fa2wx6F00NL3YsUTlmXBJh8aLZk=
-git.openprivacy.ca/openprivacy/connectivity v1.11.0/go.mod h1:OQO1+7OIz/jLxDrorEMzvZA6SEbpbDyLGpjoFqT3z1Y=
+git.openprivacy.ca/openprivacy/bine v0.0.4 h1:CO7EkGyz+jegZ4ap8g5NWRuDHA/56KKvGySR6OBPW+c=
+git.openprivacy.ca/openprivacy/bine v0.0.4/go.mod h1:13ZqhKyqakDsN/ZkQkIGNULsmLyqtXc46XBcnuXm/mU=
+git.openprivacy.ca/openprivacy/connectivity v1.8.6 h1:g74PyDGvpMZ3+K0dXy3mlTJh+e0rcwNk0XF8owzkmOA=
+git.openprivacy.ca/openprivacy/connectivity v1.8.6/go.mod h1:Hn1gpOx/bRZp5wvCtPQVJPXrfeUH0EGiG/Aoa0vjGLg=
 git.openprivacy.ca/openprivacy/log v1.0.3 h1:E/PMm4LY+Q9s3aDpfySfEDq/vYQontlvNj/scrPaga0=
 git.openprivacy.ca/openprivacy/log v1.0.3/go.mod h1:gGYK8xHtndRLDymFtmjkG26GaMQNgyhioNS82m812Iw=
+github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI=
+github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI=
+github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
+github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
+github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE=
+github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
+github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8=
+github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:xKAWHe0F5eneWXFV3EuXVDTCmh+JuBKY0li0aMyXATA=
+github.com/golang/protobuf v1.4.0-rc.2/go.mod h1:LlEzMj4AhA7rCAGe4KMBDvJI+AwstrUpVNzEA03Pprs=
+github.com/golang/protobuf v1.4.0-rc.4.0.20200313231945-b860323f09d0/go.mod h1:WU3c8KckQ9AFe+yFwt9sWVRKCVIyN9cPHBJSNnbL67w=
+github.com/golang/protobuf v1.4.0/go.mod h1:jodUvKwWbYaEsadDk5Fwe5c77LiNKVO9IDvqG2KuDX0=
+github.com/golang/protobuf v1.4.2/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI=
+github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk=
 github.com/golang/protobuf v1.5.2 h1:ROPKBNFfQgOUMifHyP+KYbvpjbdoFNs+aK7DXlji0Tw=
+github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
+github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
+github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
+github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
+github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.5.8 h1:e6P7q2lk1O+qJJb4BtCQXlK8vWEO8V1ZeuEdJNOqZyg=
 github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
+github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/gtank/merlin v0.1.1 h1:eQ90iG7K9pOhtereWsmyRJ6RAwcP4tHTDBHXNg+u5is=
 github.com/gtank/merlin v0.1.1/go.mod h1:T86dnYJhcGOh5BjZFCJWTDeTK7XW8uE+E21Cy/bIQ+s=
 github.com/gtank/ristretto255 v0.1.3-0.20210930101514-6bb39798585c h1:gkfmnY4Rlt3VINCo4uKdpvngiibQyoENVj5Q88sxXhE=
 github.com/gtank/ristretto255 v0.1.3-0.20210930101514-6bb39798585c/go.mod h1:tDPFhGdt3hJWqtKwx57i9baiB1Cj0yAg22VOPUqm5vY=
+github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
+github.com/ianlancetaylor/demangle v0.0.0-20200824232613-28f6c0f3b639/go.mod h1:aSSvb/t6k1mPoxDqO4vJh6VOCGPwU4O0C2/Eqndh1Sc=
 github.com/kr/pretty v0.2.1 h1:Fmg33tUaq4/8ym9TJN1x7sLJnHVwhP33CNkpYV/7rwI=
 github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
@@ -28,43 +51,115 @@ github.com/mimoo/StrobeGo v0.0.0-20220103164710-9a04d6ca976b h1:QrHweqAtyJ9EwCaG
 github.com/mimoo/StrobeGo v0.0.0-20220103164710-9a04d6ca976b/go.mod h1:xxLb2ip6sSUts3g1irPVHyk/DGslwQsNOo9I7smJfNU=
 github.com/mutecomm/go-sqlcipher/v4 v4.4.2 h1:eM10bFtI4UvibIsKr10/QT7Yfz+NADfjZYh0GKrXUNc=
 github.com/mutecomm/go-sqlcipher/v4 v4.4.2/go.mod h1:mF2UmIpBnzFeBdu/ypTDb/LdbS0nk0dfSN1WUsWTjMA=
+github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A=
+github.com/nxadm/tail v1.4.8/go.mod h1:+ncqLTQzXmGhMZNUePPaPqPvBxHAIsmXswZKocGu+AU=
+github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
+github.com/onsi/ginkgo v1.12.1/go.mod h1:zj2OWP4+oCPe1qIXoGWkgMRwljMUYCdkwsT2108oapk=
+github.com/onsi/ginkgo v1.16.4 h1:29JGrr5oVBm5ulCWet69zQkzWipVXIol6ygQUe/EzNc=
+github.com/onsi/ginkgo v1.16.4/go.mod h1:dX+/inL/fNMqNlz0e9LfyB9TswhZpCVdJM/Z6Vvnwo0=
+github.com/onsi/ginkgo/v2 v2.1.3/go.mod h1:vw5CSIxN1JObi/U8gcbwft7ZxR2dgaR70JSE3/PpL4c=
 github.com/onsi/ginkgo/v2 v2.1.4 h1:GNapqRSid3zijZ9H77KrgVG4/8KqiyRsxcSxe+7ApXY=
 github.com/onsi/ginkgo/v2 v2.1.4/go.mod h1:um6tUpWM/cxCK3/FK8BXqEiUMUwRgSM4JXG47RKZmLU=
+github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY=
+github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo=
+github.com/onsi/gomega v1.17.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAlGdZY=
+github.com/onsi/gomega v1.19.0/go.mod h1:LY+I3pBVzYsTBU1AnDwOSxaYi9WoWiqgwooUqq9yPro=
 github.com/onsi/gomega v1.20.1 h1:PA/3qinGoukvymdIDV8pii6tiZgC8kbmJO6Z5+b002Q=
 github.com/onsi/gomega v1.20.1/go.mod h1:DtrZpjmvpn2mPm4YWQa0/ALMDj9v4YxLgojwPeREyVo=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
+github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
 github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
+github.com/yuin/goldmark v1.4.1/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
 go.etcd.io/bbolt v1.3.6 h1:/ecaJf0sk1l4l6V4awd65v2C3ILy7MSj+s/x1ADCIMU=
 go.etcd.io/bbolt v1.3.6/go.mod h1:qXsaaIqmgQH0T+OPdb99Bf+PKfBBQVAdyD6TY9G8XM4=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
+golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20201012173705-84dcc777aaee/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
+golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d h1:3qF+Z8Hkrw9sOhrFHti9TlB1Hkac1x+DNRkv0XQiFjo=
 golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
+golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
+golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3/go.mod h1:3p9vT2HGsQu2K1YbXdKPJLVgG5VJdoTa1poYQBtP1AY=
+golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
+golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
+golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7/go.mod h1:qpuaurCH72eLCgpAm/N6yyVIVM9cpaDIP3A8BGJEC5A=
 golang.org/x/net v0.0.0-20201010224723-4f7140c49acb/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
+golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
+golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
+golang.org/x/net v0.0.0-20210428140749-89ef3d95e781/go.mod h1:OJAsFXCWl8Ukc7SiCT/9KSuxbyM7479/AVlXFRxuMCk=
+golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
+golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
+golang.org/x/net v0.0.0-20220225172249-27dd8689420f/go.mod h1:CfG3xpIq0wQ8r1q4Su4UZFWDARRcnwPjda9FqA0JpMk=
+golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4/go.mod h1:CfG3xpIq0wQ8r1q4Su4UZFWDARRcnwPjda9FqA0JpMk=
 golang.org/x/net v0.0.0-20220826154423-83b083e8dc8b h1:ZmngSVLe/wycRns9MKikG9OWIEjGcGAkacif7oYQaUY=
 golang.org/x/net v0.0.0-20220826154423-83b083e8dc8b/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk=
+golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
+golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20190904154756-749cb33beabd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20191005200804-aed5e4c7ecf9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20191204072324-ce4227a45e2e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200923182605-d9f96fdee20d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210112080510-489259a85091/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20211019181941-9d821ace8654/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220319134239-a9b59b0215f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220422013727-9388b58f7150/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220728004956-3c1f35247d10/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220825204002-c680a09ffe64 h1:UiNENfZ8gDvpiWw7IpOMQ27spWmThO1RwwdQVbJahJM=
 golang.org/x/sys v0.0.0-20220825204002-c680a09ffe64/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
+golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
+golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.7 h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
+golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
+golang.org/x/tools v0.0.0-20201224043029-2b0845dc783e/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
+golang.org/x/tools v0.1.10/go.mod h1:Uh6Zz+xoGYZom868N8YTex3t7RhtHDBrE8Gzo9bV56E=
+golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
+google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
+google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
+google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=
+google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967/go.mod h1:A+miEFZTKqfCUM6K7xSMQL9OKL/b6hQv+e19PK+JZNE=
+google.golang.org/protobuf v1.21.0/go.mod h1:47Nbq4nVaFHyn7ilMalzfO3qCViNmqZ2kzikPIcrTAo=
+google.golang.org/protobuf v1.23.0/go.mod h1:EGpADcykh3NcUnDUJcl1+ZksZNG86OlYog2l/sGQquU=
+google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=
+google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
 google.golang.org/protobuf v1.28.0 h1:w43yiav+6bVFTBQFZX0r7ipe9JQ1QsbMgHwbBziscLw=
+google.golang.org/protobuf v1.28.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
+gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMys=
+gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw=
+gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

model/attr/scope.go

@@ -23,12 +23,6 @@ type Scope string
 // ScopedZonedPath typed path with a scope and a zone
 type ScopedZonedPath string
 
-func (szp ScopedZonedPath) GetScopeZonePath() (Scope, Zone, string) {
-	scope, path := ParseScope(string(szp))
-	zone, zpath := ParseZone(path)
-	return scope, zone, zpath
-}
-
 // scopes for attributes
 const (
 	// on a peer, local and peer supplied data

model/constants/attributes.go

@@ -56,19 +56,3 @@ const SyncPreLastMessageTime = "SyncPreLastMessageTime"
 const SyncMostRecentMessageTime = "SyncMostRecentMessageTime"
 
 const AttrLastConnectionTime = "last-connection-time"
-const PeerAutostart = "autostart"
-const PeerAppearOffline = "appear-offline"
-const Archived = "archived"
-
-const ProfileStatus = "profile-status"
-const ProfileAttribute1 = "profile-attribute-1"
-const ProfileAttribute2 = "profile-attribute-2"
-const ProfileAttribute3 = "profile-attribute-3"
-
-// Description is used on server contacts,
-const Description = "description"
-
-// Used to store the status of acl migrations
-const ACLVersion = "acl-version"
-const ACLVersionOne = "acl-v1"
-const ACLVersionTwo = "acl-v2"

model/constants/experiments.go

@@ -1,7 +1,5 @@
 package constants
 
-const GroupsExperiment = "tapir-groups-experiment"
-
 // FileSharingExperiment Allows file sharing
 const FileSharingExperiment = "filesharing"
 
@@ -12,10 +10,5 @@ const ImagePreviewsExperiment = "filesharing-images"
 // ImagePreviewMaxSizeInBytes Files up to this size will be autodownloaded using ImagePreviewsExperiment
 const ImagePreviewMaxSizeInBytes = 20971520
 
-const MessageFormattingExperiment = "message-formatting"
-
 // AutoDLFileExts Files with these extensions will be autodownloaded using ImagePreviewsExperiment
 var AutoDLFileExts = [...]string{".jpg", ".jpeg", ".png", ".gif", ".webp", ".bmp"}
-
-// BlodeuweddExperiment enables the Blodeuwedd Assistant
-const BlodeuweddExperiment = "blodeuwedd"

model/conversation.go

@@ -1,36 +1,22 @@
 package model
 
 import (
-	"encoding/json"
-	"time"
-
 	"cwtch.im/cwtch/model/attr"
 	"cwtch.im/cwtch/model/constants"
-	"git.openprivacy.ca/openprivacy/connectivity/tor"
-	"git.openprivacy.ca/openprivacy/log"
+	"encoding/json"
+	"time"
 )
 
 // AccessControl is a type determining client assigned authorization to a peer
-// for a given conversation
 type AccessControl struct {
-	Blocked bool // Any attempts from this handle to connect are blocked overrides all other settings
-
-	// Basic Conversation Rights
-	Read   bool // Allows a handle to access the conversation
-	Append bool // Allows a handle to append new messages to the conversation
-
-	AutoConnect        bool // Profile should automatically try to connect with peer
-	ExchangeAttributes bool // Profile should automatically exchange attributes like Name, Profile Image, etc.
-
-	// Extension Related Permissions
-	ShareFiles   bool // Allows a handle to share files to a conversation
-	RenderImages bool // Indicates that certain filetypes should be autodownloaded and rendered when shared by this contact
+	Blocked bool // Any attempts from this handle to connect are blocked
+	Read    bool // Allows a handle to access the conversation
+	Append  bool // Allows a handle to append new messages to the conversation
 }
 
-// DefaultP2PAccessControl defaults to a semi-trusted peer with no access to special extensions.
+// DefaultP2PAccessControl - because in the year 2021, go does not support constant structs...
 func DefaultP2PAccessControl() AccessControl {
-	return AccessControl{Read: true, Append: true, ExchangeAttributes: true, Blocked: false,
-		AutoConnect: true, ShareFiles: false, RenderImages: false}
+	return AccessControl{Read: true, Append: true, Blocked: false}
 }
 
 // AccessControlList represents an access control list for a conversation. Mapping handles to conversation
@@ -44,10 +30,10 @@ func (acl *AccessControlList) Serialize() []byte {
 }
 
 // DeserializeAccessControlList takes in JSON and returns an AccessControlList
-func DeserializeAccessControlList(data []byte) (AccessControlList, error) {
+func DeserializeAccessControlList(data []byte) AccessControlList {
 	var acl AccessControlList
-	err := json.Unmarshal(data, &acl)
-	return acl, err
+	json.Unmarshal(data, &acl)
+	return acl
 }
 
 // Attributes a type-driven encapsulation of an Attribute map.
@@ -61,12 +47,8 @@ func (a *Attributes) Serialize() []byte {
 
 // DeserializeAttributes converts a JSON struct into an Attributes map
 func DeserializeAttributes(data []byte) Attributes {
-	attributes := make(Attributes)
-	err := json.Unmarshal(data, &attributes)
-	if err != nil {
-		log.Error("error deserializing attributes (this is likely a programming error): %v", err)
-		return make(Attributes)
-	}
+	var attributes Attributes
+	json.Unmarshal(data, &attributes)
 	return attributes
 }
 
@@ -78,9 +60,7 @@ type Conversation struct {
 	Handle     string
 	Attributes Attributes
 	ACL        AccessControlList
-
-	// Deprecated, please use ACL for permissions related functions
-	Accepted bool
+	Accepted   bool
 }
 
 // GetAttribute is a helper function that fetches a conversation attribute by scope, zone and key
@@ -91,21 +71,6 @@ func (ci *Conversation) GetAttribute(scope attr.Scope, zone attr.Zone, key strin
 	return "", false
 }
 
-// GetPeerAC returns a suitable Access Control object for a the given peer conversation
-// If this is called for a group conversation, this method will error and return a safe default AC.
-func (ci *Conversation) GetPeerAC() AccessControl {
-	if acl, exists := ci.ACL[ci.Handle]; exists {
-		return acl
-	}
-	log.Errorf("attempted to access a Peer Access Control object from %v but peer ACL is undefined. This is likely a programming error", ci.Handle)
-	return DefaultP2PAccessControl()
-}
-
-// IsCwtchPeer is a helper attribute that identifies whether a conversation is a cwtch peer
-func (ci *Conversation) IsCwtchPeer() bool {
-	return tor.IsValidHostname(ci.Handle)
-}
-
 // IsGroup is a helper attribute that identifies whether a conversation is a legacy group
 func (ci *Conversation) IsGroup() bool {
 	if _, exists := ci.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.LegacyGroupZone.ConstructZonedPath(constants.GroupID)).ToString()]; exists {

model/experiments.go

@@ -1,41 +0,0 @@
-package model
-
-import "sync"
-
-// Experiments are optional functionality that can be enabled/disabled by an application either completely or individually.
-// examples of experiments include File Sharing, Profile Images and Groups.
-type Experiments struct {
-	enabled     bool
-	experiments sync.Map
-}
-
-// InitExperiments encapsulates a set of experiments separate from their storage in GlobalSettings.
-func InitExperiments(enabled bool, experiments map[string]bool) Experiments {
-
-	var syncExperiments sync.Map
-	for experiment, set := range experiments {
-		syncExperiments.Store(experiment, set)
-	}
-
-	return Experiments{
-		enabled:     enabled,
-		experiments: syncExperiments,
-	}
-}
-
-// IsEnabled is a convenience function that takes in an experiment and returns true if it is enabled. Experiments
-// are only enabled if both global experiments are turned on and if the specific experiment is also turned on.
-// The one exception to this is experiments that have been promoted to default functionality which may be turned on
-// even if experiments turned off globally. These experiments are defined by DefaultEnabledFunctionality.
-func (e *Experiments) IsEnabled(experiment string) bool {
-	if !e.enabled {
-		// todo handle default-enabled functionality
-		return false
-	}
-
-	enabled, exists := e.experiments.Load(experiment)
-	if !exists {
-		return false
-	}
-	return enabled.(bool)
-}

model/group.go

@@ -59,26 +59,21 @@ func NewGroup(server string) (*Group, error) {
 
 	// Derive Group ID from the group key and the server public key. This binds the group to a particular server
 	// and key.
-	var err error
-	group.GroupID, err = deriveGroupID(groupKey[:], server)
-	return group, err
+	group.GroupID = deriveGroupID(groupKey[:], server)
+	return group, nil
 }
 
 // CheckGroup returns true only if the ID of the group is cryptographically valid.
 func (g *Group) CheckGroup() bool {
-	id, _ := deriveGroupID(g.GroupKey[:], g.GroupServer)
-	return g.GroupID == id
+	return g.GroupID == deriveGroupID(g.GroupKey[:], g.GroupServer)
 }
 
 // deriveGroupID hashes together the key and the hostname to create a bound identifier that can later
 // be referenced and checked by profiles when they receive invites and messages.
-func deriveGroupID(groupKey []byte, serverHostname string) (string, error) {
-	data, err := base32.StdEncoding.DecodeString(strings.ToUpper(serverHostname))
-	if err != nil {
-		return "", err
-	}
+func deriveGroupID(groupKey []byte, serverHostname string) string {
+	data, _ := base32.StdEncoding.DecodeString(strings.ToUpper(serverHostname))
 	pubkey := data[0:ed25519.PublicKeySize]
-	return hex.EncodeToString(pbkdf2.Key(groupKey, pubkey, 4096, 16, sha512.New)), nil
+	return hex.EncodeToString(pbkdf2.Key(groupKey, pubkey, 4096, 16, sha512.New))
 }
 
 // Invite generates a invitation that can be sent to a cwtch peer
@@ -153,7 +148,7 @@ func ValidateInvite(invite string) (*groups.GroupInvite, error) {
 
 				// Derive the servers public key (we can ignore the error checking here because it's already been
 				// done by IsValidHostname, and check that we derive the same groupID...
-				derivedGroupID, _ := deriveGroupID(gci.SharedKey, gci.ServerHost)
+				derivedGroupID := deriveGroupID(gci.SharedKey, gci.ServerHost)
 				if derivedGroupID != gci.GroupID {
 					return nil, errors.New("group id is invalid")
 				}
@@ -171,9 +166,7 @@ func ValidateInvite(invite string) (*groups.GroupInvite, error) {
 // If successful, adds the message to the group's timeline
 func (g *Group) AttemptDecryption(ciphertext []byte, signature []byte) (bool, *groups.DecryptedGroupMessage) {
 	success, dgm := g.DecryptMessage(ciphertext)
-	// the second check here is not needed, but DecryptMessage violates the usual
-	// go calling convention and we want static analysis tools to pick it up
-	if success && dgm != nil {
+	if success {
 
 		// Attempt to serialize this message
 		serialized, err := json.Marshal(dgm)

model/group_test.go

@@ -9,10 +9,7 @@ import (
 )
 
 func TestGroup(t *testing.T) {
-	g, err := NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
-	if err != nil {
-		t.Fatalf("Group with real group server should not fail")
-	}
+	g, _ := NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
 	dgm := &groups.DecryptedGroupMessage{
 		Onion:              "onion",
 		Text:               "Hello World!",
@@ -40,7 +37,7 @@ func TestGroup(t *testing.T) {
 
 	encMessage, _ := g.EncryptMessage(dgm)
 	ok, message := g.DecryptMessage(encMessage)
-	if (!ok || message == nil) || message.Text != "Hello World!" {
+	if !ok || message.Text != "Hello World!" {
 		t.Errorf("group encryption was invalid, or returned wrong message decrypted:%v message:%v", ok, message)
 		return
 	}
@@ -76,10 +73,7 @@ func TestGroupValidation(t *testing.T) {
 	t.Logf("Error: %v", err)
 
 	// Generate a valid group but replace the group server...
-	group, err = NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
-	if err != nil {
-		t.Fatalf("Group with real group server should not fail")
-	}
+	group, _ = NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
 	group.GroupServer = "tcnkoch4nyr3cldkemejtkpqok342rbql6iclnjjs3ndgnjgufzyxvqd"
 	invite, _ = group.Invite()
 	_, err = ValidateInvite(invite)
@@ -90,10 +84,7 @@ func TestGroupValidation(t *testing.T) {
 	t.Logf("Error: %v", err)
 
 	// Generate a valid group but replace the group key...
-	group, err = NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
-	if err != nil {
-		t.Fatalf("Group with real group server should not fail")
-	}
+	group, _ = NewGroup("2c3kmoobnyghj2zw6pwv7d57yzld753auo3ugauezzpvfak3ahc4bdyd")
 	group.GroupKey = sha256.Sum256([]byte{})
 	invite, _ = group.Invite()
 	_, err = ValidateInvite(invite)

model/message_utils.go

@@ -3,7 +3,6 @@ package model
 import (
 	"crypto/sha256"
 	"encoding/base64"
-	"encoding/json"
 )
 
 // CalculateContentHash derives a hash using the author and the message body. It is intended to be
@@ -13,13 +12,3 @@ func CalculateContentHash(author string, messageBody string) string {
 	contentBasedHash := sha256.Sum256(content)
 	return base64.StdEncoding.EncodeToString(contentBasedHash[:])
 }
-
-func DeserializeMessage(message string) (*MessageWrapper, error) {
-	var cm MessageWrapper
-	err := json.Unmarshal([]byte(message), &cm)
-
-	if err != nil {
-		return nil, err
-	}
-	return &cm, err
-}

model/overlay.go

@@ -1,40 +1,9 @@
 package model
 
-import (
-	"time"
-)
-
 // MessageWrapper is the canonical Cwtch overlay wrapper
 type MessageWrapper struct {
 	Overlay int    `json:"o"`
 	Data    string `json:"d"`
-
-	// when the data was assembled
-	SendTime *time.Time `json:"s,omitempty"`
-
-	// when the data was transmitted (by protocol engine e.g. over Tor)
-	TransitTime *time.Time `json:"t,omitempty"`
-
-	// when the data was received
-	RecvTime *time.Time `json:"r,omitempty"`
-}
-
-// Channel is defined as being the last 3 bits of the overlay id
-// Channel 0 is reserved for the main conversation
-// Channel 2 is reserved for conversation admin (managed groups)
-// Channel 7 is reserved for streams (no ack, no store)
-func (mw MessageWrapper) Channel() int {
-	if mw.Overlay > 1024 {
-		return mw.Overlay & 0x07
-	}
-	// for backward compatibilty all overlays less than 0x400 i.e. 1024 are
-	// mapped to channel 0 regardless of their channel status.
-	return 0
-}
-
-// If Overlay is a Stream Message it should not be ackd, or stored.
-func (mw MessageWrapper) IsStream() bool {
-	return mw.Channel() == 0x07
 }
 
 // OverlayChat is the canonical identifier for chat overlays

model/profile.go

@@ -80,19 +80,11 @@ func (p *Profile) GetCopy(timeline bool) *Profile {
 
 	if timeline {
 		for groupID := range newp.Groups {
-			if group, exists := newp.Groups[groupID]; exists {
-				if pGroup, exists := p.Groups[groupID]; exists {
-					group.Timeline = *(pGroup).Timeline.GetCopy()
-				}
-			}
+			newp.Groups[groupID].Timeline = *p.Groups[groupID].Timeline.GetCopy()
 		}
 
 		for peerID := range newp.Contacts {
-			if peer, exists := newp.Contacts[peerID]; exists {
-				if pPeer, exists := p.Contacts[peerID]; exists {
-					peer.Timeline = *(pPeer).Timeline.GetCopy()
-				}
-			}
+			newp.Contacts[peerID].Timeline = *p.Contacts[peerID].Timeline.GetCopy()
 		}
 	}
 

peer/cwtchprofilestorage.go

@@ -13,7 +13,6 @@ import (
 	"io"
 	"os"
 	"path/filepath"
-	"strconv"
 	"strings"
 	"sync"
 )
@@ -62,7 +61,6 @@ type CwtchProfileStorage struct {
 	channelGetMostRecentMessagesStmts   map[ChannelID]*sql.Stmt
 	channelGetMessageByContentHashStmts map[ChannelID]*sql.Stmt
 	channelRowNumberStmts               map[ChannelID]*sql.Stmt
-	channelSearchConversationSQLStmt    map[ChannelID]*sql.Stmt
 	ProfileDirectory                    string
 	db                                  *sql.DB
 }
@@ -116,9 +114,6 @@ const getMessageCountFromConversationSQLStmt = `select count(*) from channel_%d_
 // getMostRecentMessagesSQLStmt is a template for fetching the most recent N messages in a conversation channel
 const getMostRecentMessagesSQLStmt = `select ID, Body, Attributes, Signature, ContentHash from channel_%d_%d_chat order by ID desc limit (?) offset (?);`
 
-// searchConversationSQLStmt is a template for search a conversation for the most recent N messages matching a given pattern
-const searchConversationSQLStmt = `select  ID, Body, Attributes, Signature, ContentHash from (select ID, Body, Attributes, Signature, ContentHash from channel_%d_%d_chat order by ID desc limit (?) offset (?)) where BODY like (?)`
-
 // NewCwtchProfileStorage constructs a new CwtchProfileStorage from a database. It is also responsible for
 // Preparing commonly used SQL Statements
 func NewCwtchProfileStorage(db *sql.DB, profileDirectory string) (*CwtchProfileStorage, error) {
@@ -129,79 +124,77 @@ func NewCwtchProfileStorage(db *sql.DB, profileDirectory string) (*CwtchProfileS
 
 	insertProfileKeyValueStmt, err := db.Prepare(insertProfileKeySQLStmt)
 	if err != nil {
-		_ = db.Close()
-		// note: this is debug because we expect failure here when opening an encrypted database with an
-		// incorrect password. The rest are errors because failure is not expected.
-		log.Debugf("error preparing query: %v %v", insertProfileKeySQLStmt, err)
+		db.Close()
+		log.Errorf("error preparing query: %v %v", insertProfileKeySQLStmt, err)
 		return nil, err
 	}
 
 	selectProfileKeyStmt, err := db.Prepare(selectProfileKeySQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", selectProfileKeySQLStmt, err)
 		return nil, err
 	}
 
 	findProfileKeyStmt, err := db.Prepare(findProfileKeySQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", findProfileKeySQLStmt, err)
 		return nil, err
 	}
 
 	insertConversationStmt, err := db.Prepare(insertConversationSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", insertConversationSQLStmt, err)
 		return nil, err
 	}
 
 	fetchAllConversationsStmt, err := db.Prepare(fetchAllConversationsSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", fetchAllConversationsSQLStmt, err)
 		return nil, err
 	}
 
 	selectConversationStmt, err := db.Prepare(selectConversationSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", selectConversationSQLStmt, err)
 		return nil, err
 	}
 
 	selectConversationByHandleStmt, err := db.Prepare(selectConversationByHandleSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", selectConversationByHandleSQLStmt, err)
 		return nil, err
 	}
 
 	acceptConversationStmt, err := db.Prepare(acceptConversationSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", acceptConversationSQLStmt, err)
 		return nil, err
 	}
 
 	deleteConversationStmt, err := db.Prepare(deleteConversationSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", deleteConversationSQLStmt, err)
 		return nil, err
 	}
 
 	setConversationAttributesStmt, err := db.Prepare(setConversationAttributesSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", setConversationAttributesSQLStmt, err)
 		return nil, err
 	}
 
 	setConversationACLStmt, err := db.Prepare(setConversationACLSQLStmt)
 	if err != nil {
-		_ = db.Close()
+		db.Close()
 		log.Errorf("error preparing query: %v %v", setConversationACLSQLStmt, err)
 		return nil, err
 	}
@@ -227,15 +220,12 @@ func NewCwtchProfileStorage(db *sql.DB, profileDirectory string) (*CwtchProfileS
 			channelGetMostRecentMessagesStmts:   map[ChannelID]*sql.Stmt{},
 			channelGetCountStmts:                map[ChannelID]*sql.Stmt{},
 			channelRowNumberStmts:               map[ChannelID]*sql.Stmt{},
-			channelSearchConversationSQLStmt:    map[ChannelID]*sql.Stmt{},
 		},
 		nil
 }
 
 // StoreProfileKeyValue allows storing of typed Key/Value attribute in the Storage Engine
 func (cps *CwtchProfileStorage) StoreProfileKeyValue(keyType StorageKeyType, key string, value []byte) error {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	_, err := cps.insertProfileKeyValueStmt.Exec(keyType, key, value)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -246,8 +236,6 @@ func (cps *CwtchProfileStorage) StoreProfileKeyValue(keyType StorageKeyType, key
 
 // FindProfileKeysByPrefix allows fetching of typed values via a known Key from the Storage Engine
 func (cps *CwtchProfileStorage) FindProfileKeysByPrefix(keyType StorageKeyType, prefix string) ([]string, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	rows, err := cps.findProfileKeySQLStmt.Query(keyType, prefix+"%")
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -276,8 +264,6 @@ func (cps *CwtchProfileStorage) FindProfileKeysByPrefix(keyType StorageKeyType,
 
 // LoadProfileKeyValue allows fetching of typed values via a known Key from the Storage Engine
 func (cps *CwtchProfileStorage) LoadProfileKeyValue(keyType StorageKeyType, key string) ([]byte, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	rows, err := cps.selectProfileKeyValueStmt.Query(keyType, key)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -303,8 +289,6 @@ func (cps *CwtchProfileStorage) LoadProfileKeyValue(keyType StorageKeyType, key
 
 // NewConversation stores a new conversation in the data store
 func (cps *CwtchProfileStorage) NewConversation(handle string, attributes model.Attributes, acl model.AccessControlList, accepted bool) (int, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	tx, err := cps.db.Begin()
 
 	if err != nil {
@@ -350,8 +334,6 @@ func (cps *CwtchProfileStorage) NewConversation(handle string, attributes model.
 // Ideally this function should not exist, and all lookups should happen by ID (this is currently
 // unavoidable in some circumstances because the event bus references conversations by handle, not by id)
 func (cps *CwtchProfileStorage) GetConversationByHandle(handle string) (*model.Conversation, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	rows, err := cps.selectConversationByHandleStmt.Query(handle)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -376,20 +358,13 @@ func (cps *CwtchProfileStorage) GetConversationByHandle(handle string) (*model.C
 	}
 	rows.Close()
 
-	cacl, err := model.DeserializeAccessControlList(acl)
-	if err != nil {
-		log.Errorf("error deserializing ACL from database, database maybe corrupted: %v", err)
-		return nil, err
-	}
-	return &model.Conversation{ID: id, Handle: handle, ACL: cacl, Attributes: model.DeserializeAttributes(attributes), Accepted: accepted}, nil
+	return &model.Conversation{ID: id, Handle: handle, ACL: model.DeserializeAccessControlList(acl), Attributes: model.DeserializeAttributes(attributes), Accepted: accepted}, nil
 }
 
 // FetchConversations returns *all* active conversations. This method should only be called
 // on app start up to build a summary of conversations for the UI. Any further updates should be integrated
 // through the event bus.
 func (cps *CwtchProfileStorage) FetchConversations() ([]*model.Conversation, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	rows, err := cps.fetchAllConversationsStmt.Query()
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -417,21 +392,13 @@ func (cps *CwtchProfileStorage) FetchConversations() ([]*model.Conversation, err
 			rows.Close()
 			return nil, err
 		}
-
-		cacl, err := model.DeserializeAccessControlList(acl)
-		if err != nil {
-			log.Errorf("error deserializing ACL from database, database maybe corrupted: %v", err)
-			return nil, err
-		}
-		conversations = append(conversations, &model.Conversation{ID: id, Handle: handle, ACL: cacl, Attributes: model.DeserializeAttributes(attributes), Accepted: accepted})
+		conversations = append(conversations, &model.Conversation{ID: id, Handle: handle, ACL: model.DeserializeAccessControlList(acl), Attributes: model.DeserializeAttributes(attributes), Accepted: accepted})
 
 	}
 }
 
 // GetConversation looks up a particular conversation by id
 func (cps *CwtchProfileStorage) GetConversation(id int) (*model.Conversation, error) {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	rows, err := cps.selectConversationStmt.Query(id)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -456,18 +423,11 @@ func (cps *CwtchProfileStorage) GetConversation(id int) (*model.Conversation, er
 	}
 	rows.Close()
 
-	cacl, err := model.DeserializeAccessControlList(acl)
-	if err != nil {
-		log.Errorf("error deserializing ACL from database, database maybe corrupted: %v", err)
-		return nil, err
-	}
-	return &model.Conversation{ID: id, Handle: handle, ACL: cacl, Attributes: model.DeserializeAttributes(attributes), Accepted: accepted}, nil
+	return &model.Conversation{ID: id, Handle: handle, ACL: model.DeserializeAccessControlList(acl), Attributes: model.DeserializeAttributes(attributes), Accepted: accepted}, nil
 }
 
 // AcceptConversation sets the accepted status of a conversation to true in the backing datastore
 func (cps *CwtchProfileStorage) AcceptConversation(id int) error {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	_, err := cps.acceptConversationStmt.Exec(id)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -478,8 +438,6 @@ func (cps *CwtchProfileStorage) AcceptConversation(id int) error {
 
 // DeleteConversation purges the conversation and any associated message history from the conversation store.
 func (cps *CwtchProfileStorage) DeleteConversation(id int) error {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	_, err := cps.deleteConversationStmt.Exec(id)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -490,8 +448,6 @@ func (cps *CwtchProfileStorage) DeleteConversation(id int) error {
 
 // SetConversationACL sets a new ACL on a given conversation.
 func (cps *CwtchProfileStorage) SetConversationACL(id int, acl model.AccessControlList) error {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	_, err := cps.setConversationACLStmt.Exec(acl.Serialize(), id)
 	if err != nil {
 		log.Errorf("error executing query: %v", err)
@@ -506,8 +462,6 @@ func (cps *CwtchProfileStorage) SetConversationAttribute(id int, path attr.Scope
 	if err != nil {
 		return err
 	}
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	ci.Attributes[path.ToString()] = value
 	_, err = cps.setConversationAttributesStmt.Exec(ci.Attributes.Serialize(), id)
 	if err != nil {
@@ -519,6 +473,7 @@ func (cps *CwtchProfileStorage) SetConversationAttribute(id int, path attr.Scope
 
 // InsertMessage appends a message to a conversation channel, with a given set of attributes
 func (cps *CwtchProfileStorage) InsertMessage(conversation int, channel int, body string, attributes model.Attributes, signature string, contentHash string) (int, error) {
+
 	channelID := ChannelID{Conversation: conversation, Channel: channel}
 
 	cps.mutex.Lock()
@@ -757,47 +712,8 @@ func (cps *CwtchProfileStorage) GetChannelMessageCount(conversation int, channel
 	return count, nil
 }
 
-func (cps *CwtchProfileStorage) SearchMessages(conversation int, channel int, pattern string, offset int, limit int) ([]model.ConversationMessage, error) {
-	channelID := ChannelID{Conversation: conversation, Channel: channel}
-
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
-	_, exists := cps.channelSearchConversationSQLStmt[channelID]
-	if !exists {
-		conversationStmt, err := cps.db.Prepare(fmt.Sprintf(searchConversationSQLStmt, conversation, channel))
-		if err != nil {
-			log.Errorf("error executing transaction: %v", err)
-			return nil, err
-		}
-		cps.channelSearchConversationSQLStmt[channelID] = conversationStmt
-	}
-	rows, err := cps.channelSearchConversationSQLStmt[channelID].Query(limit, offset, pattern)
-	if err != nil {
-		log.Errorf("error executing prepared stmt: %v", err)
-		return nil, err
-	}
-	var conversationMessages []model.ConversationMessage
-	defer rows.Close()
-	for {
-		result := rows.Next()
-		if !result {
-			return conversationMessages, nil
-		}
-		var id int
-		var body string
-		var attributes []byte
-		var sig string
-		var contenthash string
-		err = rows.Scan(&id, &body, &attributes, &sig, &contenthash)
-		if err != nil {
-			return conversationMessages, err
-		}
-		conversationMessages = append(conversationMessages, model.ConversationMessage{ID: id, Body: body, Attr: model.DeserializeAttributes(attributes), Signature: sig, ContentHash: contenthash})
-	}
-}
-
 // GetMostRecentMessages returns the most recent messages in a channel up to a given limit at a given offset
-func (cps *CwtchProfileStorage) GetMostRecentMessages(conversation int, channel int, offset int, limit uint) ([]model.ConversationMessage, error) {
+func (cps *CwtchProfileStorage) GetMostRecentMessages(conversation int, channel int, offset int, limit int) ([]model.ConversationMessage, error) {
 	channelID := ChannelID{Conversation: conversation, Channel: channel}
 
 	cps.mutex.Lock()
@@ -839,8 +755,6 @@ func (cps *CwtchProfileStorage) GetMostRecentMessages(conversation int, channel
 
 // PurgeConversationChannel deletes all message for a conversation channel.
 func (cps *CwtchProfileStorage) PurgeConversationChannel(conversation int, channel int) error {
-	cps.mutex.Lock()
-	defer cps.mutex.Unlock()
 	conversationStmt, err := cps.db.Prepare(fmt.Sprintf(purgeMessagesFromConversationSQLStmt, conversation, channel))
 	if err != nil {
 		log.Errorf("error executing transaction: %v", err)
@@ -852,31 +766,13 @@ func (cps *CwtchProfileStorage) PurgeConversationChannel(conversation int, chann
 
 // PurgeNonSavedMessages deletes all message conversations that are not explicitly set to saved.
 func (cps *CwtchProfileStorage) PurgeNonSavedMessages() {
-
-	// check to see if the profile global setting has been explicitly set to save (peer) conversations by default.
-	defaultSave := false
-	key, err := cps.LoadProfileKeyValue(TypeAttribute, attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(event.PreserveHistoryDefaultSettingKey)).ToString())
-	if err == nil {
-		if defaultSaveSetting, err := strconv.ParseBool(string(key)); err == nil {
-			defaultSave = defaultSaveSetting
-		}
-	}
-
-	// For each conversation, all that is not explicitly saved will be lost...
+	// Purge Messages that are not stored...
 	ci, err := cps.FetchConversations()
 	if err == nil {
 		for _, conversation := range ci {
-			// unless this is a server or a group...for which we default save always (for legacy reasons)
-			// FIXME: revisit this for hybrid groups.
 			if !conversation.IsGroup() && !conversation.IsServer() {
-				// Note that we only check for confirmed status here...if it is set to any other value we will fallthrough to the default.
-				saveHistoryConfirmed := conversation.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(event.SaveHistoryKey)).ToString()] == event.SaveHistoryConfirmed
-				deleteHistoryConfirmed := conversation.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(event.SaveHistoryKey)).ToString()] == event.DeleteHistoryConfirmed
-				// we purge conversation history in two specific instances...
-				// if the conversation has been explicitly marked as delete history confirmed OR
-				// if save history hasn't been confirmed and default save history is false - i.e. in all other cases
-				if deleteHistoryConfirmed || (!saveHistoryConfirmed && !defaultSave) {
-					log.Debugf("purging conversation...")
+				if conversation.Attributes[attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(event.SaveHistoryKey)).ToString()] != event.SaveHistoryConfirmed {
+					log.Infof("purging conversation...")
 					// TODO: At some point in the future this needs to iterate over channels and make a decision for each on..
 					cps.PurgeConversationChannel(conversation.ID, 0)
 				}
@@ -887,49 +783,48 @@ func (cps *CwtchProfileStorage) PurgeNonSavedMessages() {
 
 // Close closes the underlying database and prepared statements
 func (cps *CwtchProfileStorage) Close(purgeAllNonSavedMessages bool) {
+	cps.mutex.Lock()
+	defer cps.mutex.Unlock()
 	if cps.db != nil {
 		if purgeAllNonSavedMessages {
 			cps.PurgeNonSavedMessages()
 		}
-		// We can't lock before this..
-		cps.mutex.Lock()
-		defer cps.mutex.Unlock()
 
-		_ = cps.insertProfileKeyValueStmt.Close()
-		_ = cps.selectProfileKeyValueStmt.Close()
+		cps.insertProfileKeyValueStmt.Close()
+		cps.selectProfileKeyValueStmt.Close()
 
-		_ = cps.insertConversationStmt.Close()
-		_ = cps.fetchAllConversationsStmt.Close()
-		_ = cps.selectConversationStmt.Close()
-		_ = cps.selectConversationByHandleStmt.Close()
-		_ = cps.acceptConversationStmt.Close()
-		_ = cps.deleteConversationStmt.Close()
-		_ = cps.setConversationAttributesStmt.Close()
-		_ = cps.setConversationACLStmt.Close()
+		cps.insertConversationStmt.Close()
+		cps.fetchAllConversationsStmt.Close()
+		cps.selectConversationStmt.Close()
+		cps.selectConversationByHandleStmt.Close()
+		cps.acceptConversationStmt.Close()
+		cps.deleteConversationStmt.Close()
+		cps.setConversationAttributesStmt.Close()
+		cps.setConversationACLStmt.Close()
 
 		for _, v := range cps.channelInsertStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelUpdateMessageStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelGetMessageStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelGetMessageBySignatureStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelGetCountStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelGetMostRecentMessagesStmts {
-			_ = v.Close()
+			v.Close()
 		}
 		for _, v := range cps.channelGetMessageByContentHashStmts {
-			_ = v.Close()
+			v.Close()
 		}
 
-		_ = cps.db.Close()
+		cps.db.Close()
 	}
 }
 

peer/hooks.go

@@ -1,52 +0,0 @@
-package peer
-
-import (
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/settings"
-)
-
-type ProfileHooks interface {
-	// EventsToRegister returns a set of events that the extension is interested hooking
-	EventsToRegister() []event.Type
-
-	// ExperimentsToRegister returns a set of experiments that the extension is interested in being notified about
-	ExperimentsToRegister() []string
-
-	// OnEvent is called whenever an event Registered with RegisterEvents is called
-	OnEvent(event event.Event, profile CwtchPeer)
-
-	// OnContactRequestValue is Hooked when a contact sends a request for the given path
-	OnContactRequestValue(profile CwtchPeer, conversation model.Conversation, eventID string, path attr.ScopedZonedPath)
-
-	// OnContactReceiveValue is Hooked after a profile receives a response to a Get/Val Request
-	OnContactReceiveValue(profile CwtchPeer, conversation model.Conversation, path attr.ScopedZonedPath, value string, exists bool)
-
-	// NotifySettingsUpdate allow profile hooks to access configs e.g. download folder
-	NotifySettingsUpdate(settings settings.GlobalSettings)
-}
-
-type ProfileHook struct {
-	extension   ProfileHooks
-	events      map[event.Type]bool
-	experiments map[string]bool
-}
-
-func ConstructHook(extension ProfileHooks) ProfileHook {
-	events := make(map[event.Type]bool)
-	for _, e := range extension.EventsToRegister() {
-		events[e] = true
-	}
-
-	experiments := make(map[string]bool)
-	for _, experiment := range extension.ExperimentsToRegister() {
-		experiments[experiment] = true
-	}
-
-	return ProfileHook{
-		extension,
-		events,
-		experiments,
-	}
-}

peer/profile_interface.go

@@ -5,7 +5,6 @@ import (
 	"cwtch.im/cwtch/model"
 	"cwtch.im/cwtch/model/attr"
 	"cwtch.im/cwtch/protocol/connections"
-	"cwtch.im/cwtch/settings"
 	"git.openprivacy.ca/cwtch.im/tapir/primitives/privacypass"
 	"git.openprivacy.ca/openprivacy/connectivity"
 )
@@ -20,9 +19,7 @@ type ModifyPeeringState interface {
 	BlockUnknownConnections()
 	AllowUnknownConnections()
 	PeerWithOnion(string)
-	QueueJoinServer(string)
-	DisconnectFromPeer(string)
-	DisconnectFromServer(string)
+	JoinServer(string) error
 }
 
 // ModifyContactsAndPeers is a meta-interface intended to restrict a call to reading and modifying contacts
@@ -51,15 +48,7 @@ type ModifyServers interface {
 // SendMessages enables a caller to sender messages to a contact
 type SendMessages interface {
 	SendMessage(conversation int, message string) (int, error)
-
-	// EnhancedSendMessage Attempts to Send a Message and Immediately Attempts to Lookup the Message in the Database
-	EnhancedSendMessage(conversation int, message string) string
-
 	SendInviteToConversation(conversationID int, inviteConversationID int) (int, error)
-
-	// EnhancedSendInviteMessage Attempts to Send an Invite and Immediately Attempts to Lookup the Message in the Database
-	EnhancedSendInviteMessage(conversation int, inviteConversationID int) string
-
 	SendScopedZonedGetValToContact(conversationID int, scope attr.Scope, zone attr.Zone, key string)
 }
 
@@ -71,7 +60,7 @@ type CwtchPeer interface {
 	// most functions
 	Init(event.Manager)
 
-	GenerateProtocolEngine(acn connectivity.ACN, bus event.Manager, engineHooks connections.EngineHooks) (connections.Engine, error)
+	GenerateProtocolEngine(acn connectivity.ACN, bus event.Manager) (connections.Engine, error)
 
 	AutoHandleEvents(events []event.Type)
 	Listen()
@@ -112,27 +101,15 @@ type CwtchPeer interface {
 
 	// Import Bundle
 	ImportBundle(string) error
-	EnhancedImportBundle(string) string
 
 	// New Unified Conversation Interfaces
 	NewContactConversation(handle string, acl model.AccessControl, accepted bool) (int, error)
 	FetchConversations() ([]*model.Conversation, error)
-	ArchiveConversation(conversation int)
 	GetConversationInfo(conversation int) (*model.Conversation, error)
 	FetchConversationInfo(handle string) (*model.Conversation, error)
-
-	// API-level management of conversation access control
-	UpdateConversationAccessControlList(id int, acl model.AccessControlList) error
-	EnhancedUpdateConversationAccessControlList(conversation int, acjson string) error
-
-	GetConversationAccessControlList(conversation int) (model.AccessControlList, error)
-	EnhancedGetConversationAccessControlList(conversation int) (string, error)
-
-	// Convieniance Functions for ACL Management
 	AcceptConversation(conversation int) error
 	BlockConversation(conversation int) error
 	UnblockConversation(conversation int) error
-
 	SetConversationAttribute(conversation int, path attr.ScopedZonedPath, value string) error
 	GetConversationAttribute(conversation int, path attr.ScopedZonedPath) (string, error)
 	DeleteConversation(conversation int) error
@@ -141,18 +118,14 @@ type CwtchPeer interface {
 	GetChannelMessage(conversation int, channel int, id int) (string, model.Attributes, error)
 	GetChannelMessageCount(conversation int, channel int) (int, error)
 	GetChannelMessageByContentHash(conversation int, channel int, contenthash string) (int, error)
-	GetMostRecentMessages(conversation int, channel int, offset int, limit uint) ([]model.ConversationMessage, error)
+	GetMostRecentMessages(conversation int, channel int, offset int, limit int) ([]model.ConversationMessage, error)
 	UpdateMessageAttribute(conversation int, channel int, id int, key string, value string) error
-	SearchConversations(pattern string) string
 
-	// EnhancedGetMessageById returns a json-encoded enhanced message, suitable for rendering in a UI
-	EnhancedGetMessageById(conversation int, mid int) string
-
-	// EnhancedGetMessageByContentHash returns a json-encoded enhanced message, suitable for rendering in a UI
-	EnhancedGetMessageByContentHash(conversation int, hash string) string
-
-	// EnhancedGetMessages returns a set of json-encoded enhanced messages, suitable for rendering in a UI
-	EnhancedGetMessages(conversation int, index int, count uint) string
+	// File Sharing APIS
+	// TODO move these to feature protected interfaces
+	ShareFile(fileKey string, serializedManifest string)
+	StopFileShare(fileKey string)
+	StopAllFileShares()
 
 	// Server Token APIS
 	// TODO move these to feature protected interfaces
@@ -161,21 +134,6 @@ type CwtchPeer interface {
 	// Profile Management
 	CheckPassword(password string) bool
 	ChangePassword(oldpassword string, newpassword string, newpasswordAgain string) error
-	ExportProfile(file string) error
+	Export(file string) error
 	Delete()
-	PublishEvent(resp event.Event)
-	RegisterHook(hook ProfileHooks)
-	UpdateExperiments(enabled bool, experiments map[string]bool)
-	NotifySettingsUpdate(settings settings.GlobalSettings)
-	IsFeatureEnabled(featureName string) bool
-}
-
-// EnhancedMessage wraps a Cwtch model.Message with some additional data to reduce calls from the UI.
-type EnhancedMessage struct {
-	model.Message
-	ID           int // the actual ID of the message in the database (not the row number)
-	LocalIndex   int // local index in the DB (row #). Can be empty (most calls supply it) but lookup by hash will fill it
-	ContentHash  string
-	ContactImage string
-	Attributes   map[string]string
 }

peer/storage.go

@@ -47,7 +47,7 @@ func createKey(password string, salt []byte) [32]byte {
 }
 
 func initV2Directory(directory, password string) ([32]byte, [128]byte, error) {
-	os.MkdirAll(directory, 0700)
+	os.Mkdir(directory, 0700)
 
 	key, salt, err := CreateKeySalt(password)
 	if err != nil {
@@ -155,7 +155,7 @@ func CreateEncryptedStore(profileDirectory string, password string) (*CwtchProfi
 
 // FromEncryptedDatabase constructs a Cwtch Profile from an existing Encrypted Database
 func FromEncryptedDatabase(profileDirectory string, password string) (CwtchPeer, error) {
-	log.Debugf("Loading Encrypted Profile: %v", profileDirectory)
+	log.Infof("Loading Encrypted Profile: %v", profileDirectory)
 	db, err := openEncryptedDatabase(profileDirectory, password, false)
 	if db == nil || err != nil {
 		return nil, fmt.Errorf("unable to open encrypted database: error: %v", err)
@@ -176,7 +176,7 @@ func ImportProfile(exportedCwtchFile string, profilesDir string, password string
 		log.Errorf("%s is an invalid cwtch backup file: %s", profileID, err)
 		return nil, err
 	}
-	log.Debugf("%s is a valid cwtch backup file", profileID)
+	log.Infof("%s is a valid cwtch backup file", profileID)
 
 	profileDBFile := filepath.Join(profilesDir, profileID, dbFile)
 	log.Debugf("checking %v", profileDBFile)

protocol/connections/engine.go

@@ -50,7 +50,7 @@ type engine struct {
 	authorizations sync.Map // string(onion) => model.Authorization
 
 	// Block Unknown Contacts
-	blockUnknownContacts atomic.Bool
+	blockUnknownContacts bool
 
 	// Pointer to the Global Event Manager
 	eventManager event.Manager
@@ -72,8 +72,7 @@ type engine struct {
 
 	tokenManagers sync.Map // [tokenService][]TokenManager
 
-	shuttingDown  atomic.Bool
-	onSendMessage func(connection tapir.Connection, message []byte) error
+	shuttingDown atomic.Bool
 }
 
 // Engine (ProtocolEngine) encapsulates the logic necessary to make and receive Cwtch connections.
@@ -87,16 +86,12 @@ type Engine interface {
 }
 
 // NewProtocolEngine initializes a new engine that runs Cwtch using the given parameters
-func NewProtocolEngine(identity primitives.Identity, privateKey ed25519.PrivateKey, acn connectivity.ACN, eventManager event.Manager, peerAuthorizations map[string]model.Authorization, engineHooks EngineHooks) Engine {
+func NewProtocolEngine(identity primitives.Identity, privateKey ed25519.PrivateKey, acn connectivity.ACN, eventManager event.Manager, peerAuthorizations map[string]model.Authorization) Engine {
 	engine := new(engine)
 	engine.identity = identity
 	engine.privateKey = privateKey
 	engine.ephemeralServices = make(map[string]*connectionLockedService)
 	engine.queue = event.NewQueue()
-
-	// the standard send message function
-	engine.onSendMessage = engineHooks.SendPeerMessage
-
 	go engine.eventHandler()
 
 	engine.acn = acn
@@ -110,6 +105,7 @@ func NewProtocolEngine(identity primitives.Identity, privateKey ed25519.PrivateK
 	engine.eventManager.Subscribe(event.ProtocolEngineStartListen, engine.queue)
 	engine.eventManager.Subscribe(event.ProtocolEngineShutdown, engine.queue)
 	engine.eventManager.Subscribe(event.PeerRequest, engine.queue)
+	engine.eventManager.Subscribe(event.RetryPeerRequest, engine.queue)
 	engine.eventManager.Subscribe(event.InvitePeerToGroup, engine.queue)
 	engine.eventManager.Subscribe(event.JoinServer, engine.queue)
 	engine.eventManager.Subscribe(event.LeaveServer, engine.queue)
@@ -122,8 +118,6 @@ func NewProtocolEngine(identity primitives.Identity, privateKey ed25519.PrivateK
 	engine.eventManager.Subscribe(event.UpdateConversationAuthorization, engine.queue)
 	engine.eventManager.Subscribe(event.BlockUnknownPeers, engine.queue)
 	engine.eventManager.Subscribe(event.AllowUnknownPeers, engine.queue)
-	engine.eventManager.Subscribe(event.DisconnectPeerRequest, engine.queue)
-	engine.eventManager.Subscribe(event.DisconnectServerRequest, engine.queue)
 
 	// File Handling
 	engine.eventManager.Subscribe(event.ShareManifest, engine.queue)
@@ -151,7 +145,6 @@ func (e *engine) EventManager() event.Manager {
 
 // eventHandler process events from other subsystems
 func (e *engine) eventHandler() {
-	log.Debugf("restartFlow Launching ProtocolEngine listener")
 	for {
 		ev := e.queue.Next()
 		// optimistic shutdown...
@@ -162,10 +155,16 @@ func (e *engine) eventHandler() {
 		case event.StatusRequest:
 			e.eventManager.Publish(event.Event{EventType: event.ProtocolEngineStatus, EventID: ev.EventID})
 		case event.PeerRequest:
-			log.Debugf("restartFlow Handling Peer Request")
 			if torProvider.IsValidHostname(ev.Data[event.RemotePeer]) {
 				go e.peerWithOnion(ev.Data[event.RemotePeer])
 			}
+		case event.RetryPeerRequest:
+			// This event allows engine to treat (automated) retry peering requests differently to user-specified
+			// peer events
+			if torProvider.IsValidHostname(ev.Data[event.RemotePeer]) {
+				log.Debugf("Retrying Peer Request: %v", ev.Data[event.RemotePeer])
+				go e.peerWithOnion(ev.Data[event.RemotePeer])
+			}
 		case event.InvitePeerToGroup:
 			err := e.sendPeerMessage(ev.Data[event.RemotePeer], pmodel.PeerMessage{ID: ev.EventID, Context: event.ContextInvite, Data: []byte(ev.Data[event.GroupInvite])})
 			if err != nil {
@@ -196,10 +195,6 @@ func (e *engine) eventHandler() {
 			// We remove this peer from out blocklist which will prevent them from contacting us if we have "block unknown peers" turned on.
 			e.authorizations.Delete(ev.Data[event.RemotePeer])
 			e.deleteConnection(onion)
-		case event.DisconnectPeerRequest:
-			e.deleteConnection(ev.Data[event.RemotePeer])
-		case event.DisconnectServerRequest:
-			e.leaveServer(ev.Data[event.GroupServer])
 		case event.SendMessageToGroup:
 			ciphertext, _ := base64.StdEncoding.DecodeString(ev.Data[event.Ciphertext])
 			signature, _ := base64.StdEncoding.DecodeString(ev.Data[event.Signature])
@@ -245,10 +240,10 @@ func (e *engine) eventHandler() {
 			}
 		case event.AllowUnknownPeers:
 			log.Debugf("%v now allows unknown connections", e.identity.Hostname())
-			e.blockUnknownContacts.Store(false)
+			e.blockUnknownContacts = false
 		case event.BlockUnknownPeers:
 			log.Debugf("%v now forbids unknown connections", e.identity.Hostname())
-			e.blockUnknownContacts.Store(true)
+			e.blockUnknownContacts = true
 		case event.ProtocolEngineStartListen:
 			go e.listenFn()
 		case event.ShareManifest:
@@ -270,21 +265,12 @@ func (e *engine) eventHandler() {
 			serializedManifest := ev.Data[event.SerializedManifest]
 			tempFile := ev.Data[event.TempFile]
 			title := ev.Data[event.NameSuggestion]
-
-			// Another optimistic check here. Technically Cwtch profile should not request manifest on a download files
-			// but if they do then we should check if it exists up front. If it does then announce that the download
-			// is complete.
-			if _, filePath, success := e.filesharingSubSystem.VerifyFile(key); success {
-				log.Debugf("file verified and downloaded!")
-				e.eventManager.Publish(event.NewEvent(event.FileDownloaded, map[event.Field]string{event.FileKey: key, event.FilePath: filePath, event.TempFile: tempFile}))
-			} else {
-				// NOTE: for now there will probably only ever be a single chunk request. When we enable group
-				// sharing and rehosting then this loop will serve as a a way of splitting the request among multiple
-				// contacts
-				for _, message := range e.filesharingSubSystem.CompileChunkRequests(key, serializedManifest, tempFile, title) {
-					if err := e.sendPeerMessage(handle, message); err != nil {
-						e.eventManager.Publish(event.NewEvent(event.SendMessageToPeerError, map[event.Field]string{event.RemotePeer: ev.Data[event.RemotePeer], event.EventID: ev.EventID, event.Error: err.Error()}))
-					}
+			// NOTE: for now there will probably only ever be a single chunk request. When we enable group
+			// sharing and rehosting then this loop will serve as a a way of splitting the request among multiple
+			// contacts
+			for _, message := range e.filesharingSubSystem.CompileChunkRequests(key, serializedManifest, tempFile, title) {
+				if err := e.sendPeerMessage(handle, message); err != nil {
+					e.eventManager.Publish(event.NewEvent(event.SendMessageToPeerError, map[event.Field]string{event.RemotePeer: ev.Data[event.RemotePeer], event.EventID: ev.EventID, event.Error: err.Error()}))
 				}
 			}
 		case event.ProtocolEngineShutdown:
@@ -299,7 +285,7 @@ func (e *engine) isBlocked(onion string) bool {
 	authorization, known := e.authorizations.Load(onion)
 	if !known {
 		// if we block unknown peers we will block this contact
-		return e.blockUnknownContacts.Load()
+		return e.blockUnknownContacts
 	}
 	return authorization.(model.Authorization) == model.AuthBlocked
 }
@@ -310,7 +296,7 @@ func (e *engine) isAllowed(onion string) bool {
 		log.Errorf("attempted to lookup authorization of onion not in map...that should never happen")
 		return false
 	}
-	if e.blockUnknownContacts.Load() {
+	if e.blockUnknownContacts {
 		return authorization.(model.Authorization) == model.AuthApproved
 	}
 	return authorization.(model.Authorization) != model.AuthBlocked
@@ -325,7 +311,6 @@ func (e *engine) createPeerTemplate() *PeerApp {
 	peerAppTemplate.OnAuth = e.ignoreOnShutdown(e.peerAuthed)
 	peerAppTemplate.OnConnecting = e.ignoreOnShutdown(e.peerConnecting)
 	peerAppTemplate.OnClose = e.ignoreOnShutdown(e.peerDisconnected)
-	peerAppTemplate.OnSendMessage = e.onSendMessage
 	return peerAppTemplate
 }
 
@@ -341,23 +326,19 @@ func (e *engine) listenFn() {
 func (e *engine) Shutdown() {
 	// don't accept any more events...
 	e.queue.Publish(event.NewEvent(event.ProtocolEngineShutdown, map[event.Field]string{}))
-	e.eventManager.Publish(event.NewEvent(event.ProtocolEngineShutdown, map[event.Field]string{}))
 	e.service.Shutdown()
+
 	e.shuttingDown.Store(true)
+
 	e.ephemeralServicesLock.Lock()
 	defer e.ephemeralServicesLock.Unlock()
 	for _, connection := range e.ephemeralServices {
 		log.Infof("shutting down ephemeral service")
-		// work around: service.shutdown() can block for a long time if it is Open()ing a new connection, putting it in a
-		//   goroutine means we can perform this operation and let the per service shutdown in their own time or until the app exits
-		conn := connection // don't capture loop variable
-		go func() {
-			conn.connectingLock.Lock()
-			conn.service.Shutdown()
-			conn.connectingLock.Unlock()
-
-		}()
+		connection.connectingLock.Lock()
+		connection.service.Shutdown()
+		connection.connectingLock.Unlock()
 	}
+
 	e.queue.Shutdown()
 }
 
@@ -368,31 +349,24 @@ func (e *engine) peerWithOnion(onion string) {
 	if !e.isBlocked(onion) {
 		e.ignoreOnShutdown(e.peerConnecting)(onion)
 		connected, err := e.service.Connect(onion, e.createPeerTemplate())
-		if connected && err == nil {
-			// on success CwtchPeer will handle Auth and other status updates
-			// early exit from this function...
-			return
-		}
+
 		// If we are already connected...check if we are authed and issue an auth event
 		// (This allows the ui to be stateless)
 		if connected && err != nil {
-			conn, err := e.service.WaitForCapabilityOrClose(onion, cwtchCapability)
+			conn, err := e.service.GetConnection(onion)
 			if err == nil {
 				if conn.HasCapability(cwtchCapability) {
 					e.ignoreOnShutdown(e.peerAuthed)(onion)
 					return
 				}
-				log.Errorf("PeerWithOnion something went very wrong...%v %v", onion, err)
-				if conn != nil {
-					conn.Close()
-				}
-				e.ignoreOnShutdown(e.peerDisconnected)(onion)
-			} else {
-				e.ignoreOnShutdown(e.peerDisconnected)(onion)
 			}
 		}
+
+		// Only issue a disconnected error if we are disconnected (Connect will fail if a connection already exists)
+		if !connected && err != nil {
+			e.ignoreOnShutdown(e.peerDisconnected)(onion)
+		}
 	}
-	e.ignoreOnShutdown(e.peerDisconnected)(onion)
 }
 
 func (e *engine) makeAntispamPayment(onion string) {
@@ -406,10 +380,6 @@ func (e *engine) makeAntispamPayment(onion string) {
 		return
 	}
 
-	// Before doing anything, send and event with the current number of token
-	// This may unblock downstream processes who don't have an accurate token count
-	e.PokeTokenCount(onion)
-
 	conn, err := ephemeralService.service.GetConnection(onion)
 	if err == nil {
 		tokenApp, ok := (conn.App()).(*TokenBoardClient)
@@ -470,10 +440,6 @@ func (e *engine) peerWithTokenServer(onion string, tokenServerOnion string, toke
 				e.ignoreOnShutdown(e.serverAuthed)(onion)
 				return
 			}
-
-			// if we are not authed or synced then we are stuck...
-			e.ignoreOnShutdown(e.serverConnecting)(onion)
-			log.Errorf("server connection attempt issued to active connection")
 		}
 	}
 
@@ -749,16 +715,6 @@ func (e *engine) handlePeerMessage(hostname string, eventID string, context stri
 		// Fall through handler for the default text conversation.
 		e.eventManager.Publish(event.NewEvent(event.NewMessageFromPeerEngine, map[event.Field]string{event.TimestampReceived: time.Now().Format(time.RFC3339Nano), event.RemotePeer: hostname, event.Data: string(message)}))
 
-		// Don't ack messages in channel 7
-		// Note: this code explictly doesn't care about malformed messages, we deal with them
-		// later on...we still want to ack the original send...(as some "malformed" messages
-		// may be future-ok)
-		if cm, err := model.DeserializeMessage(string(message)); err == nil {
-			if cm.IsStream() {
-				return
-			}
-		}
-
 		// Send an explicit acknowledgement
 		// Every other protocol should have an explicit acknowledgement message e.g. value lookups have responses, and file handling has an explicit flow
 		if err := e.sendPeerMessage(hostname, pmodel.PeerMessage{ID: eventID, Context: event.ContextAck, Data: []byte{}}); err != nil {

protocol/connections/engine_token_handler.go

@@ -51,9 +51,3 @@ func (e *engine) FetchToken(tokenService string) (*privacypass.Token, int, error
 	e.eventManager.Publish(event.NewEvent(event.TokenManagerInfo, map[event.Field]string{event.ServerTokenOnion: tokenService, event.ServerTokenCount: strconv.Itoa(numTokens)}))
 	return token, numTokens, err
 }
-
-func (e *engine) PokeTokenCount(tokenService string) {
-	tokenManagerPointer, _ := e.tokenManagers.LoadOrStore(tokenService, NewTokenManager())
-	tokenManager := tokenManagerPointer.(*TokenManager)
-	e.eventManager.Publish(event.NewEvent(event.TokenManagerInfo, map[event.Field]string{event.ServerTokenOnion: tokenService, event.ServerTokenCount: strconv.Itoa(tokenManager.NumTokens())}))
-}

protocol/connections/enginehooks.go

@@ -1,14 +0,0 @@
-package connections
-
-import "git.openprivacy.ca/cwtch.im/tapir"
-
-type EngineHooks interface {
-	SendPeerMessage(connection tapir.Connection, message []byte) error
-}
-
-type DefaultEngineHooks struct {
-}
-
-func (deh DefaultEngineHooks) SendPeerMessage(connection tapir.Connection, message []byte) error {
-	return connection.Send(message)
-}

protocol/connections/peerapp.go

@@ -2,14 +2,12 @@ package connections
 
 import (
 	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model"
 	model2 "cwtch.im/cwtch/protocol/model"
 	"encoding/json"
 	"git.openprivacy.ca/cwtch.im/tapir"
 	"git.openprivacy.ca/cwtch.im/tapir/applications"
 	"git.openprivacy.ca/openprivacy/log"
 	"sync/atomic"
-	"time"
 )
 
 const cwtchCapability = tapir.Capability("cwtchCapability")
@@ -25,7 +23,6 @@ type PeerApp struct {
 	OnAuth            func(string)
 	OnClose           func(string)
 	OnConnecting      func(string)
-	OnSendMessage     func(connection tapir.Connection, message []byte) error
 	version           atomic.Value
 }
 
@@ -51,7 +48,6 @@ func (pa *PeerApp) NewInstance() tapir.Application {
 	newApp.OnAuth = pa.OnAuth
 	newApp.OnClose = pa.OnClose
 	newApp.OnConnecting = pa.OnConnecting
-	newApp.OnSendMessage = pa.OnSendMessage
 	newApp.version.Store(Version1)
 	return newApp
 }
@@ -79,7 +75,7 @@ func (pa *PeerApp) Init(connection tapir.Connection) {
 			// version *must* be the first message sent to prevent race conditions for other events fired after-auth
 			// (e.g. getVal requests)
 			// as such, we send this message before we update the rest of the system
-			_ = pa.SendMessage(model2.PeerMessage{
+			pa.SendMessage(model2.PeerMessage{
 				ID:      event.ContextVersion,
 				Context: event.ContextGetVal,
 				Data:    []byte{Version2},
@@ -135,15 +131,7 @@ func (pa *PeerApp) listen() {
 						pa.version.Store(Version2)
 					}
 				} else {
-					if cm, err := model.DeserializeMessage(string(packet.Data)); err == nil {
-						if cm.TransitTime != nil {
-							rt := time.Now().UTC()
-							cm.RecvTime = &rt
-							data, _ := json.Marshal(cm)
-							packet.Data = data
-						}
-					}
-					pa.MessageHandler(pa.connection.Hostname(), packet.ID, packet.Context, packet.Data)
+					pa.MessageHandler(pa.connection.Hostname(), packet.ID, packet.Context, []byte(packet.Data))
 				}
 			}
 		} else {
@@ -158,15 +146,6 @@ func (pa *PeerApp) SendMessage(message model2.PeerMessage) error {
 	var serialized []byte
 	var err error
 
-	if cm, err := model.DeserializeMessage(string(message.Data)); err == nil {
-		if cm.SendTime != nil {
-			tt := time.Now().UTC()
-			cm.TransitTime = &tt
-			data, _ := json.Marshal(cm)
-			message.Data = data
-		}
-	}
-
 	if pa.version.Load() == Version2 {
 		// treat data as a pre-serialized string, not as a byte array (which will be base64 encoded and bloat the packet size)
 		serialized = message.Serialize()
@@ -175,7 +154,7 @@ func (pa *PeerApp) SendMessage(message model2.PeerMessage) error {
 	}
 
 	if err == nil {
-		err = pa.OnSendMessage(pa.connection, serialized)
+		err = pa.connection.Send(serialized)
 
 		// at this point we have tried to send a message to a peer only to find that something went wrong.
 		// we don't know *what* went wrong - the most likely explanation is the peer went offline in the time between

protocol/files/chunkspec.go

@@ -13,7 +13,7 @@ type ChunkSpec []uint64
 // CreateChunkSpec given a full list of chunks with their downloaded status (true for downloaded, false otherwise)
 // derives a list of identifiers of chunks that have not been downloaded yet
 func CreateChunkSpec(progress []bool) ChunkSpec {
-	chunks := ChunkSpec{}
+	var chunks ChunkSpec
 	for i, p := range progress {
 		if !p {
 			chunks = append(chunks, uint64(i))

protocol/files/filesharing_subsystem.go

@@ -34,7 +34,6 @@ func (fsss *FileSharingSubSystem) ShareFile(fileKey string, serializedManifest s
 		log.Errorf("could not share file %v", err)
 		return
 	}
-	log.Debugf("sharing file: %v %v", fileKey, serializedManifest)
 	fsss.activeShares.Store(fileKey, &manifest)
 }
 

protocol/files/manifest.go

@@ -8,7 +8,6 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"git.openprivacy.ca/openprivacy/log"
 	"io"
 	"os"
 	"sync"
@@ -232,15 +231,12 @@ func (m *Manifest) GetChunkRequest() ChunkSpec {
 }
 
 // PrepareDownload creates an empty file of the expected size of the file described by the manifest
-// If the file already exists it assumes it is the correct file and that it is resuming from when it left off.
+// If the file already exists it assume it is the correct file and that it is resuming from when it left off.
 func (m *Manifest) PrepareDownload() error {
 	m.lock.Lock()
 	defer m.lock.Unlock()
 
 	m.chunkComplete = make([]bool, len(m.Chunks))
-	if m.ChunkSizeInBytes == 0 || m.FileSizeInBytes == 0 {
-		return fmt.Errorf("manifest is invalid")
-	}
 
 	if info, err := os.Stat(m.FileName); os.IsNotExist(err) {
 		useFileName := m.FileName
@@ -297,12 +293,6 @@ func (m *Manifest) PrepareDownload() error {
 				}
 				break
 			}
-
-			if chunkI >= len(m.Chunks) {
-				log.Errorf("file is larger than the number of chunks assigned. Assuming manifest was corrupted.")
-				return fmt.Errorf("file is larger than the number of chunks assigned. Assuming manifest was corrupted")
-			}
-
 			hash := sha512.New()
 			hash.Write(buf[0:n])
 			chunkHash := hash.Sum(nil)

protocol/files/manifest_test.go

@@ -93,12 +93,7 @@ func TestManifestLarge(t *testing.T) {
 	}
 
 	// Prepare Download
-	cwtchPngOutManifest, err := LoadManifest("testdata/cwtch.png.manifest")
-
-	if err != nil {
-		t.Fatalf("could not prepare download %v", err)
-	}
-
+	cwtchPngOutManifest, _ := LoadManifest("testdata/cwtch.png.manifest")
 	cwtchPngOutManifest.FileName = "testdata/cwtch.out.png"
 
 	defer cwtchPngOutManifest.Close()

settings/settings.go

@@ -1,160 +0,0 @@
-package settings
-
-import (
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/storage/v1"
-	"encoding/json"
-	"git.openprivacy.ca/openprivacy/log"
-	"os"
-	path "path/filepath"
-)
-
-const (
-	CwtchStarted         = event.Type("CwtchStarted")
-	CwtchStartError      = event.Type("CwtchStartError")
-	UpdateGlobalSettings = event.Type("UpdateGlobalSettings")
-)
-
-const GlobalSettingsFilename = "ui.globals"
-const saltFile = "SALT"
-
-type NotificationPolicy string
-
-const (
-	NotificationPolicyMute       = NotificationPolicy("NotificationPolicy.Mute")
-	NotificationPolicyOptIn      = NotificationPolicy("NotificationPolicy.OptIn")
-	NotificationPolicyDefaultAll = NotificationPolicy("NotificationPolicy.DefaultAll")
-)
-
-type GlobalSettingsFile struct {
-	v1.FileStore
-}
-
-type GlobalSettings struct {
-	Locale                  string
-	Theme                   string
-	ThemeMode               string
-	ThemeImages             bool
-	PreviousPid             int64
-	ExperimentsEnabled      bool
-	Experiments             map[string]bool
-	BlockUnknownConnections bool
-	NotificationPolicy      NotificationPolicy
-	NotificationContent     string
-	StreamerMode            bool
-	StateRootPane           int
-	FirstTime               bool
-	UIColumnModePortrait    string
-	UIColumnModeLandscape   string
-	DownloadPath            string
-	AllowAdvancedTorConfig  bool
-	CustomTorrc             string
-	UseCustomTorrc          bool
-	UseExternalTor          bool
-	CustomSocksPort         int
-	CustomControlPort       int
-	UseTorCache             bool
-	TorCacheDir             string
-	BlodeuweddPath          string
-	FontScaling             float64
-	DefaultSaveHistory      bool
-}
-
-var DefaultGlobalSettings = GlobalSettings{
-	Locale:                  "en",
-	Theme:                   "cwtch",
-	ThemeMode:               "dark",
-	ThemeImages:             false,
-	PreviousPid:             -1,
-	ExperimentsEnabled:      false,
-	Experiments:             map[string]bool{constants.MessageFormattingExperiment: true},
-	StateRootPane:           0,
-	FirstTime:               true,
-	BlockUnknownConnections: false,
-	StreamerMode:            false,
-	UIColumnModePortrait:    "DualpaneMode.Single",
-	UIColumnModeLandscape:   "DualpaneMode.CopyPortrait",
-	NotificationPolicy:      "NotificationPolicy.Mute",
-	NotificationContent:     "NotificationContent.SimpleEvent",
-	DownloadPath:            "",
-	AllowAdvancedTorConfig:  false,
-	CustomTorrc:             "",
-	UseCustomTorrc:          false,
-	CustomSocksPort:         -1,
-	CustomControlPort:       -1,
-	UseTorCache:             false,
-	TorCacheDir:             "",
-	BlodeuweddPath:          "",
-	FontScaling:             1.0, // use the system pixel scaling default
-	DefaultSaveHistory:      false,
-}
-
-func InitGlobalSettingsFile(directory string, password string) (*GlobalSettingsFile, error) {
-	var key [32]byte
-	salt, err := os.ReadFile(path.Join(directory, saltFile))
-	if err != nil {
-		log.Infof("Could not find salt file: %v (creating a new settings file)", err)
-		var newSalt [128]byte
-		key, newSalt, err = v1.CreateKeySalt(password)
-		if err != nil {
-			log.Errorf("Could not initialize salt: %v", err)
-			return nil, err
-		}
-		err := os.MkdirAll(directory, 0700)
-		if err != nil {
-			return nil, err
-		}
-		err = os.WriteFile(path.Join(directory, saltFile), newSalt[:], 0600)
-		if err != nil {
-			log.Errorf("Could not write salt file: %v", err)
-			return nil, err
-		}
-	} else {
-		key = v1.CreateKey(password, salt)
-	}
-
-	gsFile := v1.NewFileStore(directory, GlobalSettingsFilename, key)
-	log.Infof("initialized global settings file: %v", gsFile)
-	globalSettingsFile := GlobalSettingsFile{
-		gsFile,
-	}
-	return &globalSettingsFile, nil
-}
-
-func (globalSettingsFile *GlobalSettingsFile) ReadGlobalSettings() GlobalSettings {
-	settings := DefaultGlobalSettings
-
-	if globalSettingsFile == nil {
-		log.Errorf("Global Settings File was not Initialized Properly")
-		return settings
-	}
-
-	settingsBytes, err := globalSettingsFile.Read()
-	if err != nil {
-		log.Infof("Could not read global ui settings: %v (assuming this is a first time app deployment...)", err)
-		return settings //firstTime = true
-	}
-
-	// note: by giving json.Unmarshal settings we are providing it defacto defaults
-	// from DefaultGlobalSettings
-	err = json.Unmarshal(settingsBytes, &settings)
-	if err != nil {
-		log.Errorf("Could not parse global ui settings: %v\n", err)
-		// TODO if settings is corrupted, we probably want to alert the UI.
-		return settings //firstTime = true
-	}
-
-	log.Debugf("Settings: %#v", settings)
-	return settings
-}
-
-func (globalSettingsFile *GlobalSettingsFile) WriteGlobalSettings(globalSettings GlobalSettings) {
-	bytes, _ := json.Marshal(globalSettings)
-	// override first time setting
-	globalSettings.FirstTime = true
-	err := globalSettingsFile.Write(bytes)
-	if err != nil {
-		log.Errorf("Could not write global ui settings: %v\n", err)
-	}
-}

storage/v1/profile_store.go

@@ -67,23 +67,19 @@ func (ps *ProfileStoreV1) load() error {
 
 			if contact.Attributes[event.SaveHistoryKey] == event.SaveHistoryConfirmed {
 				ss := NewStreamStore(ps.directory, contact.LocalID, ps.key)
-				if contact, exists := cp.Contacts[contact.Onion]; exists {
-					contact.Timeline.SetMessages(ss.Read())
-				}
+				cp.Contacts[contact.Onion].Timeline.SetMessages(ss.Read())
 			}
 		}
 
 		for gid, group := range cp.Groups {
 			if group.Version == 0 {
-				log.Debugf("group %v is of unsupported version 0. dropping group...\n", group.GroupID)
+				log.Infof("group %v is of unsupported version 0. dropping group...\n", group.GroupID)
 				delete(cp.Groups, gid)
 				continue
 			}
 			ss := NewStreamStore(ps.directory, group.LocalID, ps.key)
-			if group, exists := cp.Groups[gid]; exists {
-				group.Timeline.SetMessages(ss.Read())
-				group.Timeline.Sort()
-			}
+			cp.Groups[gid].Timeline.SetMessages(ss.Read())
+			cp.Groups[gid].Timeline.Sort()
 		}
 	}
 

storage/v1/stream_store.go

@@ -152,7 +152,7 @@ func (ss *streamStore) WriteN(messages []model.Message) {
 	ss.lock.Lock()
 	defer ss.lock.Unlock()
 
-	log.Debugf("WriteN %v messages\n", len(messages))
+	log.Infof("WriteN %v messages\n", len(messages))
 	i := 0
 	for _, m := range messages {
 		ss.updateBuffer(m)

testing/autodownload/file_sharing_integration_test.go

@@ -1,201 +0,0 @@
-package filesharing
-
-import (
-	"crypto/rand"
-	app2 "cwtch.im/cwtch/app"
-	"cwtch.im/cwtch/event"
-	"cwtch.im/cwtch/functionality/filesharing"
-	"cwtch.im/cwtch/model"
-	"cwtch.im/cwtch/model/attr"
-	"cwtch.im/cwtch/model/constants"
-	"cwtch.im/cwtch/peer"
-	"cwtch.im/cwtch/protocol/connections"
-	"encoding/base64"
-	"errors"
-	"fmt"
-	"git.openprivacy.ca/openprivacy/connectivity/tor"
-	"git.openprivacy.ca/openprivacy/log"
-	"path/filepath"
-
-	// Import SQL Cipher
-	mrand "math/rand"
-	"os"
-	"os/user"
-	"path"
-	"runtime"
-	"runtime/pprof"
-	"testing"
-	"time"
-
-	_ "github.com/mutecomm/go-sqlcipher/v4"
-)
-
-func waitForPeerPeerConnection(t *testing.T, peera peer.CwtchPeer, peerb peer.CwtchPeer) {
-	for {
-		state := peera.GetPeerState(peerb.GetOnion())
-		if state == connections.FAILED {
-			t.Fatalf("%v could not connect to %v", peera.GetOnion(), peerb.GetOnion())
-		}
-		if state != connections.AUTHENTICATED {
-			fmt.Printf("peer %v waiting connect to peer %v, currently: %v\n", peera.GetOnion(), peerb.GetOnion(), connections.ConnectionStateName[state])
-			time.Sleep(time.Second * 5)
-			continue
-		} else {
-			peerAName, _ := peera.GetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name)
-			peerBName, _ := peerb.GetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name)
-			fmt.Printf("%v CONNECTED and AUTHED to %v\n", peerAName, peerBName)
-			break
-		}
-	}
-}
-
-func TestFileSharing(t *testing.T) {
-	numGoRoutinesStart := runtime.NumGoroutine()
-	os.RemoveAll("cwtch.out.png")
-	os.RemoveAll("cwtch.out.png.manifest")
-	os.RemoveAll("storage")
-	os.RemoveAll("tordir")
-	os.RemoveAll("./download_dir")
-
-	log.SetLevel(log.LevelInfo)
-
-	os.Mkdir("tordir", 0700)
-	dataDir := path.Join("tordir", "tor")
-	os.MkdirAll(dataDir, 0700)
-
-	// we don't need real randomness for the port, just to avoid a possible conflict...
-	socksPort := mrand.Intn(1000) + 9051
-	controlPort := mrand.Intn(1000) + 9052
-
-	// generate a random password
-	key := make([]byte, 64)
-	_, err := rand.Read(key)
-	if err != nil {
-		panic(err)
-	}
-
-	useCache := os.Getenv("TORCACHE") == "true"
-
-	torDataDir := ""
-	if useCache {
-		log.Infof("using tor cache")
-		torDataDir = filepath.Join(dataDir, "data-dir-torcache")
-		os.MkdirAll(torDataDir, 0700)
-	} else {
-		log.Infof("using clean tor data dir")
-		if torDataDir, err = os.MkdirTemp(dataDir, "data-dir-"); err != nil {
-			t.Fatalf("could not create data dir")
-		}
-	}
-
-	tor.NewTorrc().WithSocksPort(socksPort).WithOnionTrafficOnly().WithHashedPassword(base64.StdEncoding.EncodeToString(key)).WithControlPort(controlPort).Build("tordir/tor/torrc")
-	acn, err := tor.NewTorACNWithAuth("./tordir", path.Join("..", "tor"), torDataDir, controlPort, tor.HashedPasswordAuthenticator{Password: base64.StdEncoding.EncodeToString(key)})
-	if err != nil {
-		t.Fatalf("Could not start Tor: %v", err)
-	}
-	acn.WaitTillBootstrapped()
-	defer acn.Close()
-
-	app := app2.NewApp(acn, "./storage", app2.LoadAppSettings("./storage"))
-
-	usr, err := user.Current()
-	if err != nil {
-		t.Fatalf("current user is undefined")
-	}
-	cwtchDir := path.Join(usr.HomeDir, ".cwtch")
-	os.Mkdir(cwtchDir, 0700)
-	os.RemoveAll(path.Join(cwtchDir, "testing"))
-	os.Mkdir(path.Join(cwtchDir, "testing"), 0700)
-
-	t.Logf("Creating Alice...")
-	app.CreateProfile("alice", "asdfasdf", true)
-
-	t.Logf("Creating Bob...")
-	app.CreateProfile("bob", "asdfasdf", true)
-
-	t.Logf("** Waiting for Alice, Bob...")
-	alice := app2.WaitGetPeer(app, "alice")
-	app.ActivatePeerEngine(alice.GetOnion())
-	app.ConfigureConnections(alice.GetOnion(), true, true, true)
-	bob := app2.WaitGetPeer(app, "bob")
-	app.ActivatePeerEngine(bob.GetOnion())
-	app.ConfigureConnections(bob.GetOnion(), true, true, true)
-
-	alice.AutoHandleEvents([]event.Type{event.PeerStateChange, event.NewRetValMessageFromPeer})
-	bob.AutoHandleEvents([]event.Type{event.PeerStateChange, event.NewRetValMessageFromPeer})
-
-	// Turn on File Sharing Experiment...
-	settings := app.ReadSettings()
-	settings.ExperimentsEnabled = true
-	settings.DownloadPath = "./download_dir"
-	os.RemoveAll(path.Join(settings.DownloadPath, "cwtch.png"))
-	os.RemoveAll(path.Join(settings.DownloadPath, "cwtch.png.manifest"))
-	os.MkdirAll(settings.DownloadPath, 0700)
-	settings.Experiments[constants.FileSharingExperiment] = true
-	// Turn Auto Downloading On... (Part of the Image Previews / Profile Images Experiment)
-	settings.Experiments[constants.ImagePreviewsExperiment] = true
-	app.UpdateSettings(settings)
-
-	t.Logf("** Launching Peers...")
-	waitTime := time.Duration(30) * time.Second
-	t.Logf("** Waiting for Alice, Bob  to connect with onion network... (%v)\n", waitTime)
-	time.Sleep(waitTime)
-
-	bob.NewContactConversation(alice.GetOnion(), model.DefaultP2PAccessControl(), true)
-	alice.NewContactConversation(bob.GetOnion(), model.DefaultP2PAccessControl(), true)
-	alice.PeerWithOnion(bob.GetOnion())
-
-	json, err := alice.EnhancedGetConversationAccessControlList(1)
-	if err != nil {
-		t.Fatalf("Error!: %v", err)
-	}
-	t.Logf("alice<->bob ACL: %s", json)
-
-	t.Logf("Waiting for alice and Bob to peer...")
-	waitForPeerPeerConnection(t, alice, bob)
-	err = alice.AcceptConversation(1)
-	if err != nil {
-		t.Fatalf("Error!: %v", err)
-	}
-	err = bob.AcceptConversation(1)
-	if err != nil {
-		t.Fatalf("Error!: %v", err)
-	}
-
-	t.Logf("Alice and Bob are Connected!!")
-
-	filesharingFunctionality := filesharing.FunctionalityGate()
-
-	_, fileSharingMessage, err := filesharingFunctionality.ShareFile("cwtch.png", alice)
-	alice.SendMessage(1, fileSharingMessage)
-
-	if err != nil {
-		t.Fatalf("Error!: %v", err)
-	}
-
-	// test that bob can download and verify the file
-	// The main difference here is that bob doesn't need to do anything...
-	// testBobDownloadFile(t, bob, filesharingFunctionality, queueOracle)
-
-	// Wait for say...
-	time.Sleep(10 * time.Second)
-
-	if _, err := os.Stat(path.Join(settings.DownloadPath, "cwtch.png")); errors.Is(err, os.ErrNotExist) {
-		// path/to/whatever does not exist
-		t.Fatalf("cwtch.png should have been automatically downloaded...")
-	}
-
-	app.Shutdown()
-	acn.Close()
-	time.Sleep(20 * time.Second)
-	numGoRoutinesPostACN := runtime.NumGoroutine()
-
-	// Printing out the current goroutines
-	// Very useful if we are leaking any.
-	pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
-
-	if numGoRoutinesStart != numGoRoutinesPostACN {
-		t.Errorf("Number of GoRoutines at start (%v) does not match number of goRoutines after cleanup of peers and servers (%v), clean up failed, leak detected!", numGoRoutinesStart, numGoRoutinesPostACN)
-	}
-
-}

testing/cwtch_peer_server_integration_test.go

@@ -99,6 +99,7 @@ func TestCwtchPeerIntegration(t *testing.T) {
 	os.MkdirAll(dataDir, 0700)
 
 	// we don't need real randomness for the port, just to avoid a possible conflict...
+	mrand.Seed(int64(time.Now().Nanosecond()))
 	socksPort := mrand.Intn(1000) + 9051
 	controlPort := mrand.Intn(1000) + 9052
 
@@ -138,7 +139,7 @@ func TestCwtchPeerIntegration(t *testing.T) {
 	const ServerAddr = "nfhxzvzxinripgdh4t2m4xcy3crf6p4cbhectgckuj3idsjsaotgowad"
 	serverKeyBundle, _ := base64.StdEncoding.DecodeString(ServerKeyBundleBase64)
 
-	app := app2.NewApp(acn, "./storage", app2.LoadAppSettings("./storage"))
+	app := app2.NewApp(acn, "./storage")
 
 	usr, _ := user.Current()
 	cwtchDir := path.Join(usr.HomeDir, ".cwtch")
@@ -149,43 +150,35 @@ func TestCwtchPeerIntegration(t *testing.T) {
 	numGoRoutinesPostAppStart := runtime.NumGoroutine()
 
 	// ***** cwtchPeer setup *****
-	// Turn on Groups Experiment...
-	settings := app.ReadSettings()
-	settings.ExperimentsEnabled = true
-	settings.Experiments[constants.GroupsExperiment] = true
-	app.UpdateSettings(settings)
 
 	log.Infoln("Creating Alice...")
-	app.CreateProfile("Alice", "asdfasdf", true)
+	app.CreateTaggedPeer("Alice", "asdfasdf", "test")
 
 	log.Infoln("Creating Bob...")
-	app.CreateProfile("Bob", "asdfasdf", true)
+	app.CreateTaggedPeer("Bob", "asdfasdf", "test")
 
 	log.Infoln("Creating Carol...")
-	app.CreateProfile("Carol", "asdfasdf", true)
+	app.CreateTaggedPeer("Carol", "asdfasdf", "test")
 
 	alice := app2.WaitGetPeer(app, "Alice")
 	aliceBus := app.GetEventBus(alice.GetOnion())
-	app.ActivatePeerEngine(alice.GetOnion())
-	app.ConfigureConnections(alice.GetOnion(), true, true, true)
+	app.ActivatePeerEngine(alice.GetOnion(), true, true, true)
 	log.Infoln("Alice created:", alice.GetOnion())
-	// alice.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Alice") <- This is now done automatically by ProfileValueExtension, keeping this here for clarity
+	alice.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Alice")
 	alice.AutoHandleEvents([]event.Type{event.PeerStateChange, event.ServerStateChange, event.NewGroupInvite, event.NewRetValMessageFromPeer})
 
 	bob := app2.WaitGetPeer(app, "Bob")
 	bobBus := app.GetEventBus(bob.GetOnion())
-	app.ActivatePeerEngine(bob.GetOnion())
-	app.ConfigureConnections(bob.GetOnion(), true, true, true)
+	app.ActivatePeerEngine(bob.GetOnion(), true, true, true)
 	log.Infoln("Bob created:", bob.GetOnion())
-	// bob.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Bob")  <- This is now done automatically by ProfileValueExtension, keeping this here for clarity
+	bob.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Bob")
 	bob.AutoHandleEvents([]event.Type{event.PeerStateChange, event.ServerStateChange, event.NewGroupInvite, event.NewRetValMessageFromPeer})
 
 	carol := app2.WaitGetPeer(app, "Carol")
 	carolBus := app.GetEventBus(carol.GetOnion())
-	app.ActivatePeerEngine(carol.GetOnion())
-	app.ConfigureConnections(carol.GetOnion(), true, true, true)
+	app.ActivatePeerEngine(carol.GetOnion(), true, true, true)
 	log.Infoln("Carol created:", carol.GetOnion())
-	// carol.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Carol")  <- This is now done automatically by ProfileValueExtension, keeping this here for clarity
+	carol.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, "Carol")
 	carol.AutoHandleEvents([]event.Type{event.PeerStateChange, event.ServerStateChange, event.NewGroupInvite, event.NewRetValMessageFromPeer})
 
 	waitTime := time.Duration(60) * time.Second
@@ -390,10 +383,6 @@ func TestCwtchPeerIntegration(t *testing.T) {
 	checkMessage(t, carol, carolGroupConversationID, 5, carolLines[0])
 	checkMessage(t, carol, carolGroupConversationID, 6, bobLines[2])
 
-	// Have bob clean up some conversations...
-	log.Infof("Bob cleanup conversation")
-	bob.DeleteConversation(1)
-
 	log.Infof("Shutting down Bob...")
 	app.ShutdownPeer(bob.GetOnion())
 	time.Sleep(time.Second * 3)
@@ -414,7 +403,7 @@ func TestCwtchPeerIntegration(t *testing.T) {
 
 	log.Infof("Shutting down ACN...")
 	acn.Close()
-	time.Sleep(time.Second * 60) // the network status / heartbeat plugin might keep goroutines alive for a minute before killing them
+	time.Sleep(time.Second * 30) // the network status plugin might keep goroutines alive for a minute before killing them
 
 	numGoRoutinesPostAppShutdown := runtime.NumGoroutine()
 

testing/encryptedstorage/encrypted_storage_integration_test.go

@@ -29,6 +29,7 @@ func TestEncryptedStorage(t *testing.T) {
 	os.MkdirAll(dataDir, 0700)
 
 	// we don't need real randomness for the port, just to avoid a possible conflict...
+	mrand.Seed(int64(time.Now().Nanosecond()))
 	socksPort := mrand.Intn(1000) + 9051
 	controlPort := mrand.Intn(1000) + 9052
 
@@ -58,9 +59,9 @@ func TestEncryptedStorage(t *testing.T) {
 
 	defer acn.Close()
 	acn.WaitTillBootstrapped()
-	app := app2.NewApp(acn, cwtchDir, app2.LoadAppSettings(cwtchDir))
-	app.CreateProfile("alice", "password", true)
-	app.CreateProfile("bob", "password", true)
+	app := app2.NewApp(acn, cwtchDir)
+	app.CreateTaggedPeer("alice", "password", constants.ProfileTypeV1Password)
+	app.CreateTaggedPeer("bob", "password", constants.ProfileTypeV1Password)
 
 	alice := app2.WaitGetPeer(app, "alice")
 	bob := app2.WaitGetPeer(app, "bob")
@@ -98,10 +99,6 @@ func TestEncryptedStorage(t *testing.T) {
 		ci, err = bob.FetchConversationInfo(alice.GetOnion())
 	}
 
-	if ci == nil {
-		t.Fatalf("could not fetch bobs conversation")
-	}
-
 	body, _, err := bob.GetChannelMessage(ci.ID, 0, 1)
 	if body != "Hello Bob" || err != nil {
 		t.Fatalf("unexpected message in conversation channel %v %v", body, err)
@@ -133,7 +130,7 @@ func TestEncryptedStorage(t *testing.T) {
 		t.Fatalf("expeced GetMostRecentMessages to return 1, instead returned: %v %v", len(messages), messages)
 	}
 
-	err = alice.ExportProfile("alice.tar.gz")
+	err = alice.Export("alice.tar.gz")
 	if err != nil {
 		t.Fatalf("could not export profile: %v", err)
 	}
@@ -143,7 +140,7 @@ func TestEncryptedStorage(t *testing.T) {
 		t.Fatal("profile is already imported...this should fail")
 	}
 
-	app.DeleteProfile(alice.GetOnion(), "password")
+	app.DeletePeer(alice.GetOnion(), "password")
 	alice, err = app.ImportProfile("alice.tar.gz", "password")
 	if err != nil {
 		t.Fatalf("profile should have successfully imported: %s", err)

testing/filesharing/file_sharing_integration_test.go

@@ -2,12 +2,6 @@ package filesharing
 
 import (
 	"crypto/rand"
-	"encoding/base64"
-	"encoding/hex"
-	"encoding/json"
-	"fmt"
-	"path/filepath"
-
 	app2 "cwtch.im/cwtch/app"
 	"cwtch.im/cwtch/event"
 	"cwtch.im/cwtch/functionality/filesharing"
@@ -18,6 +12,10 @@ import (
 	"cwtch.im/cwtch/protocol/connections"
 	"cwtch.im/cwtch/protocol/files"
 	utils2 "cwtch.im/cwtch/utils"
+	"encoding/base64"
+	"encoding/hex"
+	"encoding/json"
+	"fmt"
 	"git.openprivacy.ca/openprivacy/connectivity/tor"
 	"git.openprivacy.ca/openprivacy/log"
 
@@ -58,14 +56,14 @@ func TestFileSharing(t *testing.T) {
 	os.RemoveAll("cwtch.out.png")
 	os.RemoveAll("cwtch.out.png.manifest")
 
-	log.SetLevel(log.LevelDebug)
-	log.ExcludeFromPattern("tapir")
+	log.SetLevel(log.LevelInfo)
 
 	os.Mkdir("tordir", 0700)
 	dataDir := path.Join("tordir", "tor")
 	os.MkdirAll(dataDir, 0700)
 
 	// we don't need real randomness for the port, just to avoid a possible conflict...
+	mrand.Seed(int64(time.Now().Nanosecond()))
 	socksPort := mrand.Intn(1000) + 9051
 	controlPort := mrand.Intn(1000) + 9052
 
@@ -76,140 +74,92 @@ func TestFileSharing(t *testing.T) {
 		panic(err)
 	}
 
-	useCache := os.Getenv("TORCACHE") == "true"
-
 	torDataDir := ""
-	if useCache {
-		log.Infof("using tor cache")
-		torDataDir = filepath.Join(dataDir, "data-dir-torcache")
-		os.MkdirAll(torDataDir, 0700)
-	} else {
-		log.Infof("using clean tor data dir")
-		if torDataDir, err = os.MkdirTemp(dataDir, "data-dir-"); err != nil {
-			t.Fatalf("could not create data dir")
-		}
+	if torDataDir, err = os.MkdirTemp(dataDir, "data-dir-"); err != nil {
+		t.Fatalf("could not create data dir")
 	}
 
 	tor.NewTorrc().WithSocksPort(socksPort).WithOnionTrafficOnly().WithHashedPassword(base64.StdEncoding.EncodeToString(key)).WithControlPort(controlPort).Build("tordir/tor/torrc")
-	acn, err := tor.NewTorACNWithAuth("./tordir", path.Join("..", "tor"), torDataDir, controlPort, tor.HashedPasswordAuthenticator{Password: base64.StdEncoding.EncodeToString(key)})
+	acn, err := tor.NewTorACNWithAuth("./tordir", path.Join("..", "..", "tor"), torDataDir, controlPort, tor.HashedPasswordAuthenticator{Password: base64.StdEncoding.EncodeToString(key)})
 	if err != nil {
 		t.Fatalf("Could not start Tor: %v", err)
 	}
 	acn.WaitTillBootstrapped()
 	defer acn.Close()
 
-	app := app2.NewApp(acn, "./storage", app2.LoadAppSettings("./storage"))
+	app := app2.NewApp(acn, "./storage")
 
-	usr, err := user.Current()
-	if err != nil {
-		t.Fatalf("current user is undefined")
-	}
+	usr, _ := user.Current()
 	cwtchDir := path.Join(usr.HomeDir, ".cwtch")
 	os.Mkdir(cwtchDir, 0700)
 	os.RemoveAll(path.Join(cwtchDir, "testing"))
 	os.Mkdir(path.Join(cwtchDir, "testing"), 0700)
 
 	t.Logf("Creating Alice...")
-	app.CreateProfile("alice", "asdfasdf", true)
+	app.CreateTaggedPeer("alice", "asdfasdf", "testing")
 
 	t.Logf("Creating Bob...")
-	app.CreateProfile("bob", "asdfasdf", true)
+	app.CreateTaggedPeer("bob", "asdfasdf", "testing")
 
 	t.Logf("** Waiting for Alice, Bob...")
 	alice := app2.WaitGetPeer(app, "alice")
-	app.ActivatePeerEngine(alice.GetOnion())
-	app.ConfigureConnections(alice.GetOnion(), true, true, true)
+	app.ActivatePeerEngine(alice.GetOnion(), true, true, true)
 	bob := app2.WaitGetPeer(app, "bob")
-	app.ActivatePeerEngine(bob.GetOnion())
-	app.ConfigureConnections(bob.GetOnion(), true, true, true)
+	app.ActivatePeerEngine(bob.GetOnion(), true, true, true)
+
 	alice.AutoHandleEvents([]event.Type{event.PeerStateChange, event.NewRetValMessageFromPeer})
-	bob.AutoHandleEvents([]event.Type{event.PeerStateChange, event.NewRetValMessageFromPeer})
+	bob.AutoHandleEvents([]event.Type{event.PeerStateChange, event.NewRetValMessageFromPeer, event.ManifestReceived})
 
-	aliceQueueOracle := event.NewQueue()
-	aliceEb := app.GetEventBus(alice.GetOnion())
-	if aliceEb == nil {
-		t.Fatalf("alice's eventbus is undefined")
-	}
-	aliceEb.Subscribe(event.SearchResult, aliceQueueOracle)
 	queueOracle := event.NewQueue()
-	bobEb := app.GetEventBus(bob.GetOnion())
-	if bobEb == nil {
-		t.Fatalf("bob's eventbus is undefined")
-	}
-	bobEb.Subscribe(event.FileDownloaded, queueOracle)
-
-	// Turn on File Sharing Experiment...
-	settings := app.ReadSettings()
-	settings.ExperimentsEnabled = true
-	settings.Experiments[constants.FileSharingExperiment] = true
-	app.UpdateSettings(settings)
+	app.GetEventBus(bob.GetOnion()).Subscribe(event.FileDownloaded, queueOracle)
 
 	t.Logf("** Launching Peers...")
+
 	waitTime := time.Duration(30) * time.Second
 	t.Logf("** Waiting for Alice, Bob  to connect with onion network... (%v)\n", waitTime)
 	time.Sleep(waitTime)
 
 	bob.NewContactConversation(alice.GetOnion(), model.DefaultP2PAccessControl(), true)
 	alice.NewContactConversation(bob.GetOnion(), model.DefaultP2PAccessControl(), true)
+	alice.PeerWithOnion(bob.GetOnion())
 
-	filesharingFunctionality := filesharing.FunctionalityGate()
+	t.Logf("Waiting for alice and Bob to peer...")
+	waitForPeerPeerConnection(t, alice, bob)
+
+	t.Logf("Alice and Bob are Connected!!")
+
+	filesharingFunctionality, _ := filesharing.FunctionalityGate(map[string]bool{constants.FileSharingExperiment: true})
 
 	_, fileSharingMessage, err := filesharingFunctionality.ShareFile("cwtch.png", alice)
+	alice.SendMessage(1, fileSharingMessage)
+
 	if err != nil {
 		t.Fatalf("Error!: %v", err)
 	}
 
-	alice.SendMessage(1, fileSharingMessage)
-
-	// Ok this is fun...we just Sent a Message we may not have a connection yet...
-	// so this test will only pass if sending offline works...
-	waitForPeerPeerConnection(t, bob, alice)
-
-	bob.SendMessage(1, "this is a test message")
-	bob.SendMessage(1, "this is another  test message")
-
 	// Wait for the messages to arrive...
-	time.Sleep(time.Second * 20)
-	alice.SearchConversations("test")
-
-	results := 0
-	for {
-		ev := aliceQueueOracle.Next()
-		if ev.EventType != event.SearchResult {
-			t.Fatalf("Expected a search result vent")
-		}
-		results += 1
-		t.Logf("found search result (%d)....%v", results, ev)
-		if results == 2 {
-			break
-		}
-	}
+	time.Sleep(time.Second * 10)
 
 	// test that bob can download and verify the file
 	testBobDownloadFile(t, bob, filesharingFunctionality, queueOracle)
 
 	// Test stopping and restarting file shares
 	t.Logf("Stopping File Share")
-	filesharingFunctionality.StopAllFileShares(alice)
+	alice.StopAllFileShares()
 
 	// Allow time for the stop request to filter through Engine
 	time.Sleep(time.Second * 5)
 
 	// Restart
 	t.Logf("Restarting File Share")
-	err = filesharingFunctionality.ReShareFiles(alice)
-
-	if err != nil {
-		t.Fatalf("Error!: %v", err)
-	}
+	filesharingFunctionality.ReShareFiles(alice)
 
 	// run the same download test again...to check that we can actually download the file
 	testBobDownloadFile(t, bob, filesharingFunctionality, queueOracle)
 
 	// test that we can delete bob...
-	app.DeleteProfile(bob.GetOnion(), "asdfasdf")
+	app.DeletePeer(bob.GetOnion(), "asdfasdf")
 
-	aliceQueueOracle.Shutdown()
 	queueOracle.Shutdown()
 	app.Shutdown()
 	acn.Close()
@@ -244,19 +194,19 @@ func testBobDownloadFile(t *testing.T, bob peer.CwtchPeer, filesharingFunctional
 		err := json.Unmarshal([]byte(messageWrapper.Data), &fileMessageOverlay)
 
 		if err == nil {
-			t.Logf("bob attempting to download file with invalid download")
+
 			// try downloading with invalid download dir
 			err = filesharingFunctionality.DownloadFile(bob, 1, "/do/not/download/this/file/cwtch.out.png", "./cwtch.out.png.manifest", fmt.Sprintf("%s.%s", fileMessageOverlay.Hash, fileMessageOverlay.Nonce), constants.ImagePreviewMaxSizeInBytes)
 			if err == nil {
 				t.Fatalf("should not download file with invalid download dir")
 			}
-			t.Logf("bob attempting to download file with invalid manifest")
+
 			// try downloading with invalid manifest dir
 			err = filesharingFunctionality.DownloadFile(bob, 1, "./cwtch.out.png", "/do/not/download/this/file/cwtch.out.png.manifest", fmt.Sprintf("%s.%s", fileMessageOverlay.Hash, fileMessageOverlay.Nonce), constants.ImagePreviewMaxSizeInBytes)
 			if err == nil {
 				t.Fatalf("should not download file with invalid manifest dir")
 			}
-			t.Logf("bob attempting to download file")
+
 			err = filesharingFunctionality.DownloadFile(bob, 1, "./cwtch.out.png", "./cwtch.out.png.manifest", fmt.Sprintf("%s.%s", fileMessageOverlay.Hash, fileMessageOverlay.Nonce), constants.ImagePreviewMaxSizeInBytes)
 			if err != nil {
 				t.Fatalf("could not download file: %v", err)

testing/quality.sh

@@ -4,25 +4,18 @@ echo "Checking code quality (you want to see no output here)"
 echo ""
 
 echo ""
-echo "Running staticcheck..."
+echo "Linting:"
 
 staticcheck ./...
 
-# In the future we should remove include-pkgs. However, there are a few false positives in the overall go stdlib that make this
-# too noisy right now, specifically assigning nil to initialize slices (safe), and using go internal context channels assigned
-# nil (also safe).
-# We also have one file infinite_channel.go written in a way that static analysis cannot reason about easily. So it is explictly
-# ignored.
-echo "Running nilaway..."
-nilaway -include-pkgs="cwtch.im/cwtch,cwtch.im/tapir,git.openprivacy.ca/openprivacy/connectivity" -exclude-file-docstrings="nolint:nilaway" ./...
 
 echo "Time to format"
 gofmt -l -s -w .
 
 # ineffassign (https://github.com/gordonklaus/ineffassign)
-# echo "Checking for ineffectual assignment of errors (unchecked errors...)"
-# ineffassign .
+echo "Checking for ineffectual assignment of errors (unchecked errors...)"
+ineffassign ./..
 
 # misspell (https://github.com/client9/misspell/cmd/misspell)
-# echo "Checking for misspelled words..."
-# misspell . | grep -v "testing/" | grep -v "vendor/" | grep -v "go.sum" | grep -v ".idea"
+echo "Checking for misspelled words..."
+misspell . | grep -v "testing/" | grep -v "vendor/" | grep -v "go.sum" | grep -v ".idea"

testing/tests.sh

@@ -3,7 +3,7 @@
 set -e
 pwd
 GORACE="haltonerror=1"
-go test -coverprofile=plugins.cover.out -v ./app/plugins
+go test -race ${1} -coverprofile=plugins.cover.out -v ./app/plugins
 go test -race ${1} -coverprofile=model.cover.out -v ./model
 go test -race ${1} -coverprofile=event.cover.out -v ./event
 go test -race ${1} -coverprofile=storage.v1.cover.out -v ./storage/v1

tools/cwtch_tools.go

@@ -18,6 +18,7 @@ import (
 	"os"
 	path "path/filepath"
 	"strings"
+	"time"
 )
 
 var tool = flag.String("tool", "", "the tool to use")
@@ -85,6 +86,7 @@ func getTokens(bundle string) {
 	os.MkdirAll(dataDir, 0700)
 
 	// we don't need real randomness for the port, just to avoid a possible conflict...
+	mrand.Seed(int64(time.Now().Nanosecond()))
 	socksPort := mrand.Intn(1000) + 9051
 	controlPort := mrand.Intn(1000) + 9052
 

utils/timeoutpolicy.go

@@ -1,4 +1,3 @@
-// nolint:nilaway - the context timeout here is reported as an error, even though it is a by-the-doc example
 package utils
 
 import (