Refactor to make app.Peer safe to call. #101

New Issue

sarah · 2018-08-04T21:32:49Z

sarah commented

2018-08-04 21:32:49 +00:00

See:#99 an #100 - ideally calling app.Peer should not result in NPE when profile isn't set. Will profile involve having an empty peer keep track of its own state and returning error for everything (and maybe making load-profile a member function) - this might fit in nicer with how we want to do multiple profiles per peer, and we have to bite the bullet on that refactor anyway.

Dan, do I remember having a conversation with you ending with us deciding you were going to tackle that refactor?

See:#99 an #100 - ideally calling app.Peer should not result in NPE when profile isn't set. Will profile involve having an empty peer keep track of its own state and returning error for everything (and maybe making load-profile a member function) - this might fit in nicer with how we want to do multiple profiles per peer, and we have to bite the bullet on that refactor anyway. Dan, do I remember having a conversation with you ending with us deciding you were going to tackle that refactor?

dan commented

2018-10-11 00:12:31 +00:00

done. finished in #127

dan closed this issue

2018-10-11 00:12:31 +00:00

Sign in to join this conversation.