Server Monitor Data Races #288

New Issue

sarah · 2019-11-12T20:35:12Z

sarah commented

2019-11-12 20:35:12 +00:00

==================
WARNING: DATA RACE
Write at 0x00c000122068 by goroutine 106:
git.openprivacy.ca/openprivacy/libricochet-go/application.(*RicochetApplication).handleConnection()
/home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:61 +0x3ca

Previous read at 0x00c000122068 by goroutine 16:
cwtch.im/cwtch/server/metrics.(*Monitors).Start.func4()
/home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:139 +0x4c
cwtch.im/cwtch/server/metrics.(*monitorHistory).monitorThread()
/home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:218 +0x1ba

Goroutine 106 (running) created at:
git.openprivacy.ca/openprivacy/libricochet-go/application.(*RicochetApplication).Run()
/home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:154 +0xf8
cwtch.im/cwtch/server.(*Server).Run()
/home/sarah/workspace/src/cwtch.im/cwtch/server/server.go:86 +0xb0e

Goroutine 16 (running) created at:
cwtch.im/cwtch/server/metrics.(monitorHistory).Start()
/home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:120 +0x4c
cwtch.im/cwtch/server/metrics.NewMonitorHistory()
/home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:114 +0x3b7
cwtch.im/cwtch/server/metrics.(Monitors).Start()
/home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/monitors.go:41 +0x47e
cwtch.im/cwtch/server.(*Server).Run()
/home/sarah/workspace/src/cwtch.im/cwtch/server/server.go:36 +0x151

================== WARNING: DATA RACE Write at 0x00c000122068 by goroutine 106: git.openprivacy.ca/openprivacy/libricochet-go/application.(*RicochetApplication).handleConnection() /home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:61 +0x3ca Previous read at 0x00c000122068 by goroutine 16: cwtch.im/cwtch/server/metrics.(*Monitors).Start.func4() /home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:139 +0x4c cwtch.im/cwtch/server/metrics.(*monitorHistory).monitorThread() /home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:218 +0x1ba Goroutine 106 (running) created at: git.openprivacy.ca/openprivacy/libricochet-go/application.(*RicochetApplication).Run() /home/sarah/workspace/pkg/mod/git.openprivacy.ca/openprivacy/libricochet-go@v1.0.8/application/application.go:154 +0xf8 cwtch.im/cwtch/server.(*Server).Run() /home/sarah/workspace/src/cwtch.im/cwtch/server/server.go:86 +0xb0e Goroutine 16 (running) created at: cwtch.im/cwtch/server/metrics.(*monitorHistory).Start() /home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:120 +0x4c cwtch.im/cwtch/server/metrics.NewMonitorHistory() /home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/metrics.go:114 +0x3b7 cwtch.im/cwtch/server/metrics.(*Monitors).Start() /home/sarah/workspace/src/cwtch.im/cwtch/server/metrics/monitors.go:41 +0x47e cwtch.im/cwtch/server.(*Server).Run() /home/sarah/workspace/src/cwtch.im/cwtch/server/server.go:36 +0x151 ==================

dan self-assigned this 2020-01-28 22:27:35 +00:00

sarah commented

2020-10-08 20:37:57 +00:00

Server is no longer ricochet based, and I ended up fixing the metrics data race will working on the tapir integration: d230a1b629

Closing.

Server is no longer ricochet based, and I ended up fixing the metrics data race will working on the tapir integration: https://git.openprivacy.ca/cwtch.im/cwtch/commit/d230a1b62973f1f767c786091b287419fc4630c1 Closing.

sarah closed this issue

2020-10-08 20:37:57 +00:00

Sign in to join this conversation.