Key Val store peer get/ret requests and attributes #302
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#302
Loading…
Reference in New Issue
No description provided.
Delete Branch "dan/cwtch:keyval"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
cwtch.im/ui#272
is the use of it as well
I'm wondering if anyone has any feelings of the Attribute API? I am thinking maybe moving it from peer to it's own package 'attr' so it is a bit smoother to use, especially with groups?
And any other thoughts would be appreciated
WIP: Key Val store peer get/ret requests and attributesto Key Val store peer get/ret requests and attributes@ -0,0 +18,4 @@
Settings = "settings"
)
// Attribute Types
Are these really needed? I'd prefer to have these stores be string only, and do any type conversions on the UI side.
@ -533,0 +554,4 @@
log.Debugf("NewGetValMessageFromPeer for %v%v from %v\n", scope, path, onion)
if scope == Public {
val, exists := cp.GetAttribute(Public + path)
This should be GetPublicAttribute (path) - don't let programmers mess up by constructing the paths
@ -533,0 +577,4 @@
log.Debugf("NewRetValMessageFromPeer %v %v%v %v %v\n", onion, scope, path, exists, val)
if exists {
if scope == Public {
cp.SetContactAttribute(onion, Peer+path, StringToAttribute(val))
Same as above, the API should enforce paths
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/738
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/739
@ -31,2 +46,2 @@
func (pa PeerApp) NewInstance() tapir.Application {
newApp := new(PeerApp)
func (pa *PeerApp) NewInstance() tapir.Application {
newApp := &PeerApp{} //new(PeerApp)
why?
lol left over debug junk, will fix
@ -74,8 +90,15 @@ func (pa PeerApp) listen() {
if err == nil {
if peerMessage.Context == event.ContextAck {
This should be a switch
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/740
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/741
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/742