Sign and Check ToFU Server Bundle #321
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#321
Loading…
Reference in New Issue
No description provided.
Delete Branch "tapir_server"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/828
maybe one logic error (see comment) but otherwise looks good to me
@ -243,0 +256,4 @@
return model.InconsistentKeyBundleError
}
}
// we haven't seen this key associated with the server before
we don't record anywhere if we def didnt see the key or exit the function so we will ALWAS fall through to adding, even if it already exists in the bundle?
We can't do anything with the bundle until we've confirmed it isn't malicious so we first iterate through all the keys and then if that check passes we just publish the update key attributes (which yeah means if the user calls addserver twice on the same bundle it it will do some unnecessary work, but it simplifies the function a lot).
gave you a comment in meatspace to doublecheck that serialization is order preserving, then lgtm +1
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/830
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/832