cwtch.im
/
cwtch
16
20
Fork 16
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Close a connection if sending fails. #438

Merged
sarah merged 2 commits from send into master 2022-03-29 19:16:48 +00:00
Conversation 2 Commits 2 Files Changed 1 +15 -1
sarah commented 2022-03-29 18:40:52 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2022-03-29 18:40:52 +00:00
sarah added 1 commit 2022-03-29 18:40:53 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
7fd53a3b16 Close a connection is sending fails.
buildbot commented 2022-03-29 18:55:17 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/755

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/755
buildbot commented 2022-03-29 19:11:33 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/756

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/756
dan reviewed 2022-03-29 19:15:32 +00:00
protocol/connections/peerapp.go Outdated
@ -156,1 +156,3 @@
return pa.connection.Send(serialized)
err = pa.connection.Send(serialized)
// at this point we have tried to send a connection to a peer only to find that something went wrong.
dan commented 2022-03-29 19:15:32 +00:00
Owner
Copy Link

connection / message ?

connection / message ?
dan approved these changes 2022-03-29 19:15:37 +00:00
sarah added 1 commit 2022-03-29 19:15:42 +00:00
continuous-integration/drone/pr Build is pending Details
continuous-integration/drone/push Build is passing Details
a39775d56b connection -> message
sarah changed title from Close a connection is sending fails. to Close a connection if sending fails. 2022-03-29 19:16:37 +00:00
sarah merged commit 3fbf88d34b into master 2022-03-29 19:16:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#438
No description provided.
Delete Branch "send"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?