cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Small Code Fixups #505

Merged
sarah merged 2 commits from code-fixes into master 2023-04-18 03:25:28 +00:00
Conversation 2 Commits 2 Files Changed 19 +153 -152
sarah commented 2023-04-17 19:16:39 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-04-17 19:16:39 +00:00
buildbot commented 2023-04-17 19:25:25 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/137

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/137
sarah force-pushed code-fixes from 2dc92e565b to dbac41d949 2023-04-17 19:34:05 +00:00 Compare
buildbot commented 2023-04-17 19:46:14 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/138

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/138
dan approved these changes 2023-04-17 20:22:46 +00:00
app/app.go
@ -162,3 +162,1 @@
func (ap *application) AddPlugin(peerid string, id plugins.PluginID, bus event.Manager, acn connectivity.ACN) {
if _, exists := ap.plugins.Load(peerid); !exists {
ap.plugins.Store(peerid, []plugins.Plugin{})
func (app *application) AddPlugin(peerid string, id plugins.PluginID, bus event.Manager, acn connectivity.ACN) {
dan commented 2023-04-17 20:17:33 +00:00
Owner
Copy Link

hahaha legacy from when we had a more composed app, I guess when I remerged them I missed this. i think here ap was in context for AppPlugin struct

hahaha legacy from when we had a more composed app, I guess when I remerged them I missed this. i think here `ap` was in context for AppPlugin struct
sarah merged commit c4460b67a1 into master 2023-04-18 03:25:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#505
No description provided.
Delete Branch "code-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?