Metrics should total not avg #73

dan · 2018-06-28T19:37:34Z

dan commented

2018-06-28 19:37:34 +00:00

I can't math sometimes I swear

also the metricsHistory test will need to be added to the integ test

I can't math sometimes I swear also the metricsHistory test will need to be added to the integ test

dan commented

2018-06-28 20:20:30 +00:00

wait, thats wrong for some use cases too

messages should be cumunalative, client conns, memory use, and cpu should be averaged...

wait, thats wrong for some use cases too messages should be cumunalative, client conns, memory use, and cpu should be averaged...

dan closed this pull request

2018-06-28 20:20:30 +00:00

dan commented

2018-06-28 23:18:39 +00:00

added ability for metrics to be either cumlative or averaged

dan reopened this pull request

2018-06-28 23:18:39 +00:00

sarah commented

2018-06-29 17:15:51 +00:00

Checking code quality (you want to see no output here)

Vetting:

cwtch.im/cwtch/server/metrics

server/metrics/metrics.go:164: Sprintf format %d has arg array of wrong type []float64

Linting:

Checking code quality (you want to see no output here) Vetting: # cwtch.im/cwtch/server/metrics server/metrics/metrics.go:164: Sprintf format %d has arg array of wrong type []float64 Linting:

dan commented

2018-06-29 19:14:03 +00:00

fixed

sarah closed this pull request

2018-06-29 19:15:16 +00:00

Sign in to join this conversation.

No reviewers

No Label

ready-for-implementation

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#73