cwtch.im
/
cwtch
16
20
Fork 16
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

fixes #102 #104

Closed
kardan wants to merge 1 commits from kardan/cwtch:fix-102 into master
pull from: kardan/cwtch:fix-102
merge into: cwtch.im:master
Conversation 1 Commits 1 Files Changed 1 +1 -1
kardan commented 2018-08-04 23:46:24 +00:00
First-time contributor
Copy Link

Fixes #102 for me.

Tests fail:

~/go/src/cwtch.im/cwtch$ ./testing/tests.sh
....
=== RUN   TestMessageStore
--- FAIL: TestMessageStore (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]                             
        panic: runtime error: invalid memory address or nil pointer dereference                                 
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x804974c]                                         

goroutine 5 [running]:
testing.tRunner.func1(0x197605a0)
        /usr/lib/go-1.10/src/testing/testing.go:742 +0x24a                                                      
panic(0x820d540, 0x833cb70)
        /usr/lib/go-1.10/src/runtime/panic.go:502 +0x1dc                                                        
sync/atomic.AddUint64(0x19710cd4, 0x1, 0x0, 0xffffff01, 0x197680f0)                                             
        /usr/lib/go-1.10/src/sync/atomic/asm_386.s:112 +0xc                                                     
cwtch.im/cwtch/server/metrics.(*counter).Add(0x19710cc0, 0x1)                                                   
        /home/user/go/src/cwtch.im/cwtch/server/metrics/metrics.go:34 +0x35                                      
cwtch.im/cwtch/storage.(*MessageStore).AddMessage(0x197680c0, 0x197760a0, 0x49, 0x50, 0x8352bb4, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/user/go/src/cwtch.im/cwtch/storage/message_store.go:95 +0x77                                       
cwtch.im/cwtch/storage.TestMessageStore(0x197605a0)
        /home/user/go/src/cwtch.im/cwtch/storage/message_store_test.go:21 +0x177                                 
testing.tRunner(0x197605a0, 0x824139c)
        /usr/lib/go-1.10/src/testing/testing.go:777 +0xaa                                                       
created by testing.(*T).Run
        /usr/lib/go-1.10/src/testing/testing.go:824 +0x243                                                      
FAIL    cwtch.im/cwtch/storage  0.033s
Fixes #102 for me. Tests fail: ``` ~/go/src/cwtch.im/cwtch$ ./testing/tests.sh .... === RUN TestMessageStore --- FAIL: TestMessageStore (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x804974c] goroutine 5 [running]: testing.tRunner.func1(0x197605a0) /usr/lib/go-1.10/src/testing/testing.go:742 +0x24a panic(0x820d540, 0x833cb70) /usr/lib/go-1.10/src/runtime/panic.go:502 +0x1dc sync/atomic.AddUint64(0x19710cd4, 0x1, 0x0, 0xffffff01, 0x197680f0) /usr/lib/go-1.10/src/sync/atomic/asm_386.s:112 +0xc cwtch.im/cwtch/server/metrics.(*counter).Add(0x19710cc0, 0x1) /home/user/go/src/cwtch.im/cwtch/server/metrics/metrics.go:34 +0x35 cwtch.im/cwtch/storage.(*MessageStore).AddMessage(0x197680c0, 0x197760a0, 0x49, 0x50, 0x8352bb4, 0x0, 0x0, 0x0, 0x0, 0x0, ...) /home/user/go/src/cwtch.im/cwtch/storage/message_store.go:95 +0x77 cwtch.im/cwtch/storage.TestMessageStore(0x197605a0) /home/user/go/src/cwtch.im/cwtch/storage/message_store_test.go:21 +0x177 testing.tRunner(0x197605a0, 0x824139c) /usr/lib/go-1.10/src/testing/testing.go:777 +0xaa created by testing.(*T).Run /usr/lib/go-1.10/src/testing/testing.go:824 +0x243 FAIL cwtch.im/cwtch/storage 0.033s ```
sarah commented 2018-08-05 03:47:11 +00:00
Owner
Copy Link

Fixed by #103

Fixed by #103
sarah closed this pull request 2018-08-05 03:47:11 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#104
No description provided.
Delete Branch "kardan/cwtch:fix-102"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?