merging some bugfixes #163

Fusionado

sarah fusionados 1 commits de bigmerge en master

2018-11-22 01:05:24 +00:00

erinn comentado

2018-11-22 00:48:41 +00:00

Propietario

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot comentado

2018-11-22 00:49:00 +00:00

Miembro

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot comentado

2018-11-22 01:03:26 +00:00

Miembro

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah cerró este pull request

2018-11-22 01:05:23 +00:00

dan comentado

2018-11-22 05:43:33 +00:00

Propietario

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan comentado

2018-11-22 06:52:22 +00:00

Propietario

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Inicie sesión para unirse a esta conversación.

No hay revisores

Sin etiquetas

ready-for-implementation

Sin Milestone

No asignados

3 participantes

Notificaciones

Fecha de vencimiento

La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: cwtch.im/cwtch#163

No se ha proporcionado una descripción.