merging some bugfixes #163

Unito

sarah ha unito 1 commit da bigmerge a master

2018-11-22 01:05:24 +00:00

erinn

2018-11-22 00:48:41 +00:00

ha commentato

Proprietario

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot

2018-11-22 00:49:00 +00:00

ha commentato

Membro

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot

2018-11-22 01:03:26 +00:00

ha commentato

Membro

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah chiusa questa pull request

2018-11-22 01:05:23 +00:00

dan

2018-11-22 05:43:33 +00:00

ha commentato

Proprietario

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan

2018-11-22 06:52:22 +00:00

ha commentato

Proprietario

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Effettua l'accesso per partecipare alla conversazione.

Nessun revisore

Nessuna etichetta

ready-for-implementation

Nessuna milestone

Nessuna assegnatario

3 Partecipanti

Notifiche

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: cwtch.im/cwtch#163

No description provided.