merging some bugfixes #163

Samengevoegd
sarah heeft 1 commits samengevoegd van bigmerge naar master 2018-11-22 01:05:24 +00:00
Eigenaar

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out
Lid
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278
Lid
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280
sarah heeft deze pull request gesloten 2018-11-22 01:05:23 +00:00
Eigenaar

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork
Eigenaar

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already
Log in om deel te nemen aan deze discussie.
Geen beoordelaars
Geen mijlpaal
Niet toegewezen
3 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: cwtch.im/cwtch#163
No description provided.