merging some bugfixes #163

Merge aplicado

sarah aplicou merge dos 1 commits de bigmerge em master

2018-11-22 01:05:24 +00:00

erinn comentou

2018-11-22 00:48:41 +00:00

Proprietário

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot comentou

2018-11-22 00:49:00 +00:00

Membro

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot comentou

2018-11-22 01:03:26 +00:00

Membro

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah fechou este pull request

2018-11-22 01:05:23 +00:00

dan comentou

2018-11-22 05:43:33 +00:00

Proprietário

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan comentou

2018-11-22 06:52:22 +00:00

Proprietário

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Acesse para participar desta conversação.

Sem revisor

Sem etiqueta

ready-for-implementation

Sem marco

Sem responsável

3 participante(s)

Notificações

Data limite

A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: cwtch.im/cwtch#163

Nenhuma descrição fornecida.