merging some bugfixes #163

Birleştirildi

sarah

2018-11-22 01:05:24 +00:00

bigmerge içindeki 1 işlemeyi master ile birleştirdi

erinn

2018-11-22 00:48:41 +00:00

yorum yaptı

Sahibi

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot

2018-11-22 00:49:00 +00:00

yorum yaptı

Üye

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot

2018-11-22 01:03:26 +00:00

yorum yaptı

Üye

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah

2018-11-22 01:05:23 +00:00

değişiklik isteğini kapattı

dan

2018-11-22 05:43:33 +00:00

yorum yaptı

Sahibi

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan

2018-11-22 06:52:22 +00:00

yorum yaptı

Sahibi

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Bu konuşmaya katılmak için oturum aç.

Değerlendirici yok

Etiket Yok

ready-for-implementation

Kilometre Taşı Yok

Atanan Kişi Yok

3 Katılımcı

Bildirimler

Bitiş Tarihi

Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: cwtch.im/cwtch#163

Herhangi bir açıklama sağlanmadı.