merging some bugfixes #163

已合并

sarah 于 2018-11-22 01:05:24 +00:00 将 1 次代码提交从 bigmerge 合并至 master

erinn 评论于

2018-11-22 00:48:41 +00:00

管理员

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot 评论于

2018-11-22 00:49:00 +00:00

普通成员

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot 评论于

2018-11-22 01:03:26 +00:00

普通成员

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah "于

2018-11-22 01:05:23 +00:00

关闭此合并请求 "

dan 评论于

2018-11-22 05:43:33 +00:00

管理员

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan 评论于

2018-11-22 06:52:22 +00:00

管理员

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

登录并参与到对话中。

无审核者

未选择标签

ready-for-implementation

未选择里程碑

未指派成员

3 名参与者

通知

到期时间

到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

参考：cwtch.im/cwtch#163

没有提供说明。