merging some bugfixes #163

已合併

sarah 將 1 次提交從 bigmerge 合併至 master

2018-11-22 01:05:24 +00:00

erinn 已留言

2018-11-22 00:48:41 +00:00

擁有者

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot 已留言

2018-11-22 00:49:00 +00:00

普通成員

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot 已留言

2018-11-22 01:03:26 +00:00

普通成員

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah 關閉了這個合併請求

2018-11-22 01:05:23 +00:00

dan 已留言

2018-11-22 05:43:33 +00:00

擁有者

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan 已留言

2018-11-22 06:52:22 +00:00

擁有者

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

登入才能加入這對話。

沒有審核者

未選擇標籤

ready-for-implementation

未選擇里程碑

沒有負責人

3 參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: cwtch.im/cwtch#163

No description provided.