BUGFIX: Sorting Function #176

sarah · 2018-12-05T23:14:46Z

sarah hozzászólt

2018-12-05 23:14:46 +00:00

Tulajdonos

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI).

This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI). This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.

buildbot hozzászólt

2018-12-05 23:20:52 +00:00

Tag

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/317

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/317

dan hozzászólt

2018-12-06 01:03:22 +00:00

Tulajdonos

its a slow noop tho as it still does a full order check on the entire timeline?
yeah I hope we dont need call it

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it

dan closed this pull request