cwtch.im
/
cwtch
16
20
Forka 16
Codice Problemi 10 Pull Requests 2 Rilasci 163 Wiki Attività

BUGFIX: Sorting Function #176

Unito
dan ha unito 1 commit da sorting a master 2018-12-06 01:03:24 +00:00
Conversazione 2 Commit 1 File modificati 2 +17 -6
sarah 2018-12-05 23:14:46 +00:00 ha commentato
Proprietario
Copia link

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI).

This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI). This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.
buildbot 2018-12-05 23:20:52 +00:00 ha commentato
Membro
Copia link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/317

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/317
dan 2018-12-06 01:03:22 +00:00 ha commentato
Proprietario
Copia link

its a slow noop tho as it still does a full order check on the entire timeline?
yeah I hope we dont need call it

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it
dan chiusa questa pull request 2018-12-06 01:03:24 +00:00
Effettua l'accesso per partecipare alla conversazione.
Revisori
Nessun revisore
Etichette
Pulisci le etichette   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
Nessuna etichetta
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
Nessuna assegnatario
dan
dan
3 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: cwtch.im/cwtch#176
No description provided.
Delete Branch "sorting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?