BUGFIX: Sorting Function #176

Merge aplicado
dan aplicou merge dos 1 commits de sorting em master 2018-12-06 01:03:24 +00:00
Proprietário

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI).

This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI). This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.
Membro
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/317
Proprietário

its a slow noop tho as it still does a full order check on the entire timeline?
yeah I hope we dont need call it

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it
dan fechou este pull request 2018-12-06 01:03:24 +00:00
Acesse para participar desta conversação.
Sem revisor
Sem marco
Sem responsável
3 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: cwtch.im/cwtch#176
Nenhuma descrição fornecida.