BUGFIX: Sorting Function #176

已合併
dan 2018-12-06 01:03:24 +00:00 將 1 次代碼提交從 sorting 合併至 master
管理員

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI).

This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI). This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.
普通成員
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/317
管理員

its a slow noop tho as it still does a full order check on the entire timeline?
yeah I hope we dont need call it

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it
dan closed this pull request 2018-12-06 01:03:24 +00:00
登入 才能加入這對話。
No description provided.