cwtch.im
/
cwtch
16
20
Fork 16
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Fixing Data Races in Event Bus #290

Manually merged
dan merged 1 commits from racefuzz into master 2019-11-12 20:58:48 +00:00
Conversation 2 Commits 1 Files Changed 7 +42 -16
sarah commented 2019-11-12 20:41:43 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2019-11-12 20:42:45 +00:00
buildbot commented 2019-11-12 20:48:35 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/702

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/702
dan requested changes 2019-11-12 20:52:33 +00:00
event/eventQueue.go
@ -13,3 +19,4 @@
// the event.Manager.
type Queue interface {
Publish(event Event)
InChan() chan<- Event
dan commented 2019-11-12 20:52:12 +00:00
Owner
Copy Link

Prolly should make InChan and OutChan private then (I think a few use cases will have to be moved to <- .Next() instead of <- .OutChan() (plugins maybe)

Prolly should make InChan and OutChan private then (I think a few use cases will have to be moved to <- .Next() instead of <- .OutChan() (plugins maybe)
event/eventQueue.go Outdated
@ -32,6 +39,12 @@ func NewSimpleQueue(buffer int) Queue {
return queue
}
func (sq *simpleQueue) Open() bool {
dan commented 2019-11-12 20:45:42 +00:00
Owner
Copy Link

maybe name IsOpen()? this reads a bit as an action

maybe name IsOpen()? this reads a bit as an action
dan closed this pull request 2019-11-12 20:58:48 +00:00
dan closed this pull request 2019-11-12 20:58:48 +00:00
dan deleted branch racefuzz 2019-11-12 20:58:53 +00:00
buildbot commented 2019-11-12 21:03:51 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/704

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/704
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#290
No description provided.
Delete Branch "racefuzz"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?