Drone Build Status: success
like above, prolly better to check at load if the attribute is set or not and set it accordingly instead of the double initializer for it you have in the event handler below. Also since this is a required attribute, should also be added to cwtchPeer.AddContact, line 194 has the attributes being initialized.
then we can create a stream store only where needed, then the event handler can just reach for the stream store and if there is one, use it, if not, not use it, simplifying that code a bunch in the event handler
BUT it does mean then doing processing of the SavePeerHistory event and creating or deleting stream stores there.
but that’s actually good as right now we don’t capture that, so we never delete history when its changed? which means when someone turns it off, the existing history sits there, forever being loaded, but never updated, which isn’t great, so that event does need handling regardless
also prolly want a ps.save after the loop to capture and save any new defaults added
very rust of you? :P
but we can just have hte one empty default
shouldn’t need this if we aren’t setting a default here
also this is copy/pasted, should be pulled out into a function instead
Drone Build Status: failure
No due date set.
This pull request currently doesn't have any dependencies.
Deleting a branch is permanent. It CANNOT be undone. Continue?