Allow Peers to Store History #316

已合併
dan 將 1 次提交從 peer_history 合併至 master 2020-07-08 22:32:48 +00:00
擁有者
No description provided.
dansarah 指派 2020-07-08 18:30:53 +00:00
普通成員
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/769
普通成員
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/771
dan 請求了變更 2020-07-08 19:52:58 +00:00
@ -258,6 +260,10 @@ func (ps *ProfileStoreV1) load() error {
contact.Authorization = model.AuthApproved
}
}
擁有者

like above, prolly better to check at load if the attribute is set or not and set it accordingly instead of the double initializer for it you have in the event handler below. Also since this is a required attribute, should also be added to cwtchPeer.AddContact, line 194 has the attributes being initialized.

then we can create a stream store only where needed, then the event handler can just reach for the stream store and if there is one, use it, if not, not use it, simplifying that code a bunch in the event handler

BUT it does mean then doing processing of the SavePeerHistory event and creating or deleting stream stores there.
but that's actually good as right now we don't capture that, so we never delete history when its changed? which means when someone turns it off, the existing history sits there, forever being loaded, but never updated, which isn't great, so that event does need handling regardless

also prolly want a ps.save after the loop to capture and save any new defaults added

like above, prolly better to check at load if the attribute is set or not and set it accordingly instead of the double initializer for it you have in the event handler below. Also since this is a required attribute, should also be added to cwtchPeer.AddContact, line 194 has the attributes being initialized. then we can create a stream store only where needed, then the event handler can just reach for the stream store and if there is one, use it, if not, not use it, simplifying that code a bunch in the event handler BUT it does mean then doing processing of the SavePeerHistory event and creating or deleting stream stores there. but that's actually good as right now we don't capture that, so we never delete history when its changed? which means when someone turns it off, the existing history sits there, forever being loaded, but never updated, which isn't great, so that event does need handling regardless also prolly want a ps.save after the loop to capture and save any new defaults added
@ -346,0 +368,4 @@
ss.Write(message)
}
}
case event.DontSaveHistoryDefault:
擁有者

very rust of you? :P
but we can just have hte one empty default

very rust of you? :P but we can just have hte one empty default
@ -346,0 +376,4 @@
}
}
}
ps.save()
擁有者

shouldn't need this if we aren't setting a default here

shouldn't need this if we aren't setting a default here
@ -346,0 +382,4 @@
}
case event.NewMessageFromPeer:
contact, exists := ps.profile.GetContact(ev.Data[event.RemotePeer])
if exists {
擁有者

also this is copy/pasted, should be pulled out into a function instead

also this is copy/pasted, should be pulled out into a function instead
sarah 請求了 dan 來審核 2020-07-08 20:26:56 +00:00
普通成員
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/773
普通成員
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/775
sarah 將標題從 WIP: Allow Peers to Store History 改為 Allow Peers to Store History 2020-07-08 21:33:08 +00:00
普通成員
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/777
dan merged commit 2c13feb71e into master 2020-07-08 22:32:48 +00:00
登入 才能加入這對話。
No description provided.