Fixup Integ Test + Limit Messages in Server Memory #36

sarah · 2018-06-08T17:49:18Z

sarah a commenté

2018-06-08 17:49:18 +00:00

.

Propriétaire

Sans contenu.

dan a commenté

2018-06-09 16:31:05 +00:00

.

Propriétaire

? ms.rotated - Maybe "rolledOver"? or wrappedAround?

integ tests:

117 +		time.Sleep(time.Second * 120)

Not needed, the only thing under it is the starting of the 3 peers, and a currently 70 second for their onions to come online too. I stream lined the code a bit this way so they and the test server could come online all at once, before any peering ations were done. If you need just increase the sleep 70 at ~124 to 120

Why did you move the server join down? I had them fire off all those actions in a group so it was streamlined so the integ test ran a bit faster :)

(your 183...)
also the tests shouldnt use log (did t.log actually work tho? maybe I just muted log.) because the first thing i do at the top of the test is mute log since I don't want to see all the trace log code

We may want to make waitForPeerServerConnection and waitForPeerPeerConnection then and remove even more sleeps

? ms.rotated - Maybe "rolledOver"? or wrappedAround? integ tests: 117 + time.Sleep(time.Second * 120) Not needed, the only thing under it is the starting of the 3 peers, and a currently 70 second for their onions to come online too. I stream lined the code a bit this way so they and the test server could come online all at once, before any peering ations were done. If you need just increase the sleep 70 at ~124 to 120 Why did you move the server join down? I had them fire off all those actions in a group so it was streamlined so the integ test ran a bit faster :) (your 183...) also the tests shouldnt use log (did t.log actually work tho? maybe I just muted log.) because the first thing i do at the top of the test is mute log since I don't want to see all the trace log code We may want to make waitForPeerServerConnection and waitForPeerPeerConnection then and remove even more sleeps

dan a commenté

2018-06-09 16:36:46 +00:00

.

Propriétaire

Also I think the file storage needs reworking, we are still just filling the file infinitely and on reload, its still appending to the buffer so it will increase its size well beyond max size

sarah a commenté

2018-06-09 16:41:04 +00:00

.

Auteur

Propriétaire

Yeah I mentioned in the previous PR that I will fixup the file stuff later "This adds a basic circular buffer for messages, still need to rotate the underlying file, but this will prevent memory getting too bloated (partial fix for #22)" handling the file stuff is going to involve much more rework.

t.Log works, the muted log is just for global log stuff in the rest of the library.

I think the Sleeps might be a a debugging thing, I'll remove and retest.

Yeah I mentioned in the previous PR that I will fixup the file stuff later "This adds a basic circular buffer for messages, still need to rotate the underlying file, but this will prevent memory getting too bloated (partial fix for #22)" handling the file stuff is going to involve much more rework. t.Log works, the muted log is just for global log stuff in the rest of the library. I think the Sleeps might be a a debugging thing, I'll remove and retest.

dan a commenté

2018-06-09 16:45:48 +00:00

.

Propriétaire

Then maybe at least comment out the init code loading from the file cus I think it totally breaks everything :)