Fixup Integ Test + Limit Messages in Server Memory #36
无审核者
标签
未选择标签
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
未选择里程碑
2 名参与者
通知
到期时间
未设置到期时间。
依赖工单
没有设置依赖项。
参考:cwtch.im/cwtch#36
正在加载...
在新工单中引用
没有提供说明。
删除分支 integ_test_fix
删除分支是永久的。虽然已删除的分支在实际被删除前有可能会短时间存在,但这在大多数情况下无法撤销。是否继续?
? ms.rotated - Maybe "rolledOver"? or wrappedAround?
integ tests:
Not needed, the only thing under it is the starting of the 3 peers, and a currently 70 second for their onions to come online too. I stream lined the code a bit this way so they and the test server could come online all at once, before any peering ations were done. If you need just increase the sleep 70 at ~124 to 120
Why did you move the server join down? I had them fire off all those actions in a group so it was streamlined so the integ test ran a bit faster :)
(your 183...)
also the tests shouldnt use log (did t.log actually work tho? maybe I just muted log.) because the first thing i do at the top of the test is mute log since I don't want to see all the trace log code
We may want to make waitForPeerServerConnection and waitForPeerPeerConnection then and remove even more sleeps
Also I think the file storage needs reworking, we are still just filling the file infinitely and on reload, its still appending to the buffer so it will increase its size well beyond max size
Yeah I mentioned in the previous PR that I will fixup the file stuff later "This adds a basic circular buffer for messages, still need to rotate the underlying file, but this will prevent memory getting too bloated (partial fix for #22)" handling the file stuff is going to involve much more rework.
t.Log works, the muted log is just for global log stuff in the rest of the library.
I think the Sleeps might be a a debugging thing, I'll remove and retest.
Then maybe at least comment out the init code loading from the file cus I think it totally breaks everything :)
Removed sleeps and put calls back to where they were, reverted t.Log.
We talked about the server stuff offline, leaving unchanged.