cwtch.im
/
cwtch
16
20
Fork 16
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Group Refactor Part 1 #399

Merged
sarah merged 4 commits from group_refactor into master 2021-11-01 21:44:58 +00:00
Conversation 5 Commits 4 Files Changed 10 +153 -150
sarah commented 2021-10-31 19:13:45 +00:00
Owner
Copy Link

Remove SendMessage* calls in place of a unified interface
Remove Unack*Messages from Group and Store everything in the timeline

Remove SendMessage* calls in place of a unified interface Remove Unack*Messages from Group and Store everything in the timeline
dan was assigned by sarah 2021-10-31 19:13:45 +00:00
erinn was assigned by sarah 2021-10-31 19:13:45 +00:00
sarah added 1 commit 2021-10-31 19:13:46 +00:00
continuous-integration/drone/push Build is pending Details
continuous-integration/drone/pr Build is pending Details
3d2cafd1de Group Refactor Part 1 
Remove SendMessage* calls in place of a unified interface
Remove Unack*Messages from Group and Store everything in the timeline
sarah added 1 commit 2021-10-31 19:13:51 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
fbfef2d907 Merge branch 'master' into group_refactor
sarah added 1 commit 2021-10-31 19:17:30 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
ead6a2698f JoinServer errors should result in Error log
buildbot commented 2021-10-31 19:30:57 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/439

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/439
buildbot commented 2021-10-31 19:31:34 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/437

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/437
buildbot commented 2021-10-31 22:03:55 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/440

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/440
buildbot commented 2021-11-01 16:41:17 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/441

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/441
erinn approved these changes 2021-11-01 20:45:49 +00:00
dan approved these changes 2021-11-01 21:06:43 +00:00
model/group.go Outdated
@ -146,0 +143,4 @@
length := len(g.Timeline.Messages)
if len(g.Timeline.Messages) > index {
dan commented 2021-11-01 20:48:47 +00:00
Owner
Copy Link

why not use "length" var

why not use "length" var
model/group.go Outdated
@ -146,2 +147,3 @@
return true, g.Timeline.Messages[index], length
}
return false
return false, Message{}, len(g.Timeline.Messages)
dan commented 2021-11-01 20:48:33 +00:00
Owner
Copy Link

why not use "length" var?

why not use "length" var?
sarah added 1 commit 2021-11-01 21:10:10 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is failing Details
c62ecd6f71 Use length variable, Comment deprecation of GetOnion
buildbot commented 2021-11-01 21:19:17 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/443

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/443
sarah merged commit 126953f5ed into master 2021-11-01 21:44:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
erinn
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
erinn
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#399
No description provided.
Delete Branch "group_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?