changePassword #414

Merged
sarah merged 4 commits from changePassword into master 2021-12-19 01:12:25 +00:00
Owner
No description provided.
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/590
dan reviewed 2021-12-18 17:45:46 +00:00
@ -83,0 +87,4 @@
defer cp.mutex.Unlock()
db, err := openEncryptedDatabase(cp.storage.ProfileDirectory, password, false)
if db == nil || err != nil {
return errors.New("invalid_password")
Owner

const-ify so receiver can check type of error.

const-ify so receiver can check type of error.
sarah marked this conversation as resolved
@ -83,0 +106,4 @@
log.Infof("rekeying database...")
return cp.storage.Rekey(rekey)
}
return errors.New("passwords_do_not_match")
Owner

make const so receiver can check against error types

make const so receiver can check against error types
sarah marked this conversation as resolved
@ -164,6 +164,17 @@ func TestCwtchPeerIntegration(t *testing.T) {
alice.PeerWithOnion(bob.GetOnion())
alice.PeerWithOnion(carol.GetOnion())
// Test that we can rekey alice without issues...
Owner

this could be a unit test no?

this could be a unit test no?
Author
Owner

the point of this test was to prove that rekeying while everything was active wouldn't break any existing flows.

the point of this test was to prove that rekeying while everything was active wouldn't break any existing flows.
sarah marked this conversation as resolved
sarah force-pushed changePassword from fadb2bb4b9 to 46f32881b9 2021-12-19 00:48:34 +00:00 Compare
sarah added 1 commit 2021-12-19 00:51:48 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is failing Details
aa98ef0e5e
Add Constants
sarah changed title from WIP: changePassword to changePassword 2021-12-19 00:52:38 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/617
sarah added 1 commit 2021-12-19 00:55:21 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
8a273d3310
Rekey comment
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/619
dan approved these changes 2021-12-19 01:07:18 +00:00
sarah merged commit c035ab52bc into master 2021-12-19 01:12:25 +00:00
Sign in to join this conversation.
No description provided.