remove unused events (libcwtch-rs audit); add anti dup on import #449

Merged
sarah merged 4 commits from cleanAndNoDupImport into master 2022-07-30 23:33:06 +00:00
Owner
No description provided.
dan added 1 commit 2022-07-30 00:24:59 +00:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
56cf2b7bf6
remove unused events (libcwtch-rs audit); add anti dup on import
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/820
dan added 1 commit 2022-07-30 00:37:46 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
b64229c8b7
delete engine.deleteConnection (unused)
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/822
sarah reviewed 2022-07-30 02:23:14 +00:00
@ -483,8 +483,14 @@ func (cp *cwtchPeer) ImportGroup(exportedInvite string) (int, error) {
return -1, err
}
cp.mutex.Lock()
conversationInfo, err := cp.storage.GetConversationByHandle(gci.GroupID)
Owner

ineffectual err assignment?

ineffectual err assignment?
@ -486,0 +486,4 @@
conversationInfo, err := cp.storage.GetConversationByHandle(gci.GroupID)
if conversationInfo != nil {
cp.mutex.Unlock()
return -1, err
Owner

this err is incorrect, should create a new error using fmt.Errorf etc.

this err is incorrect, should create a new error using fmt.Errorf etc.
@ -506,0 +512,4 @@
cp.eventBus.Publish(event.NewEvent(event.ContactCreated, map[event.Field]string{event.ConversationID: strconv.Itoa(conversationID), event.RemotePeer: handle}))
return conversationID, err
}
return -1, err
Owner

err will be nil, should create a new error here fmt.Errorf("contact with handle already exists...")

err will be nil, should create a new error here fmt.Errorf("contact with handle already exists...")
dan added 1 commit 2022-07-30 07:19:22 +00:00
continuous-integration/drone/push Build is pending Details
continuous-integration/drone/pr Build is pending Details
3dc5dbb38e
fix errs
dan added 1 commit 2022-07-30 23:05:45 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
60caa08868
readd deletecontact and wire in
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/826
sarah approved these changes 2022-07-30 23:33:03 +00:00
sarah merged commit b95c2c12eb into master 2022-07-30 23:33:06 +00:00
Sign in to join this conversation.
No description provided.