Large API Refactor in prep for autobindings #494
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#494
Loading…
Reference in New Issue
No description provided.
Delete Branch "autobindings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -41,3 +41,1 @@
CreatePeer(name string, password string, attributes map[attr.ZonedPath]string)
// Deprecated in 1.10
CreateTaggedPeer(name string, password string, tag string)
CreateProfile(name string, password string, autostart bool)
should take the
attributes map[attr.ZonedPath]string
we've had to extend this twice, once for tags on default or no default password, and then autostart or not, so to future proof, should take the attribute map or else it's likely as we continue to build we'll have to extend the API again
@ -162,0 +176,4 @@
if !autostart {
autostartVal = constants.False
}
tagVal := constants.ProfileTypeV1Password
this cannot be assumed, it depends if the password is the app default password or not, otherwise it's contstants.ProfileTypeV1DefaultPassword cus the user chose not to set a password. lcg was i beleive doing a comparison of password to the defetaul to determine the value and pass that in as autostart earlier then the direct attribute when we moved to the map
@ -52,3 +52,3 @@
ActivateEngines(doListn, doPeers, doServers bool)
ActivatePeerEngine(onion string, doListen, doPeers, doServers bool)
ActivatePeerEngine(onion string)
why are we dropping
doListen, doPeers, doServers
? they were added with the intention of furthering support for various profile run modes, like "invisible" that isn't listening@ -69,3 +69,2 @@
// NewApp creates a new app with some environment awareness and initializes a Tor Manager
func NewApp(acn connectivity.ACN, appDirectory string) Application {
func InitApp(appDirectory string) *GlobalSettingsFile {
what's the invocation of InitApp look like?
nevermind, probably just rename ReadSettings
@ -42,3 +42,3 @@
func (pne ProfileValueExtension) OnContactRequestValue(profile peer.CwtchPeer, conversation model.Conversation, eventID string, szp attr.ScopedZonedPath) {
scope, zone, zpath := szp.GetScopeZonePath()
log.Debugf("Looking up public | conversation scope/zone %v", szp.ToString())
log.Infof("Looking up public | conversation scope/zone %v", szp.ToString())
debug
@ -75,6 +75,94 @@ type cwtchPeer struct {
experimentsLock sync.Mutex
}
func (cp *cwtchPeer) EnhancedImportBundle(importString string) string {
what's this for? Seems a weird "enhancement" that doesnt return an error just the string of the error?
@ -122,2 +128,4 @@
UpdateMessageAttribute(conversation int, channel int, id int, key string, value string) error
// EnhancedGetMessageById returns a json-encoded enhanced message, suitable for rendering in a UI
EnhancedGetMessageById(conversation int, mid int) string
ah by enhanced you mean with all the extra stuff lg was injecting? i slightly like the term "enriched" or possibly something else? but enhanced more or less conveys the same too, to preference or taste i guess :)
@ -35,3 +35,3 @@
return
}
log.Debugf("sharing file: %v %v", fileKey, serializedManifest)
log.Infof("sharing file: %v %v", fileKey, serializedManifest)
debug?
WIP: Large API Refactor in prep for autobindingsto Large API Refactor in prep for autobindings