Profile Images (+ Testing Improvements) #68

Merged
erinn merged 9 commits from profile_images into trunk 2022-02-04 21:56:35 +00:00
Owner
No description provided.
dan was assigned by sarah 2022-02-03 23:17:56 +00:00
erinn was assigned by sarah 2022-02-03 23:17:56 +00:00
sarah added 4 commits 2022-02-03 23:17:57 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/219
sarah added 1 commit 2022-02-04 00:11:56 +00:00
continuous-integration/drone/pr Build is pending Details
2e9f9fb14f
Update Cwtch with new ShareFile API
dan reviewed 2022-02-04 00:19:28 +00:00
lib.go Outdated
@ -210,6 +210,10 @@ func _startCwtch(appDir string, torPath string) {
LaunchServers()
// Send global settings to the UI...
if application == nil {

we should protect application with a mutex if this is a worry. we access it like 10 lines up, assign it not a lot higher etc. if we're worried about a second thread replacing it that fast, we should have a protection mutex

we should protect application with a mutex if this is a worry. we access it like 10 lines up, assign it not a lot higher etc. if we're worried about a second thread replacing it that fast, we should have a protection mutex
dan marked this conversation as resolved
@ -426,6 +485,10 @@ func unwrap(original *EventProfileEnvelope) *event.Event {
func (eh *EventHandler) startHandlingPeer(onion string) {
eventBus := eh.app.GetEventBus(onion)
// if eventBus == nil {

uncomment?

uncomment?
sarah marked this conversation as resolved
sarah added 1 commit 2022-02-04 00:22:35 +00:00
continuous-integration/drone/pr Build is pending Details
d40900481a
remove old testing code
dan reviewed 2022-02-04 00:28:09 +00:00
@ -412,0 +442,4 @@
zone, path := attr.ParseZone(path)
// auto download profile images from contacts...
settings := ReadGlobalSettings()

check if the ret type is CustomProfileImage before mandatorily Reading Globals from FS on eath NewRetValMessageFromPeer?

check if the ret type is CustomProfileImage before mandatorily Reading Globals from FS on eath NewRetValMessageFromPeer?
sarah added 1 commit 2022-02-04 20:49:04 +00:00
sarah added 1 commit 2022-02-04 21:33:43 +00:00
continuous-integration/drone/pr Build is failing Details
fc9999f835
Upgrade Cwtch
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/libcwtch-go/224
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/libcwtch-go/225
sarah force-pushed profile_images from 95899de0c8 to a9563b615c 2022-02-04 21:49:34 +00:00 Compare
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/226
erinn approved these changes 2022-02-04 21:56:30 +00:00
@ -129,0 +139,4 @@
e.Data[constants2.Picture], _ = profile.GetScopedZonedAttribute(attr.LocalScope, attr.FilesharingZone, fmt.Sprintf("%s.path", key))
serializedManifest, _ := profile.GetScopedZonedAttribute(attr.ConversationScope, attr.FilesharingZone, fmt.Sprintf("%s.manifest", key))
profile.ShareFile(key, serializedManifest)
log.Infof("Custom Profile Image: %v %s", e.Data[constants2.Picture], serializedManifest)

debug

debug
erinn merged commit 4e4e3315dd into trunk 2022-02-04 21:56:35 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/227
This repo is archived. You cannot comment on pull requests.
No reviewers
No Label
No Milestone
No Assignees
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/libcwtch-go#68
No description provided.