filesharing #28

Merged
dan merged 7 commits from filesharing into trunk 2 months ago
erinn commented 2 months ago
Owner
There is no content yet.
dan was assigned by erinn 2 months ago
sarah was assigned by erinn 2 months ago
erinn added 2 commits 2 months ago
dan requested changes 2 months ago
dan left a comment
  • delete the message enevelop here and start using the cwtch one
  • there's functionality gate stuff here right? port to the cwtch version
Owner

delete the message enevelop here and start using the cwtch one
there's functionality gate stuff here right? port to the cwtch version

I think we should hold off on this for now. There is already quite a bit of complexity in this release and it doesn't make sense to roll in another layer of refactoring. I think it would probably be better to slowly port these in Cwtch over time (e.g. next on the agenda is thinking about hybrid groups which will touch on invitations and overlays and doing the refactoring of that code then makes more sense).

> delete the message enevelop here and start using the cwtch one > there's functionality gate stuff here right? port to the cwtch version I think we should hold off on this for now. There is already quite a bit of complexity in this release and it doesn't make sense to roll in another layer of refactoring. I think it would probably be better to slowly port these in Cwtch over time (e.g. next on the agenda is thinking about hybrid groups which will touch on invitations and overlays and doing the refactoring of that code then makes more sense).
Owner

I guess to me having dual implementations seems like more complexity as future interversions might miss one and be subtly bugged?

I guess to me having dual implementations seems like more complexity as future interversions might miss one and be subtly bugged?
erinn added 1 commit 2 months ago
24b72da0cc adding CheckDownloadStatus
sarah added 1 commit 2 months ago
1b4d3435ad Remove Failing Peer Calls
sarah added 1 commit 2 months ago
b2deb52a8c Upgrade Cwtch
sarah changed title from WIP: filesharing to filesharing 2 months ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/79
sarah approved these changes 2 months ago
sarah added 1 commit 2 months ago
2145d38d15 Formatting + Nick Request Checks
sarah added 1 commit 2 months ago
3aac1dd47a Contact nil checking
dan approved these changes 2 months ago
dan merged commit 495c4390c7 into trunk 2 months ago
dan referenced this issue from a commit 2 months ago

Reviewers

sarah approved these changes 2 months ago
dan approved these changes 2 months ago
continuous-integration/drone/pr Build is failing
The pull request has been merged as 495c4390c7.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.