cwtch.im
/
libcwtch-go
Archived
3
0
Fork 1
Code Issues 2 Pull Requests Releases 26 Wiki Activity

filesharing #28

Merged
dan merged 7 commits from filesharing into trunk 2021-09-30 17:21:37 +00:00
Conversation 3 Commits 7 Files Changed 6 +99 -88
erinn commented 2021-09-23 20:51:30 +00:00
Owner
Copy Link
No description provided.
dan was assigned by erinn 2021-09-23 20:51:30 +00:00
sarah was assigned by erinn 2021-09-23 20:51:30 +00:00
erinn added 2 commits 2021-09-23 20:51:31 +00:00
dan requested changes 2021-09-23 23:38:11 +00:00
dan left a comment
Owner
  • delete the message enevelop here and start using the cwtch one
  • there's functionality gate stuff here right? port to the cwtch version
- delete the message enevelop here and start using the cwtch one - there's functionality gate stuff here right? port to the cwtch version
sarah commented 2021-09-24 20:08:57 +00:00
Owner
Copy Link

delete the message enevelop here and start using the cwtch one
there's functionality gate stuff here right? port to the cwtch version

I think we should hold off on this for now. There is already quite a bit of complexity in this release and it doesn't make sense to roll in another layer of refactoring. I think it would probably be better to slowly port these in Cwtch over time (e.g. next on the agenda is thinking about hybrid groups which will touch on invitations and overlays and doing the refactoring of that code then makes more sense).

> delete the message enevelop here and start using the cwtch one > there's functionality gate stuff here right? port to the cwtch version I think we should hold off on this for now. There is already quite a bit of complexity in this release and it doesn't make sense to roll in another layer of refactoring. I think it would probably be better to slowly port these in Cwtch over time (e.g. next on the agenda is thinking about hybrid groups which will touch on invitations and overlays and doing the refactoring of that code then makes more sense).
dan commented 2021-09-24 20:19:54 +00:00
Owner
Copy Link

I guess to me having dual implementations seems like more complexity as future interversions might miss one and be subtly bugged?

I guess to me having dual implementations seems like more complexity as future interversions might miss one and be subtly bugged?
erinn added 1 commit 2021-09-29 20:30:25 +00:00
continuous-integration/drone/pr Build is pending Details
24b72da0cc adding CheckDownloadStatus
sarah added 1 commit 2021-09-30 00:30:12 +00:00
continuous-integration/drone/pr Build is failing Details
1b4d3435ad Remove Failing Peer Calls
sarah added 1 commit 2021-09-30 00:59:20 +00:00
continuous-integration/drone/pr Build is passing Details
b2deb52a8c Upgrade Cwtch
sarah changed title from WIP: filesharing to filesharing 2021-09-30 00:59:36 +00:00
buildbot commented 2021-09-30 03:15:01 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/libcwtch-go/79

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/79
sarah approved these changes 2021-09-30 16:50:22 +00:00
sarah added 1 commit 2021-09-30 17:17:48 +00:00
continuous-integration/drone/pr Build is pending Details
2145d38d15 Formatting + Nick Request Checks
sarah added 1 commit 2021-09-30 17:19:05 +00:00
continuous-integration/drone/pr Build is failing Details
3aac1dd47a Contact nil checking
dan approved these changes 2021-09-30 17:20:52 +00:00
dan merged commit 495c4390c7 into trunk 2021-09-30 17:21:37 +00:00
dan referenced this issue from a commit 2021-09-30 17:21:37 +00:00
filesharing (#28)
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
sarah
dan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
sarah
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/libcwtch-go#28
No description provided.
Delete Branch "filesharing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?