cwtch.im
/
tapir
5
3
Fork 3
Code Issues 2 Pull Requests Releases 45 Wiki Activity

Fixing a Bug where Multiple Active Connections are being waited on #14

Merged
dan merged 1 commits from bugfix into master 2020-03-20 00:23:31 +00:00
Conversation 2 Commits 1 Files Changed 2 +22 -21
sarah commented 2020-03-20 00:06:35 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2020-03-20 00:06:35 +00:00
dan commented 2020-03-20 00:16:40 +00:00
Owner
Copy Link

the sleep should go inside the if err != nil as there's no reason to sleep before get if there's no err and we're not getting

the sleep should go inside the `if err != nil` as there's no reason to sleep before get if there's no err and we're not getting
sarah commented 2020-03-20 00:21:09 +00:00
Author
Owner
Copy Link

the sleep should go inside the if err != nil as there's no reason to sleep before get if there's no err and we're not getting

The sleep is to prevent spinlocking so we don't just burn processor time continually checking for a capability, we wait a little bit and then try again (as a bonus it prevents us from continually calling GetConnection which is expensive but that isn't the main point)

> the sleep should go inside the `if err != nil` as there's no reason to sleep before get if there's no err and we're not getting The sleep is to prevent spinlocking so we don't just burn processor time continually checking for a capability, we wait a little bit and then try again (as a bonus it prevents us from continually calling GetConnection which is expensive but that isn't the main point)
dan closed this pull request 2020-03-20 00:23:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/tapir#14
No description provided.
Delete Branch "bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?