cwtch.im
/
tapir
5
3
Fork 3
Code Issues 2 Pull Requests Releases 45 Wiki Activity

Replace extra25519 #16

Merged
sarah merged 1 commits from bugfix into master 2020-03-28 03:18:13 +00:00
Conversation 12 Commits 1 Files Changed 8 +127 -29
sarah commented 2020-03-21 19:46:32 +00:00
Owner
Copy Link

There is no nice library that does ed25519 to curve25519 conversions, which we need to do EDH over tor onions (which use ed25519 public keys)

~~We used to use AGLs extra25519 library but this was recently deprecated. As such the following functions have been taken from SUPERCOP.
~~

After benchmarking the age implementation that uses bignums it's a little faster than the flattened custom feild implementation pulled from extra25519 and much more concise and understandable.

Erinn needs to review.

There is no nice library that does ed25519 to curve25519 conversions, which we need to do EDH over tor onions (which use ed25519 public keys) ~~We used to use AGLs extra25519 library but this was recently deprecated. As such the following functions have been taken from SUPERCOP. ~~ After benchmarking the age implementation that uses bignums it's a little faster than the flattened custom feild implementation pulled from extra25519 and much more concise and understandable. Erinn needs to review.
dan was assigned by sarah 2020-03-21 19:46:32 +00:00
erinn was assigned by sarah 2020-03-21 19:46:32 +00:00
sarah changed title from WIP: Replace extra25519 - Here be Dragons to WIP: Replace extra25519 2020-03-24 17:34:54 +00:00
dan commented 2020-03-24 17:40:43 +00:00
Owner
Copy Link

👍 lgtm

:thumbsup: lgtm
erinn commented 2020-03-27 21:57:50 +00:00
Owner
Copy Link

(gave one comment irl about a missing return, then lgtm!)

(gave one comment irl about a missing return, then lgtm!)
sarah changed title from WIP: Replace extra25519 to Replace extra25519 2020-03-27 21:58:58 +00:00
buildbot commented 2020-03-27 21:59:17 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/179

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/179
buildbot commented 2020-03-27 21:59:20 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/180

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/180
buildbot commented 2020-03-27 22:08:47 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/183

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/183
buildbot commented 2020-03-27 22:08:52 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/184

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/184
buildbot commented 2020-03-27 22:15:27 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/188

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/188
buildbot commented 2020-03-27 22:15:50 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/tapir/187

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/187
buildbot commented 2020-03-28 00:38:51 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/tapir/191

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/191
buildbot commented 2020-03-28 00:40:10 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/tapir/192

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/192
buildbot commented 2020-03-28 00:44:46 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/tapir/196

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/196
buildbot commented 2020-03-28 00:44:48 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/tapir/195

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/195
sarah closed this pull request 2020-03-28 03:18:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
erinn
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/tapir#16
No description provided.
Delete Branch "bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?