Add Broadcast #23

Merged
dan merged 4 commits from broadcast into master 2020-07-14 22:05:54 +00:00
Owner
No description provided.
dan was assigned by sarah 2020-07-14 21:24:20 +00:00
sarah changed title from Add Broacast to Add Broadcast 2020-07-14 21:28:52 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/239
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/240
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/tapir/244
dan reviewed 2020-07-14 21:54:26 +00:00
service.go Outdated
@ -56,3 +59,3 @@
// NewConnection creates a new Connection
func NewConnection(id *primitives.Identity, hostname string, outbound bool, conn io.ReadWriteCloser, app Application) Connection {
func NewConnection(id *primitives.Identity, hostname string, outbound bool, conn io.ReadWriteCloser, app Application, service Service) Connection {
Owner

can we change the sig to

NewConnection(service Service, hostname string, outbound bool, conn io.ReadWriteCloser, app Application)

and either not need to store .identity or just pull it from service.id or service.getNewConnectionID() (we seem to use the former in connect and the latter in listen)

can we change the sig to ```NewConnection(service Service, hostname string, outbound bool, conn io.ReadWriteCloser, app Application)``` and either not need to store .identity or just pull it from service.id or service.getNewConnectionID() (we seem to use the former in connect and the latter in listen)
Author
Owner

Fixed the signature, can't get rid of id yet (see: #20)

Fixed the signature, can't get rid of id yet (see: https://git.openprivacy.ca/cwtch.im/tapir/issues/20)
@ -63,3 +66,3 @@
connection.identity = id
connection.outbound = outbound
connection.MaxLength = 1024
connection.MaxLength = 8192
Owner

Could be a top of file const, or not, just a thought

Could be a top of file const, or not, just a thought
Author
Owner

Will be addressing this #22

Will be addressing this https://git.openprivacy.ca/cwtch.im/tapir/issues/22
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/247
dan merged commit 28b2f8212f into master 2020-07-14 22:05:54 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/248
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/tapir#23
No description provided.