cwtch.im
/
tapir
5
3
Fork 3
Code Issues 2 Pull Requests Releases 45 Wiki Activity

Actively Deduplicate Connections on WaitForCapabilityOrClose #40

Merged
dan merged 2 commits from dedupe into master 2021-09-08 20:36:38 +00:00
Conversation 1 Commits 2 Files Changed 1 +26 -7
sarah commented 2021-09-08 18:57:49 +00:00
Owner
Copy Link

A very rare bug happens when 2 contacts peer with each other at the same
time. This results in duplicate higher level constructs like PeerApp
which can make tracking state-related bugs difficult, especially
in integration tests.

This commit fixes an existing bug in WaitForCapabilityOrClose
which hid the existence of a duplicate connections from clients
(and replaces it with active deduping)

A very rare bug happens when 2 contacts peer with each other at the same time. This results in duplicate higher level constructs like PeerApp which can make tracking state-related bugs difficult, especially in integration tests. This commit fixes an existing bug in WaitForCapabilityOrClose which hid the existence of a duplicate connections from clients (and replaces it with active deduping)
dan was assigned by sarah 2021-09-08 18:57:49 +00:00
sarah added 1 commit 2021-09-08 18:57:50 +00:00
continuous-integration/drone/push Build is pending Details
continuous-integration/drone/pr Build is pending Details
c19b1011ee Actively Deduplicate Connections on WaitForCapabilityOrClose 
A very rare bug happens when 2 contacts peer with each other at the same
time. This results in duplicate higher level constructs like PeerApp
which can make tracking state-related bugs difficult, especially
in integration tests.

This commit fixes an existing bug in WaitForCapabilityOrClose
which hid the existence of a duplicate connections from clients
(and replaces it with active deduping)
sarah added 1 commit 2021-09-08 18:57:57 +00:00
continuous-integration/drone/push Build is pending Details
continuous-integration/drone/pr Build is passing Details
364521e4c1 Merge branch 'master' into dedupe
buildbot commented 2021-09-08 19:56:38 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/tapir/82

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/tapir/82
dan merged commit 0845156bea into master 2021-09-08 20:36:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/tapir#40
No description provided.
Delete Branch "dedupe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?