[Unsent] messages to offline contacts erroneously marked as [pending] #123

New Issue

CwtchEnthusiast · 2019-02-23T19:49:59Z

CwtchEnthusiast commented

2019-02-23 19:49:59 +00:00

When I try to send a peer-to-peer message to a contact that is offline, the message is displayed as pending at first, but then the client tries to reconnect to the peer and the message gets marked as "acknowledged," although the contact is still offline (and displayed as such).

Related to #120, maybe?

When I try to send a peer-to-peer message to a contact that is offline, the message is displayed as pending at first, but then the client tries to reconnect to the peer and the message gets marked as "acknowledged," although the contact is still offline (and displayed as such). Related to #120, maybe?

sarah commented

2019-03-05 20:29:28 +00:00

This is now fixed in the continuous builds, will be released as part of 1.0.3

CwtchEnthusiast commented

2019-03-05 23:43:19 +00:00

It's fixed.
However, messages that were marked (correctly) as "could not send" sometimes change to "pending" now on re-selection of the offline contact and then stay that way. I'm not sure if that is the desired behavior.

It's fixed. However, messages that were marked (correctly) as "could not send" sometimes change to "pending" now on re-selection of the offline contact and then stay that way. I'm not sure if that is the desired behavior.

sarah commented

2019-03-05 23:46:08 +00:00

Ah, thanks, I was worried that bug was still lurking somewhere, but I couldn't replicate it. I'll take a look again tomorrow to see if I can work out why this is happening.

CwtchEnthusiast commented

2019-03-06 00:38:58 +00:00

Screenshot w.r.t. new behavior.

pending.png

5.8 KiB

sarah commented

2019-03-06 21:09:12 +00:00

Note to self: I believe that the main manifestation of this bug is caused by the initial ack of a successfully delivered message failing to send.

The only way I can see of fixing this is dropping the double connection setup and using the successfully connected channel for messages.

Note to self: I believe that the main manifestation of this bug is caused by the initial ack of a successfully delivered message failing to send. The only way I can see of fixing this is dropping the double connection setup and using the successfully connected channel for messages.

sarah commented

2019-08-13 17:30:18 +00:00

Fixed with Tapir (will be available in the upcoming 0.2 release or see the continuous builds for a pre-release) and various UX fixes over the last 5 months.

Acknowledgements are now embedded in the protocol (and the channels are bidirectional).

Fixed with Tapir (will be available in the upcoming 0.2 release or see the continuous builds for a pre-release) and various UX fixes over the last 5 months. Acknowledgements are now embedded in the protocol (and the channels are bidirectional).

sarah closed this issue

2019-08-13 17:30:18 +00:00

This repo is archived. You cannot comment on issues.