Peer History Save & Lists Refresh #315
No reviewers
Labels
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
No Milestone
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/ui#315
Loading…
Reference in New Issue
No description provided.
Delete Branch "peer-save"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is based on the blocked changes and my list sketch so it's a little cluttered, will be queued behind the others and then I will rebase
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/ui/605
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/ui/611
WIP: peer-saveto Peer History Save & Lists RefreshDrone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/613
@ -350,2 +352,3 @@
this.SupplyPeerSettings(contact.Onion, name, string(contact.Authorization))
// Whether Cwtch should save the history of the peer
saveHistory,exists := contact.GetAttribute(event.SaveHistoryKey)
ah. I have a quibble about this but its also an oversight on my part from the cwtch PR about this. mostly we've been doing
peer.GetAttribute(attr.GetSettingsScope(constants.ShowBlocked))
wrapping keys in a certain scope, not just leaving them "scopeless" in the attribute space, but I missed this in cwtch.im/cwtch#316
So not sure if you feel it's worth going back to bring in line or just let be
@ -26,3 +27,1 @@
style: CwtchTextFieldStyle{}
visible:listpanel.online
we prolly want to move this up a level, making each overlay handle offline/online seems like a painful duplication, could just pull out of this PR for now if it's a problem?
@ -111,2 +140,4 @@
txtDisplayName.text = nick
root.authorization = authorization
root.saveHistory = saveHistory
console.log(root.saveHistory)
don't need this console.log
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/615