Peer History Save & Lists Refresh #315

					
				@ -350,2 +352,3 @@

					this.SupplyPeerSettings(contact.Onion, name, string(contact.Authorization))

					// Whether Cwtch should save the history of the peer

					saveHistory,exists := contact.GetAttribute(event.SaveHistoryKey)

dan commented

2020-07-21 17:55:24 +00:00

ah. I have a quibble about this but its also an oversight on my part from the cwtch PR about this. mostly we've been doing

peer.GetAttribute(attr.GetSettingsScope(constants.ShowBlocked))

wrapping keys in a certain scope, not just leaving them "scopeless" in the attribute space, but I missed this in cwtch.im/cwtch#316

So not sure if you feel it's worth going back to bring in line or just let be

ah. I have a quibble about this but its also an oversight on my part from the cwtch PR about this. mostly we've been doing ```peer.GetAttribute(attr.GetSettingsScope(constants.ShowBlocked))``` wrapping keys in a certain scope, not just leaving them "scopeless" in the attribute space, but I missed this in https://git.openprivacy.ca/cwtch.im/cwtch/pulls/316 So not sure if you feel it's worth going back to bring in line or just let be

qml/overlays/ListOverlay.qml Outdated

					
				@ -26,3 +27,1 @@

				        style: CwtchTextFieldStyle{}

				        visible:listpanel.online

dan commented

2020-07-21 18:04:57 +00:00

we prolly want to move this up a level, making each overlay handle offline/online seems like a painful duplication, could just pull out of this PR for now if it's a problem?

qml/panes/PeerSettingsPane.qml Outdated

					
				@ -111,2 +140,4 @@

				            txtDisplayName.text = nick

				            root.authorization = authorization

				            root.saveHistory = saveHistory

				            console.log(root.saveHistory)