Experimental Gating + Server List Sketch #351
No reviewers
Labels
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
No Milestone
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/ui#351
Loading…
Reference in New Issue
No description provided.
Delete Branch "serverpane"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Requires Opaque PR: openprivacy/opaque#18 and openprivacy/opaque#19
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/704
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/706
looks good! just minor comments
@ -0,0 +41,4 @@
func (sm * ServerManager) ListServers(gcd *ui.GrandCentralDispatcher) {
log.Debugf("Listing Servers...")
gcd.AddServer("Server 1","Server 1","server",0)
comment with like // testing content TODO delete ?
@ -126,2 +159,4 @@
onSupplySettings: function(locale, zoom, theme) {
let experimentsMap = Utils.buildMap(gcd.experiments);
console.log("MAP: "+JSON.stringify(gcd.experiments) + " " + JSON.stringify(experimentsMap));
prolly don't need?
@ -0,0 +42,4 @@
size: parent.height * 0.5
onClicked: {
serverAddEditPane.load(handle, displayName, status)
like profiles, you prolly want a reset() function first on the pane that sets it to default state for add, then optional load() for edit
@ -0,0 +53,4 @@
}
onClicked: function openClick(handle) {
// gcd.broadcast("ResetMessagePane");
delete?
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/711
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/713