Experimental Gating + Server List Sketch #351

Merged
dan merged 1 commits from serverpane into master 2020-10-28 19:35:56 +00:00
Owner
Requires Opaque PR: https://git.openprivacy.ca/openprivacy/opaque/pulls/18 and https://git.openprivacy.ca/openprivacy/opaque/pulls/19
dan was assigned by sarah 2020-10-26 20:31:50 +00:00
erinn was assigned by sarah 2020-10-26 20:31:50 +00:00
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/704

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/704
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/706

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/706
dan reviewed 2020-10-26 22:01:13 +00:00
dan left a comment
Owner

looks good! just minor comments

looks good! just minor comments
@ -0,0 +41,4 @@
func (sm * ServerManager) ListServers(gcd *ui.GrandCentralDispatcher) {
log.Debugf("Listing Servers...")
gcd.AddServer("Server 1","Server 1","server",0)

comment with like // testing content TODO delete ?

comment with like // testing content TODO delete ?
@ -126,2 +159,4 @@
onSupplySettings: function(locale, zoom, theme) {
let experimentsMap = Utils.buildMap(gcd.experiments);
console.log("MAP: "+JSON.stringify(gcd.experiments) + " " + JSON.stringify(experimentsMap));

prolly don't need?

prolly don't need?
@ -0,0 +42,4 @@
size: parent.height * 0.5
onClicked: {
serverAddEditPane.load(handle, displayName, status)

like profiles, you prolly want a reset() function first on the pane that sets it to default state for add, then optional load() for edit

like profiles, you prolly want a reset() function first on the pane that sets it to default state for add, then optional load() for edit
@ -0,0 +53,4 @@
}
onClicked: function openClick(handle) {
// gcd.broadcast("ResetMessagePane");

delete?

delete?
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/711

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/711
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/713

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/713
dan merged commit fec49cf1fd into master 2020-10-28 19:35:56 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.