Proper delete support from Cwtch (also remove fake delete) #195

dan · 2019-08-07T05:35:54Z

dan commented

2019-08-07 05:35:54 +00:00

so the cwtch backend didn't respect this attribute delete so it kept trying to make the connections.

This now adopts the proper delete support from
cwtch.im/cwtch#265

And removes the fake one, so fake deleted contacts will reappear so they can be properly deleted

so the cwtch backend didn't respect this attribute delete so it kept trying to make the connections. This now adopts the proper delete support from https://git.openprivacy.ca/cwtch.im/cwtch/pulls/265 And removes the fake one, so fake deleted contacts will reappear so they can be properly deleted

buildbot commented

2019-08-07 05:40:49 +00:00

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/246

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/246

buildbot commented

2019-08-07 18:46:49 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/247

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/247

erinn commented

2019-08-07 19:52:05 +00:00

merge conflict (due to sarah's pr probably)

also the following is no longer correct:

onRemoveContact: function(handle) {
    for(var i = 0; i < contactsModel.count; i++){
        if(contactsModel.get(i)["_handle"] == handle) {
            console.log("deleting contact " + contactsModel.get(i)["_handle"])
            contactsModel.remove(i)
        }
    }
}

since contactsModel.remove(i) will shift the subsequent indices. however it's not semantically correct for there to be more than one contact with the same handle so it doesn't matter in practice; maybe put a return after the call to .remove() though, just to make it explicit?

merge conflict (due to sarah's pr probably) also the following is no longer correct: ``` onRemoveContact: function(handle) { for(var i = 0; i < contactsModel.count; i++){ if(contactsModel.get(i)["_handle"] == handle) { console.log("deleting contact " + contactsModel.get(i)["_handle"]) contactsModel.remove(i) } } } ``` since contactsModel.remove(i) will shift the subsequent indices. however it's not semantically correct for there to be more than one contact with the same handle so it doesn't matter in practice; maybe put a `return` after the call to .remove() though, just to make it explicit?

buildbot commented

2019-08-10 00:46:24 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/266

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/266

buildbot commented

2019-08-10 00:51:00 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/267

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/267

erinn closed this pull request

2019-08-10 02:26:37 +00:00