cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

Android Back button like home button #212

Merged
erinn merged 2 commits from :androidBack into master 2019-09-13 23:24:59 +00:00
Conversation 8 Commits 2 Files Changed 4 +41 -4
dan commented 2019-09-06 01:37:27 +00:00
Owner
Copy Link

Android back button default behaviour on root pane is to exit that app. That's not ideal so I've captured it and redirected to a home button like behaviour

It might be nice to have it do pane switching when not at root?

Android back button default behaviour on root pane is to exit that app. That's not ideal so I've captured it and redirected to a home button like behaviour It might be nice to have it do pane switching when not at root?
buildbot commented 2019-09-06 01:40:30 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/318

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/318
buildbot commented 2019-09-06 01:43:36 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/319

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/319
erinn was unassigned by dan 2019-09-11 18:03:06 +00:00
erinn was assigned by dan 2019-09-11 18:03:10 +00:00
erinn commented 2019-09-13 23:09:40 +00:00
Owner
Copy Link

updated back button handling (not very robust but i'm planning a layout manager change that will break this anyway so it's fine for now):
Keys.onPressed: {
if (event.key == Qt.Key_Back) {
event.accepted = true
if (theStack.currentIndex == theStack.emptyPane) {
androidCwtchActivity.rootHomeButtonHandle()
} else if (theStack.currentIndex == theStack.userProfilePane || theStack.currentIndex == theStack.groupProfilePane) {
theStack.currentIndex = theStack.messagePane
} else {
theStack.currentIndex = theStack.emptyPane
}
}
}
'''

updated back button handling (not very robust but i'm planning a layout manager change that will break this anyway so it's fine for now): Keys.onPressed: { if (event.key == Qt.Key_Back) { event.accepted = true if (theStack.currentIndex == theStack.emptyPane) { androidCwtchActivity.rootHomeButtonHandle() } else if (theStack.currentIndex == theStack.userProfilePane || theStack.currentIndex == theStack.groupProfilePane) { theStack.currentIndex = theStack.messagePane } else { theStack.currentIndex = theStack.emptyPane } } } '''
erinn requested changes 2019-09-13 23:15:34 +00:00
go/gothings/android/CwtchActivity.go Outdated
@ -14,2 +15,4 @@
_ func(string) `slot:"updateAndroidNotification"`
_ func() `signal:"rootHomeButtonHandle,auto""`
erinn commented 2019-09-13 23:14:01 +00:00
Owner

remove double-double-quote near eol

remove double-double-quote near eol
dan commented 2019-09-13 23:18:28 +00:00
Author
Owner
Copy Link

added

fixed!

thanks

added fixed! thanks
buildbot commented 2019-09-13 23:20:07 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/333

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/333
buildbot commented 2019-09-13 23:20:08 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/332

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/332
erinn approved these changes 2019-09-13 23:21:24 +00:00
buildbot commented 2019-09-13 23:23:16 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/335

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/335
buildbot commented 2019-09-13 23:23:16 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/334

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/334
erinn closed this pull request 2019-09-13 23:24:59 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
erinn
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#212
No description provided.
Delete Branch ":androidBack"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?