cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

editbox improvements #217

Merged
dan merged 5 commits from ebf201909201351 into master 2019-09-23 17:12:42 +00:00
Conversation 11 Commits 5 Files Changed 7 +74 -25
erinn commented 2019-09-20 20:54:48 +00:00
Owner
Copy Link
  • fix editbox text bleeding outside border when pixelDensity is low
  • add "edit" icon next to name on MyProfile panel
  • layout fixed for InplaceEditText because it was using width=100%;textalign=center for centering, which doesn't work with other components (like the new Edit icon) on the row
* fix editbox text bleeding outside border when pixelDensity is low * add "edit" icon next to name on MyProfile panel * layout fixed for InplaceEditText because it was using width=100%;textalign=center for centering, which doesn't work with other components (like the new Edit icon) on the row
dan was assigned by erinn 2019-09-20 20:54:48 +00:00
buildbot commented 2019-09-20 20:58:20 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/346

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/346
buildbot commented 2019-09-20 20:58:22 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/347

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/347
dan requested changes 2019-09-20 20:58:38 +00:00
dan left a comment
Owner

Does the edit button turn into like a "save" or "done" button? cus other wise its a bit unitutive, esp on android, how to save by randomly clicking till something else gets focus

Does the edit button turn into like a "save" or "done" button? cus other wise its a bit unitutive, esp on android, how to save by randomly clicking till something else gets focus
qml/widgets/MyProfile.qml Outdated
@ -105,3 +106,3 @@
onUpdated: {
nick = lblNick.text
//nick = lblNick.text
dan commented 2019-09-20 20:57:43 +00:00
Owner

delete?

delete?
erinn commented 2019-09-20 21:25:46 +00:00
Author
Owner
Copy Link
  • removed requested lines
  • added an "Update" button (shows up on android only, can change this if you think it should be visible on all platforms)
* removed requested lines * added an "Update" button (shows up on android only, can change this if you think it should be visible on all platforms)
buildbot commented 2019-09-20 21:26:02 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/352

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/352
buildbot commented 2019-09-20 21:26:03 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/353

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/353
buildbot commented 2019-09-20 21:28:37 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/356

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/356
buildbot commented 2019-09-20 21:28:43 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/357

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/357
buildbot commented 2019-09-20 21:44:21 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/363

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/363
buildbot commented 2019-09-20 21:44:22 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/362

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/362
dan reviewed 2019-09-21 17:23:09 +00:00
qml/widgets/InplaceEditText.qml Outdated
dan commented 2019-09-21 17:23:09 +00:00
Owner

Just needs the qtsr wrapper so it can be translated

Just needs the qtsr wrapper so it can be translated
buildbot commented 2019-09-23 17:10:57 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/367

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/367
buildbot commented 2019-09-23 17:10:58 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/366

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/366
dan closed this pull request 2019-09-23 17:12:42 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#217
No description provided.
Delete Branch "ebf201909201351"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?